Skip to contentSkip to conversation

warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR

PATCH New Fabio Estevam 3 participants 6 messages Oct 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR

warp7 uses the driver model and it retrieves the ESDHC base address from device tree.

Remove the unneeded CONFIG_SYS_FSL_ESDHC_ADDR definition.

---
 include/configs/warp7.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/warp7.h +0 -1
index 73541fe176..9c6ee6997f 100644
@@ -17,7 +17,6 @@
 #define CONFIG_SYS_MALLOC_LEN		(35 * SZ_1M)
 
 /* MMC Config*/
-#define CONFIG_SYS_FSL_ESDHC_ADDR       USDHC3_BASE_ADDR
 #define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
 #define CONFIG_SYS_MMC_IMG_LOAD_PART	1
 
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 warp7: Remove duplicate "mmc dev" command

The "mmc dev" command is being called twice.

Remove the extra call.

---
 include/configs/warp7.h | 1 -
 1 file changed, 1 deletion(-)
include/configs/warp7.h +0 -1
index 9c6ee6997f..f1fc6c714f 100644
@@ -94,7 +94,6 @@
 		"fi;\0" \
 
 #define CONFIG_BOOTCOMMAND \
-	   "mmc dev ${mmcdev};" \
 	   "mmc dev ${mmcdev}; if mmc rescan; then " \
 		   "run do_bootscript_hab;" \
 		   "if run loadbootscript; then " \
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/2 warp7: Remove duplicate "mmc dev" command

Hi Fabio,

Le 23/10/2019 à 16:20, Fabio Estevam a écrit :

Quoted 15 lines

The "mmc dev" command is being called twice.

Remove the extra call.

---
  include/configs/warp7.h | 1 -
  1 file changed, 1 deletion(-)
include/configs/warp7.h +0 -0
index 9c6ee6997f..f1fc6c714f 100644

include/configs/warp7.h line 99

Quoted 7 lines
include/configs/warp7.h +0 -1
@@ -94,7 +94,6 @@
  		"fi;\0" \
 
  #define CONFIG_BOOTCOMMAND \
-	   "mmc dev ${mmcdev};" \
  	   "mmc dev ${mmcdev}; if mmc rescan; then " \
  		   "run do_bootscript_hab;" \
  		   "if run loadbootscript; then " \

Thanks !

Signature · 3 lines
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io
#3 lore raw

PATCH 2/2 warp7: Remove duplicate "mmc dev" command

In reply to Fabio Estevam

Hi Fabio,

Le 23/10/2019 à 16:20, Fabio Estevam a écrit :

Quoted 14 lines

The "mmc dev" command is being called twice.

Remove the extra call.

---
  include/configs/warp7.h | 1 -
  1 file changed, 1 deletion(-)
include/configs/warp7.h +0 -0
index 9c6ee6997f..f1fc6c714f 100644

include/configs/warp7.h line 99

Quoted 7 lines
include/configs/warp7.h +0 -1
@@ -94,7 +94,6 @@
  		"fi;\0" \
 
  #define CONFIG_BOOTCOMMAND \
-	   "mmc dev ${mmcdev};" \
  	   "mmc dev ${mmcdev}; if mmc rescan; then " \
  		   "run do_bootscript_hab;" \
  		   "if run loadbootscript; then " \

Best regards,

Joris Offouga

#4 lore raw

PATCH 1/2 warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR

In reply to Fabio Estevam

Hi Fabio,

Le 23/10/2019 à 16:20, Fabio Estevam a écrit :

Quoted 16 lines

warp7 uses the driver model and it retrieves the ESDHC base address from device tree.

Remove the unneeded CONFIG_SYS_FSL_ESDHC_ADDR definition.

---
  include/configs/warp7.h | 1 -
  1 file changed, 1 deletion(-)
include/configs/warp7.h +0 -0
index 73541fe176..9c6ee6997f 100644

include/configs/warp7.h line 22

Quoted 7 lines
include/configs/warp7.h +0 -1
@@ -17,7 +17,6 @@
  #define CONFIG_SYS_MALLOC_LEN		(35 * SZ_1M)
 
  /* MMC Config*/
-#define CONFIG_SYS_FSL_ESDHC_ADDR       USDHC3_BASE_ADDR
  #define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
  #define CONFIG_SYS_MMC_IMG_LOAD_PART	1
 

Thanks !

Signature · 3 lines
Pierre-Jean Texier
Embedded Linux Engineer
https://koncepto.io
#5 lore raw

PATCH 1/2 warp7: Remove CONFIG_SYS_FSL_ESDHC_ADDR

In reply to Fabio Estevam

Hi Fabio,

Le 23/10/2019 à 16:20, Fabio Estevam a écrit :

Quoted 15 lines

warp7 uses the driver model and it retrieves the ESDHC base address from device tree.

Remove the unneeded CONFIG_SYS_FSL_ESDHC_ADDR definition.

---
  include/configs/warp7.h | 1 -
  1 file changed, 1 deletion(-)
include/configs/warp7.h +0 -0
index 73541fe176..9c6ee6997f 100644

include/configs/warp7.h line 22

Quoted 7 lines
include/configs/warp7.h +0 -1
@@ -17,7 +17,6 @@
  #define CONFIG_SYS_MALLOC_LEN		(35 * SZ_1M)
 
  /* MMC Config*/
-#define CONFIG_SYS_FSL_ESDHC_ADDR       USDHC3_BASE_ADDR
  #define CONFIG_SYS_FSL_ESDHC_HAS_DDR_MODE
  #define CONFIG_SYS_MMC_IMG_LOAD_PART	1
 

Best regards,

Joris Offouga