Skip to contentSkip to conversation

clk: samsung: exynos5433: Add missing slab.h header for kfree()

PATCH In review Krzysztof Kozlowski 2 participants 2 messages Oct 23, 2019 – Oct 29, 2019

Subsystems (3)
lore
Share & tools
lore

Krzysztof Kozlowski

author maintainer
#0 lore raw

PATCH 1/1 clk: samsung: exynos5433: Add missing slab.h header for kfree()

Usage of kfree() requires slab.h header. Otherwise building on x86_64 with COMPILE_TEST fails with:

drivers/clk/samsung/clk-exynos5433.c: In function ‘exynos5433_cmu_probe’:
drivers/clk/samsung/clk-exynos5433.c:5598:4: error: implicit declaration of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]

---
 drivers/clk/samsung/clk-exynos5433.c | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/samsung/clk-exynos5433.c +1 -0
index 0b60316331a0..4b1aa9382ad2 100644
@@ -13,6 +13,7 @@
 #include <linux/of_device.h>
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
+#include <linux/slab.h>
 
 #include <dt-bindings/clock/exynos5433.h>
 
Signature · 1 line
2.17.1
#1 lore raw
Quoted 9 lines · Krzysztof Kozlowski

Usage of kfree() requires slab.h header. Otherwise building on x86_64 with COMPILE_TEST fails with:

drivers/clk/samsung/clk-exynos5433.c: In function ‘exynos5433_cmu_probe’:
drivers/clk/samsung/clk-exynos5433.c:5598:4: error: implicit declaration
of function ‘kfree’; did you mean ‘vfree’? [-Werror=implicit-function-declaration]

Thanks, I applied it and squashed with the fix patch from Marek that introduced the above issue.

Signature · 2 lines
Regards,
Sylwester