Skip to contentSkip to conversation

package/dbus-python: fix build with python 3.8

PATCH New Grzegorz Blach 2 participants 3 messages Oct 23, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/dbus-python: fix build with python 3.8

Fixes:
- http://autobuild.buildroot.org/results/b30/b308eeb5c5d95ab9f1dbfc19f9183f2ba3ba0ce3/
- http://autobuild.buildroot.org/results/0dd/0dd9203f859b97ee5a3b6358644c26f8ab784ed8/
and many similar failures.

---
 package/dbus-python/dbus-python.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
package/dbus-python/dbus-python.mk +2 -2
index eaf4e5f483..1da912a3fb 100644
@@ -35,14 +35,14 @@ DBUS_PYTHON_DEPENDENCIES += python3 host-python3
 DBUS_PYTHON_CONF_ENV += \
 	PYTHON=$(HOST_DIR)/bin/python3 \
 	PYTHON_INCLUDES="`$(STAGING_DIR)/usr/bin/python3-config --includes`" \
-	PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags`"
+	PYTHON_LIBS="`$(STAGING_DIR)/usr/bin/python3-config --ldflags --embed`"
 
 HOST_DBUS_PYTHON_DEPENDENCIES += host-python3
 
 HOST_DBUS_PYTHON_CONF_ENV += \
 	PYTHON=$(HOST_DIR)/bin/python3 \
 	PYTHON_INCLUDES="`$(HOST_DIR)/usr/bin/python3-config --includes`" \
-	PYTHON_LIBS="`$(HOST_DIR)/usr/bin/python3-config --ldflags`"
+	PYTHON_LIBS="`$(HOST_DIR)/usr/bin/python3-config --ldflags --embed`"
 endif
 
 $(eval $(autotools-package))
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/dbus-python: fix build with python 3.8

Hello,

Quoted 6 lines · On Wed, 23 Oct 2019 13:10:57 +0000 Grzegorz Blach <[email protected]> wrote:

Fixes:
- http://autobuild.buildroot.org/results/b30/b308eeb5c5d95ab9f1dbfc19f9183f2ba3ba0ce3/
- http://autobuild.buildroot.org/results/0dd/0dd9203f859b97ee5a3b6358644c26f8ab784ed8/
and many similar failures.

Thanks for the investigation. However, as was investigated on kmod and libselinux, it is most likely not the correct solution. Since Python 3.8, Python extensions are not supposed to link with libpython. --embed is only for the cases where you *embed* a Python interpreter in your application/library, not when you implement a Python extension.

See the recent libselinux thread on this.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/dbus-python: fix build with python 3.8

Quoted 12 lines · Thomas Petazzoni

Hello,

Quoted 6 lines · On Wed, 23 Oct 2019 13:10:57 +0000 Grzegorz Blach <[email protected]> wrote:

Fixes:
- http://autobuild.buildroot.org/results/b30/b308eeb5c5d95ab9f1dbfc19f9183f2ba3ba0ce3/
- http://autobuild.buildroot.org/results/0dd/0dd9203f859b97ee5a3b6358644c26f8ab784ed8/
and many similar failures.

Quoted 7 lines

Thanks for the investigation. However, as was investigated on kmod and libselinux, it is most likely not the correct solution. Since Python 3.8, Python extensions are not supposed to link with libpython. --embed is only for the cases where you *embed* a Python interpreter in your application/library, not when you implement a Python extension.

See the recent libselinux thread on this.

Hello,

It looks I found a way how to build dbus-python without linking them against libpython3.so. Patch v2 has just been send.