Skip to contentSkip to conversation

dma/zx/remove: Removed dmam_pool_destroy from remove method

PATCH In review Satendra Singh Thakur 2 participants 3 messages Oct 24, 2019 – Nov 9, 2019 dmaengine

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma/zx/remove: Removed dmam_pool_destroy from remove method

In the probe method dmam_pool_create is used. Therefore, there is no need to explicitly call dmam_pool_destroy in remove method as this will be automatically taken care by devres

---
 drivers/dma/zx_dma.c | 1 -
 1 file changed, 1 deletion(-)
drivers/dma/zx_dma.c +0 -1
index 9f4436f7c914..7e4e457ac6d5 100644
@@ -894,7 +894,6 @@ static int zx_dma_remove(struct platform_device *op)
 		list_del(&c->vc.chan.device_node);
 	}
 	clk_disable_unprepare(d->clk);
-	dmam_pool_destroy(d->pool);
 
 	return 0;
 }
Signature · 1 line
2.17.1
maintainer
#1 lore raw
Quoted 3 lines · Satendra Singh Thakur

In the probe method dmam_pool_create is used. Therefore, there is no need to explicitly call dmam_pool_destroy in remove method as this will be automatically taken care by devres

Please do not reinvent system tags, git log is your friend to check for the tags to be used.

In this case, it is dmaengine: zx: remove ...

Quoted 20 lines
---
 drivers/dma/zx_dma.c | 1 -
 1 file changed, 1 deletion(-)
drivers/dma/zx_dma.c +0 -1
index 9f4436f7c914..7e4e457ac6d5 100644
@@ -894,7 +894,6 @@ static int zx_dma_remove(struct platform_device *op)
 		list_del(&c->vc.chan.device_node);
 	}
 	clk_disable_unprepare(d->clk);
-	dmam_pool_destroy(d->pool);
 
 	return 0;
 }
Signature · 1 line
2.17.1
Signature · 1 line
~Vinod
#2 lore raw

PATCH 1/1 dmaengine: zx: remove: removed dmam_pool_destroy

In the probe method dmam_pool_create is used. Therefore, there is no need to explicitly call dmam_pool_destroy in remove method as this will be automatically taken care by devres

---
v1: modified the subject line with new tags

 drivers/dma/zx_dma.c | 1 -
 1 file changed, 1 deletion(-)
drivers/dma/zx_dma.c +0 -1
index 9f4436f7c914..7e4e457ac6d5 100644
@@ -894,7 +894,6 @@ static int zx_dma_remove(struct platform_device *op)
 		list_del(&c->vc.chan.device_node);
 	}
 	clk_disable_unprepare(d->clk);
-	dmam_pool_destroy(d->pool);
 
 	return 0;
 }
Signature · 1 line
2.17.1