Skip to contentSkip to conversation

riscv: only select serial sifive if TTY is enabled

PATCH In review Kefeng Wang 2 participants 4 messages Oct 24, 2019 – Dec 9, 2019 RISC-V

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: only select serial sifive if TTY is enabled

There is some warning if TTY is not enabled, and lead to build error, only select serial sifive if TTY enabled, and this also makes randconfig happy.

---
 arch/riscv/Kconfig.socs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/riscv/Kconfig.socs +2 -2
index 536c0ef4aee8..c1043799e194 100644
@@ -2,8 +2,8 @@ menu "SoC selection"
 
 config SOC_SIFIVE
        bool "SiFive SoCs"
-       select SERIAL_SIFIVE
-       select SERIAL_SIFIVE_CONSOLE
+       select SERIAL_SIFIVE if TTY
+       select SERIAL_SIFIVE_CONSOLE if TTY
        select CLK_SIFIVE
        select CLK_SIFIVE_FU540_PRCI
        select SIFIVE_PLIC
Signature · 7 lines
2.20.1


_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
#2 lore raw
Quoted 9 lines · Paul Walmsley
Quoted 5 lines · Kefeng Wang

There is some warning if TTY is not enabled, and lead to build error, only select serial sifive if TTY enabled, and this also makes randconfig happy.

Thanks for doing these randconfig tests! Queued for v5.4-rc.

Hi Paul, this patch is not in v5.4 :)

Quoted 5 lines

- Paul

_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv

#3 lore raw

Hi Kefeng Wang,

Quoted 7 lines · Kefeng Wang
Quoted 6 lines · Paul Walmsley
Quoted 4 lines · Kefeng Wang

There is some warning if TTY is not enabled, and lead to build error, only select serial sifive if TTY enabled, and this also makes randconfig happy.

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Thanks for doing these randconfig tests! Queued for v5.4-rc.

Hi Paul, this patch is not in v5.4 :)

Sorry about that. I've re-queued it for v5.5-rc.

- Paul