Skip to contentSkip to conversation

rtw88: fix GENMASK_ULL for u64

PATCH In review [email protected] 2 participants 5 messages Oct 24, 2019 – Oct 25, 2019 Realtek wireless driver (rtw88)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rtw88: fix GENMASK_ULL for u64

From: Yan-Hsuan Chuang <[email protected]>

This fixes compile warning:

    In file included from include/linux/bitops.h:5:0,
                     from include/linux/kernel.h:12,
                     from include/asm-generic/bug.h:19,
                     from arch/mips/include/asm/bug.h:42,
                     from include/linux/bug.h:5,
                     from include/net/mac80211.h:16,
                     from drivers/net/wireless/realtek/rtw88/main.h:8,
                     from drivers/net/wireless/realtek/rtw88/main.c:5:
    drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_update_rate_mask':
      include/linux/bits.h:23:11: warning: right shift count is negative
      [-Wshift-count-negative]
       (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
               ^
    drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion of macro 'GENMASK'
      u64 cfg_mask = GENMASK(63, 0);
                     ^~~~~~~
Fixes f39e9bd49a3d ("rtw88: add set_bitrate_mask support")
---
 drivers/net/wireless/realtek/rtw88/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw88/main.c +1 -1
index 32e7328ce126..7c1b89c4fb6c 100644
@@ -627,7 +627,7 @@ static u64 rtw_update_rate_mask(struct rtw_dev *rtwdev,
 {
 	struct rtw_hal *hal = &rtwdev->hal;
 	const struct cfg80211_bitrate_mask *mask = si->mask;
-	u64 cfg_mask = GENMASK(63, 0);
+	u64 cfg_mask = GENMASK_ULL(63, 0);
 	u8 rssi_level, band;
 
 	if (wireless_set != WIRELESS_CCK) {
Signature · 1 line
2.17.1
#1 lore raw
Quoted 21 lines · <[email protected]> writes:

From: Yan-Hsuan Chuang <[email protected]>

This fixes compile warning:

    In file included from include/linux/bitops.h:5:0,
                     from include/linux/kernel.h:12,
                     from include/asm-generic/bug.h:19,
                     from arch/mips/include/asm/bug.h:42,
                     from include/linux/bug.h:5,
                     from include/net/mac80211.h:16,
                     from drivers/net/wireless/realtek/rtw88/main.h:8,
                     from drivers/net/wireless/realtek/rtw88/main.c:5:
    drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_update_rate_mask':
      include/linux/bits.h:23:11: warning: right shift count is negative
      [-Wshift-count-negative]
       (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
               ^
    drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion of macro 'GENMASK'
      u64 cfg_mask = GENMASK(63, 0);
                     ^~~~~~~
Quoted 2 lines
Fixes f39e9bd49a3d ("rtw88: add set_bitrate_mask support")

I'll add:

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#2 lore raw
Quoted 29 lines

Subject: Re: [PATCH] rtw88: fix GENMASK_ULL for u64

Quoted 11 lines · <[email protected]> writes:

From: Yan-Hsuan Chuang <[email protected]>

This fixes compile warning:

In file included from include/linux/bitops.h:5:0,
from include/linux/kernel.h:12, from include/asm-generic/bug.h:19, from arch/mips/include/asm/bug.h:42, from include/linux/bug.h:5, from include/net/mac80211.h:16, from

drivers/net/wireless/realtek/rtw88/main.h:8,

Quoted 1 line

from

drivers/net/wireless/realtek/rtw88/main.c:5:

Quoted 1 line

drivers/net/wireless/realtek/rtw88/main.c: In function

'rtw_update_rate_mask':

Quoted 5 lines

include/linux/bits.h:23:11: warning: right shift count is negative [-Wshift-count-negative]
(~UL(0) >> (BITS_PER_LONG - 1 - (h))))
^
drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion

of macro 'GENMASK'

Quoted 3 lines
      u64 cfg_mask = GENMASK(63, 0);
                     ^~~~~~~
Quoted 7 lines
Quoted 2 lines
Fixes f39e9bd49a3d ("rtw88: add set_bitrate_mask support")

I'll add:

Yes, please add it, I forgot about it.
Thanks

Yan-Hsuan

#3 lore raw
In reply to Kalle Valo
Quoted 23 lines · Kalle Valo
Quoted 21 lines · <[email protected]> writes:

From: Yan-Hsuan Chuang <[email protected]>

This fixes compile warning:

    In file included from include/linux/bitops.h:5:0,
                     from include/linux/kernel.h:12,
                     from include/asm-generic/bug.h:19,
                     from arch/mips/include/asm/bug.h:42,
                     from include/linux/bug.h:5,
                     from include/net/mac80211.h:16,
                     from drivers/net/wireless/realtek/rtw88/main.h:8,
                     from drivers/net/wireless/realtek/rtw88/main.c:5:
    drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_update_rate_mask':
      include/linux/bits.h:23:11: warning: right shift count is negative
      [-Wshift-count-negative]
       (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
               ^
    drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion of macro 'GENMASK'
      u64 cfg_mask = GENMASK(63, 0);
                     ^~~~~~~
Quoted 6 lines
Quoted 2 lines
Fixes f39e9bd49a3d ("rtw88: add set_bitrate_mask support")

I'll add:

Oh nice, patchwork automatically added the tag from my email above and I didn't have to do anything :)

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
#4 lore raw
In reply to [email protected]
Quoted 21 lines · <[email protected]> wrote:

From: Yan-Hsuan Chuang <[email protected]>

This fixes compile warning:

    In file included from include/linux/bitops.h:5:0,
                     from include/linux/kernel.h:12,
                     from include/asm-generic/bug.h:19,
                     from arch/mips/include/asm/bug.h:42,
                     from include/linux/bug.h:5,
                     from include/net/mac80211.h:16,
                     from drivers/net/wireless/realtek/rtw88/main.h:8,
                     from drivers/net/wireless/realtek/rtw88/main.c:5:
    drivers/net/wireless/realtek/rtw88/main.c: In function 'rtw_update_rate_mask':
      include/linux/bits.h:23:11: warning: right shift count is negative
      [-Wshift-count-negative]
       (~UL(0) >> (BITS_PER_LONG - 1 - (h))))
               ^
    drivers/net/wireless/realtek/rtw88/main.c:622:17: note: in expansion of macro 'GENMASK'
      u64 cfg_mask = GENMASK(63, 0);
                     ^~~~~~~
Quoted 4 lines
Fixes f39e9bd49a3d ("rtw88: add set_bitrate_mask support")

Patch applied to wireless-drivers-next.git, thanks.

5c70e9714254 rtw88: fix GENMASK_ULL for u64

Signature · 3 lines
https://patchwork.kernel.org/patch/11208607/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches