Skip to contentSkip to conversation

Delete New ext4 features tests and ffsb tool

RFC PATCH New Petr Vorel 2 participants 3 messages Oct 24, 2019

lore
Share & tools
lore

Petr Vorel

author
#0 lore raw

RFC PATCH 1/1 Delete New ext4 features tests and ffsb tool

and associated runtest file fs_ext4.

The main reason is that these tests [1] (contributed in 2009) are mostly outdated and irrelevant. According to Theodore Y. Tso [2] and Jan Kara [3] the only partly valid tests are ext4_nsec_timestamps_test.sh and ext4_subdir_limit_test.sh, but even these would be better to migrate to xfstests, which Yong Sun is planning to do.

Also, some of the tests weren't in any runtest file anyway (ext4-alloc-test.sh, ext4_inode_version_test.sh, ext4_journal_checksum.sh, ext4_online_defrag_test.sh)

ffsb tool was used only in these New ext4 features tests.

[1] http://ext4.wiki.kernel.org/index.php/New_ext4_features
[2] https://marc.info/?l=linux-fsdevel&m=157187153211649&w=2
[3] https://marc.info/?l=linux-ext4&m=157190318618555&w=2

Closes #560
---
 configure.ac                                  |    2 -
 runtest/fs_ext4                               |    4 -
 .../kernel/fs/ext4-new-features/.gitignore    |    4 -
 .../kernel/fs/ext4-new-features/Makefile      |   27 -
 testcases/kernel/fs/ext4-new-features/README  |  127 -
 .../ext4-delalloc-mballoc/Makefile            |   25 -
 .../ext4-delalloc-mballoc/ext4-alloc-test.sh  |  146 -
 .../ext4-ffsb-config/Makefile                 |   26 -
 .../ext4-ffsb-config/ffsb-config0             |   23 -
 .../ext4-ffsb-config/ffsb-config1             |   23 -
 .../ext4-ffsb-config/ffsb-config2             |   23 -
 .../ext4-ffsb-config/ffsb-config3             |   29 -
 .../ext4-ffsb-config/ffsb-config4             |   29 -
 .../ext4-ffsb-config/ffsb-config5             |   29 -
 .../ext4-ffsb-config/ffsb-config6             |   29 -
 .../ext4-ffsb-config/ffsb-config7             |   29 -
 .../ext4-inode-version/Makefile               |   25 -
 .../ext4_get_inode_version.sh                 |   41 -
 .../ext4_inode_version_test.sh                |  158 -
 .../ext4_test_inode_version.c                 |  217 -
 .../ext4-journal-checksum/Makefile            |   25 -
 .../ext4_journal_checksum.sh                  |  133 -
 .../ext4-nsec-timestamps/Makefile             |   25 -
 .../ext4-nsec-timestamps/ext4_file_time.c     |   69 -
 .../ext4_nsec_timestamps_test.sh              |  163 -
 .../ext4-online-defrag/Makefile               |   25 -
 .../ext4_online_defrag_test.sh                |  182 -
 .../ext4-persist-prealloc/Makefile            |   25 -
 .../ext4_persist_prealloc_test.sh             |   90 -
 .../ext4-subdir-limit/Makefile                |   25 -
 .../ext4-subdir-limit/create_long_dirs.c      |  161 -
 .../ext4-subdir-limit/create_short_dirs.c     |  163 -
 .../ext4_subdir_limit_test.sh                 |  156 -
 .../ext4-uninit-groups/Makefile               |   25 -
 .../ext4_uninit_groups_test.sh                |  142 -
 .../kernel/fs/ext4-new-features/ext4_funcs.sh |   63 -
 utils/.gitignore                              |    9 -
 utils/ffsb-6.0-rc2/AUTHORS                    |    7 -
 utils/ffsb-6.0-rc2/COPYING                    |  340 -
 utils/ffsb-6.0-rc2/INSTALL                    |  182 -
 utils/ffsb-6.0-rc2/LICENSE                    |  347 -
 utils/ffsb-6.0-rc2/Makefile.am                |   46 -
 utils/ffsb-6.0-rc2/Makefile.in                |  628 --
 utils/ffsb-6.0-rc2/README                     |  413 -
 utils/ffsb-6.0-rc2/aclocal.m4                 |  880 ---
 utils/ffsb-6.0-rc2/cirlist.c                  |  106 -
 utils/ffsb-6.0-rc2/cirlist.h                  |   41 -
 utils/ffsb-6.0-rc2/config.guess               |    1 -
 utils/ffsb-6.0-rc2/config.h.in                |  130 -
 utils/ffsb-6.0-rc2/config.sub                 |    1 -
 utils/ffsb-6.0-rc2/configure                  | 7000 -----------------
 utils/ffsb-6.0-rc2/configure.in               |   50 -
 utils/ffsb-6.0-rc2/depcomp                    |  472 --
 .../ffsb-6.0-rc2/examples/profile_everything  |  119 -
 utils/ffsb-6.0-rc2/ffsb.h                     |  105 -
 utils/ffsb-6.0-rc2/ffsb_fc.c                  |  109 -
 utils/ffsb-6.0-rc2/ffsb_fs.c                  |  630 --
 utils/ffsb-6.0-rc2/ffsb_fs.h                  |  184 -
 utils/ffsb-6.0-rc2/ffsb_op.c                  |  192 -
 utils/ffsb-6.0-rc2/ffsb_op.h                  |  102 -
 utils/ffsb-6.0-rc2/ffsb_stats.c               |  240 -
 utils/ffsb-6.0-rc2/ffsb_stats.h               |  109 -
 utils/ffsb-6.0-rc2/ffsb_tg.c                  |  369 -
 utils/ffsb-6.0-rc2/ffsb_tg.h                  |  206 -
 utils/ffsb-6.0-rc2/ffsb_thread.c              |  171 -
 utils/ffsb-6.0-rc2/ffsb_thread.h              |  108 -
 utils/ffsb-6.0-rc2/fh.c                       |  280 -
 utils/ffsb-6.0-rc2/fh.h                       |   43 -
 utils/ffsb-6.0-rc2/filelist.c                 |  499 --
 utils/ffsb-6.0-rc2/filelist.h                 |  145 -
 utils/ffsb-6.0-rc2/fileops.c                  |  543 --
 utils/ffsb-6.0-rc2/fileops.h                  |   51 -
 utils/ffsb-6.0-rc2/install-sh                 |  250 -
 utils/ffsb-6.0-rc2/list.c                     |   53 -
 utils/ffsb-6.0-rc2/list.h                     |   53 -
 utils/ffsb-6.0-rc2/main.c                     |  255 -
 utils/ffsb-6.0-rc2/metaops.c                  |  112 -
 utils/ffsb-6.0-rc2/metaops.h                  |   28 -
 utils/ffsb-6.0-rc2/missing                    |  336 -
 utils/ffsb-6.0-rc2/mkinstalldirs              |   40 -
 utils/ffsb-6.0-rc2/parser.c                   | 1051 ---
 utils/ffsb-6.0-rc2/parser.h                   |  151 -
 utils/ffsb-6.0-rc2/public-description         |    4 -
 utils/ffsb-6.0-rc2/rand.c                     |  188 -
 utils/ffsb-6.0-rc2/rand.h                     |   60 -
 utils/ffsb-6.0-rc2/rbt.c                      | 1063 ---
 utils/ffsb-6.0-rc2/rbt.h                      |  316 -
 utils/ffsb-6.0-rc2/registration-description   |    7 -
 utils/ffsb-6.0-rc2/rwlock.c                   |  108 -
 utils/ffsb-6.0-rc2/rwlock.h                   |   51 -
 utils/ffsb-6.0-rc2/stamp-h.in                 |    1 -
 utils/ffsb-6.0-rc2/util.c                     |  345 -
 utils/ffsb-6.0-rc2/util.h                     |   94 -
 93 files changed, 21912 deletions(-)
 delete mode 100644 runtest/fs_ext4
 delete mode 100644 testcases/kernel/fs/ext4-new-features/.gitignore
 delete mode 100644 testcases/kernel/fs/ext4-new-features/Makefile
 delete mode 100644 testcases/kernel/fs/ext4-new-features/README
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/Makefile
 delete mode 100755 testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/Makefile
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config0
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config1
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config2
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config3
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config4
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config5
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config6
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config7
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-inode-version/Makefile
 delete mode 100755 testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_get_inode_version.sh
 delete mode 100755 testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_test_inode_version.c
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-journal-checksum/Makefile
 delete mode 100755 testcases/kernel/fs/ext4-new-features/ext4-journal-checksum/ext4_journal_checksum.sh
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-nsec-timestamps/Makefile
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-nsec-timestamps/ext4_file_time.c
 delete mode 100755 testcases/kernel/fs/ext4-new-features/ext4-nsec-timestamps/ext4_nsec_timestamps_test.sh
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-online-defrag/Makefile
 delete mode 100755 testcases/kernel/fs/ext4-new-features/ext4-online-defrag/ext4_online_defrag_test.sh
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-persist-prealloc/Makefile
 delete mode 100755 testcases/kernel/fs/ext4-new-features/ext4-persist-prealloc/ext4_persist_prealloc_test.sh
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/Makefile
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/create_long_dirs.c
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/create_short_dirs.c
 delete mode 100755 testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh
 delete mode 100644 testcases/kernel/fs/ext4-new-features/ext4-uninit-groups/Makefile
 delete mode 100755 testcases/kernel/fs/ext4-new-features/ext4-uninit-groups/ext4_uninit_groups_test.sh
 delete mode 100755 testcases/kernel/fs/ext4-new-features/ext4_funcs.sh
 delete mode 100644 utils/ffsb-6.0-rc2/AUTHORS
 delete mode 100644 utils/ffsb-6.0-rc2/COPYING
 delete mode 100644 utils/ffsb-6.0-rc2/INSTALL
 delete mode 100644 utils/ffsb-6.0-rc2/LICENSE
 delete mode 100644 utils/ffsb-6.0-rc2/Makefile.am
 delete mode 100644 utils/ffsb-6.0-rc2/Makefile.in
 delete mode 100644 utils/ffsb-6.0-rc2/README
 delete mode 100644 utils/ffsb-6.0-rc2/aclocal.m4
 delete mode 100644 utils/ffsb-6.0-rc2/cirlist.c
 delete mode 100644 utils/ffsb-6.0-rc2/cirlist.h
 delete mode 120000 utils/ffsb-6.0-rc2/config.guess
 delete mode 100644 utils/ffsb-6.0-rc2/config.h.in
 delete mode 120000 utils/ffsb-6.0-rc2/config.sub
 delete mode 100755 utils/ffsb-6.0-rc2/configure
 delete mode 100644 utils/ffsb-6.0-rc2/configure.in
 delete mode 100755 utils/ffsb-6.0-rc2/depcomp
 delete mode 100644 utils/ffsb-6.0-rc2/examples/profile_everything
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb.h
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_fc.c
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_fs.c
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_fs.h
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_op.c
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_op.h
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_stats.c
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_stats.h
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_tg.c
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_tg.h
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_thread.c
 delete mode 100644 utils/ffsb-6.0-rc2/ffsb_thread.h
 delete mode 100644 utils/ffsb-6.0-rc2/fh.c
 delete mode 100644 utils/ffsb-6.0-rc2/fh.h
 delete mode 100644 utils/ffsb-6.0-rc2/filelist.c
 delete mode 100644 utils/ffsb-6.0-rc2/filelist.h
 delete mode 100644 utils/ffsb-6.0-rc2/fileops.c
 delete mode 100644 utils/ffsb-6.0-rc2/fileops.h
 delete mode 100755 utils/ffsb-6.0-rc2/install-sh
 delete mode 100644 utils/ffsb-6.0-rc2/list.c
 delete mode 100644 utils/ffsb-6.0-rc2/list.h
 delete mode 100644 utils/ffsb-6.0-rc2/main.c
 delete mode 100644 utils/ffsb-6.0-rc2/metaops.c
 delete mode 100644 utils/ffsb-6.0-rc2/metaops.h
 delete mode 100755 utils/ffsb-6.0-rc2/missing
 delete mode 100755 utils/ffsb-6.0-rc2/mkinstalldirs
 delete mode 100644 utils/ffsb-6.0-rc2/parser.c
 delete mode 100644 utils/ffsb-6.0-rc2/parser.h
 delete mode 100644 utils/ffsb-6.0-rc2/public-description
 delete mode 100644 utils/ffsb-6.0-rc2/rand.c
 delete mode 100644 utils/ffsb-6.0-rc2/rand.h
 delete mode 100644 utils/ffsb-6.0-rc2/rbt.c
 delete mode 100644 utils/ffsb-6.0-rc2/rbt.h
 delete mode 100644 utils/ffsb-6.0-rc2/registration-description
 delete mode 100644 utils/ffsb-6.0-rc2/rwlock.c
 delete mode 100644 utils/ffsb-6.0-rc2/rwlock.h
 delete mode 100644 utils/ffsb-6.0-rc2/stamp-h.in
 delete mode 100644 utils/ffsb-6.0-rc2/util.c
 delete mode 100644 utils/ffsb-6.0-rc2/util.h
configure.ac +0 -2
index 3785dff63..553b70b7c 100644
@@ -200,8 +200,6 @@ else
     AC_SUBST([WITH_REALTIME_TESTSUITE],["no"])
 fi
 
-AC_CONFIG_SUBDIRS([utils/ffsb-6.0-rc2])
-
 AC_CONFIG_COMMANDS([syscalls.h], [cd ${ac_top_srcdir}/include/lapi/syscalls; ./regen.sh])
 
 # custom functions
runtest/fs_ext4 deleted +0 -4
deleted file mode 100644
index 35697c511..000000000
@@ -1,4 +0,0 @@
-ext4-nsec-timestamps	ext4_nsec_timestamps_test.sh
-ext4-uninit-groups	ext4_uninit_groups_test.sh
-ext4-persist-prealloc	ext4_persist_prealloc_test.sh
-ext4-subdir-limit	ext4_subdir_limit_test.sh
testcases/kernel/fs/ext4-new-features/.gitignore deleted +0 -4
deleted file mode 100644
index d0f1f74d8..000000000
@@ -1,4 +0,0 @@
-/ext4-inode-version/ext4_test_inode_version
-/ext4-nsec-timestamps/ext4_file_time
-/ext4-subdir-limit/create_long_dirs
-/ext4-subdir-limit/create_short_dirs
testcases/kernel/fs/ext4-new-features/Makefile deleted +0 -27
deleted file mode 100644
index 5f4349d94..000000000
@@ -1,27 +0,0 @@
-#
-#    kernel/fs/ext4-new-features testcases Makefile.
-#
-#    Copyright (C) 2009, Cisco Systems Inc.
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-
-top_srcdir              ?= ../../../..
-
-include $(top_srcdir)/include/mk/env_pre.mk
-
-INSTALL_TARGETS		+= ext4_funcs.sh
-
-include $(top_srcdir)/include/mk/generic_trunk_target.mk
testcases/kernel/fs/ext4-new-features/README deleted +0 -127

127 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/Makefile deleted +0 -25
deleted file mode 100644
index 1980349a7..000000000
@@ -1,25 +0,0 @@
-#    Copyright (C) 2009, Fujitsu LIMITED
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-
-top_srcdir              ?= ../../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-MAKE_TARGETS		:=
-INSTALL_TARGETS		?= *.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/fs/ext4-new-features/ext4-delalloc-mballoc/ext4-alloc-test.sh deleted +0 -146

146 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/Makefile deleted +0 -26
deleted file mode 100644
index 173a58342..000000000
@@ -1,26 +0,0 @@
-#    Copyright (C) 2009, FUJITSU LIMITED
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-
-top_srcdir              ?= ../../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-MAKE_TARGETS		:=
-INSTALL_DIR	:= testcases/data/ext4-ffsb/
-INSTALL_TARGETS		?= ffsb-config[0-7]
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config0 deleted +0 -23
deleted file mode 100644
index caf192837..000000000
@@ -1,23 +0,0 @@
-directio=0
-time=500
-
-[filesystem0]
-location=mnt_point
-num_files=100000
-num_dirs=40
-max_filesize=40960
-min_filesize=4096
-[end0]
-
-
-[threadgroup0]
-num_threads=10
-read_weight=3
-write_weight=1
-append_weight=1
-write_random=1
-write_size=4096
-write_blocksize=4096
-read_size=4096
-read_blocksize=4096
-[end0]
testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config1 deleted +0 -23
deleted file mode 100644
index 9fe820dd8..000000000
@@ -1,23 +0,0 @@
-directio=1
-time=400
-
-[filesystem0]
-location=mnt_point
-num_files=100000
-num_dirs=40
-max_filesize=4096
-min_filesize=4096
-[end0]
-
-
-[threadgroup0]
-num_threads=10
-read_weight=3
-write_weight=1
-append_weight=1
-write_random=1
-write_size=4096
-write_blocksize=4096
-read_size=4096
-read_blocksize=4096
-[end0]
testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config2 deleted +0 -23
deleted file mode 100644
index 993fe141d..000000000
@@ -1,23 +0,0 @@
-directio=0
-time=500
-
-[filesystem0]
-location=mnt_point
-num_files=100000
-num_dirs=40
-max_filesize=20480
-min_filesize=4096
-[end0]
-
-
-[threadgroup0]
-num_threads=10
-read_weight=3
-write_weight=1
-append_weight=1
-write_random=1
-write_size=4096
-write_blocksize=4096
-read_size=4096
-read_blocksize=4096
-[end0]
testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config3 deleted +0 -29
deleted file mode 100644
index d95149dd7..000000000
@@ -1,29 +0,0 @@
-directio=0
-time=0
-
-[filesystem0]
-	location=mnt_point/
-	num_files=1
-	num_dirs=1
-	max_filesize=409600
-	min_filesize=40960
-	agefs=1
-	[threadgroup0]
-		num_threads=10
-		write_size=409600
-		write_blocksize=40960
-		create_weight=10
-		append_weight=10
-		delete_weight=1
-	[end0]
-		desired_util=0.20
-[end0]
-
-[threadgroup0]
-	num_threads=32
-	read_weight=1
-
-	read_size=4096
-	read_blocksize=4096
-[end0]
-
testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config4 deleted +0 -29
deleted file mode 100644
index f1a432e2a..000000000
@@ -1,29 +0,0 @@
-directio=0
-time=0
-
-[filesystem0]
-	location=mnt_point/
-	num_files=1
-	num_dirs=1
-	max_filesize=409600
-	min_filesize=40960
-	agefs=1
-	[threadgroup0]
-		num_threads=10
-		write_size=409600
-		write_blocksize=40960
-		create_weight=10
-		append_weight=10
-		delete_weight=1
-	[end0]
-		desired_util=0.40
-[end0]
-
-[threadgroup0]
-	num_threads=32
-	read_weight=1
-
-	read_size=4096
-	read_blocksize=4096
-[end0]
-
testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config5 deleted +0 -29
deleted file mode 100644
index 758ededaa..000000000
@@ -1,29 +0,0 @@
-directio=0
-time=0
-
-[filesystem0]
-	location=mnt_point/
-	num_files=1
-	num_dirs=1
-	max_filesize=409600
-	min_filesize=40960
-	agefs=1
-	[threadgroup0]
-		num_threads=10
-		write_size=409600
-		write_blocksize=40960
-		create_weight=10
-		append_weight=10
-		delete_weight=1
-	[end0]
-		desired_util=0.60
-[end0]
-
-[threadgroup0]
-	num_threads=32
-	read_weight=1
-
-	read_size=4096
-	read_blocksize=4096
-[end0]
-
testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config6 deleted +0 -29
deleted file mode 100644
index 659217790..000000000
@@ -1,29 +0,0 @@
-directio=0
-time=0
-
-[filesystem0]
-	location=mnt_point/
-	num_files=1
-	num_dirs=1
-	max_filesize=409600
-	min_filesize=40960
-	agefs=1
-	[threadgroup0]
-		num_threads=10
-		write_size=409600
-		write_blocksize=40960
-		create_weight=10
-		append_weight=10
-		delete_weight=1
-	[end0]
-		desired_util=0.80
-[end0]
-
-[threadgroup0]
-	num_threads=32
-	read_weight=1
-
-	read_size=4096
-	read_blocksize=4096
-[end0]
-
testcases/kernel/fs/ext4-new-features/ext4-ffsb-config/ffsb-config7 deleted +0 -29
deleted file mode 100644
index 0f6df51fa..000000000
@@ -1,29 +0,0 @@
-directio=0
-time=0
-
-[filesystem0]
-	location=mnt_point/
-	num_files=1
-	num_dirs=1
-	max_filesize=409600
-	min_filesize=40960
-	agefs=1
-	[threadgroup0]
-		num_threads=10
-		write_size=409600
-		write_blocksize=40960
-		create_weight=10
-		append_weight=10
-		delete_weight=1
-	[end0]
-		desired_util=1.00
-[end0]
-
-[threadgroup0]
-	num_threads=32
-	read_weight=1
-
-	read_size=4096
-	read_blocksize=4096
-[end0]
-
testcases/kernel/fs/ext4-new-features/ext4-inode-version/Makefile deleted +0 -25
deleted file mode 100644
index 6b8aabb9e..000000000
@@ -1,25 +0,0 @@
-#    Copyright (C) 2009, FUJITSU LIMITED
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-
-top_srcdir              ?= ../../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-LDLIBS += -lm
-INSTALL_TARGETS		?= *.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_get_inode_version.sh deleted +0 -41

41 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_inode_version_test.sh deleted +0 -158

158 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-inode-version/ext4_test_inode_version.c deleted +0 -217

217 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-journal-checksum/Makefile deleted +0 -25
deleted file mode 100644
index 1980349a7..000000000
@@ -1,25 +0,0 @@
-#    Copyright (C) 2009, Fujitsu LIMITED
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-
-top_srcdir              ?= ../../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-MAKE_TARGETS		:=
-INSTALL_TARGETS		?= *.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/fs/ext4-new-features/ext4-journal-checksum/ext4_journal_checksum.sh deleted +0 -133

133 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-nsec-timestamps/Makefile deleted +0 -25
deleted file mode 100644
index 6b8aabb9e..000000000
@@ -1,25 +0,0 @@
-#    Copyright (C) 2009, FUJITSU LIMITED
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-
-top_srcdir              ?= ../../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-LDLIBS += -lm
-INSTALL_TARGETS		?= *.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/fs/ext4-new-features/ext4-nsec-timestamps/ext4_file_time.c deleted +0 -69

69 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-nsec-timestamps/ext4_nsec_timestamps_test.sh deleted +0 -163

163 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-online-defrag/Makefile deleted +0 -25
deleted file mode 100644
index 6b8aabb9e..000000000
@@ -1,25 +0,0 @@
-#    Copyright (C) 2009, FUJITSU LIMITED
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-
-top_srcdir              ?= ../../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-LDLIBS += -lm
-INSTALL_TARGETS		?= *.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/fs/ext4-new-features/ext4-online-defrag/ext4_online_defrag_test.sh deleted +0 -182

182 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-persist-prealloc/Makefile deleted +0 -25
deleted file mode 100644
index 1980349a7..000000000
@@ -1,25 +0,0 @@
-#    Copyright (C) 2009, Fujitsu LIMITED
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-
-top_srcdir              ?= ../../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-MAKE_TARGETS		:=
-INSTALL_TARGETS		?= *.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/fs/ext4-new-features/ext4-persist-prealloc/ext4_persist_prealloc_test.sh deleted +0 -90

90 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/Makefile deleted +0 -25
deleted file mode 100644
index 6b8aabb9e..000000000
@@ -1,25 +0,0 @@
-#    Copyright (C) 2009, FUJITSU LIMITED
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-
-top_srcdir              ?= ../../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-LDLIBS += -lm
-INSTALL_TARGETS		?= *.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/create_long_dirs.c deleted +0 -161

161 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/create_short_dirs.c deleted +0 -163

163 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-subdir-limit/ext4_subdir_limit_test.sh deleted +0 -156

156 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4-uninit-groups/Makefile deleted +0 -25
deleted file mode 100644
index 1980349a7..000000000
@@ -1,25 +0,0 @@
-#    Copyright (C) 2009, Fujitsu LIMITED
-#
-#    This program is free software; you can redistribute it and/or modify
-#    it under the terms of the GNU General Public License as published by
-#    the Free Software Foundation; either version 2 of the License, or
-#    (at your option) any later version.
-#
-#    This program is distributed in the hope that it will be useful,
-#    but WITHOUT ANY WARRANTY; without even the implied warranty of
-#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-#    GNU General Public License for more details.
-#
-#    You should have received a copy of the GNU General Public License along
-#    with this program; if not, write to the Free Software Foundation, Inc.,
-#    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-#
-
-top_srcdir              ?= ../../../../..
-
-include $(top_srcdir)/include/mk/testcases.mk
-
-MAKE_TARGETS		:=
-INSTALL_TARGETS		?= *.sh
-
-include $(top_srcdir)/include/mk/generic_leaf_target.mk
testcases/kernel/fs/ext4-new-features/ext4-uninit-groups/ext4_uninit_groups_test.sh deleted +0 -142

142 lines not on this page · raw message

testcases/kernel/fs/ext4-new-features/ext4_funcs.sh deleted +0 -63

63 lines not on this page · raw message

utils/.gitignore +0 -9
index a5827489a..5b6dfd064 100644
@@ -1,12 +1,3 @@
-/ffsb
-/ffsb-6.0-rc2/.deps/
-/ffsb-6.0-rc2/ffsb
-/ffsb-6.0-rc2/Makefile
-/ffsb-6.0-rc2/config.h
-/ffsb-6.0-rc2/config.log
-/ffsb-6.0-rc2/config.status
-/ffsb-6.0-rc2/stamp-h
-/ffsb-6.0-rc2/stamp-h1
 /sctp/func_tests/test_1_to_1_accept_close
 /sctp/func_tests/test_1_to_1_addrs
 /sctp/func_tests/test_1_to_1_connect
utils/ffsb-6.0-rc2/AUTHORS deleted +0 -7
deleted file mode 100644
index 85d037dca..000000000
@@ -1,7 +0,0 @@
-Dominique Heger ([email protected])
-Josh Jacobs ([email protected])
-
--> up to Version 3.0 of FFSB
-
-Sonny Rao ([email protected])
-versions 3.1 and beyond
utils/ffsb-6.0-rc2/COPYING deleted +0 -340

340 lines not on this page · raw message

utils/ffsb-6.0-rc2/INSTALL deleted +0 -182

147 lines not on this page · raw message

utils/ffsb-6.0-rc2/LICENSE deleted +0 -347

347 lines not on this page · raw message

utils/ffsb-6.0-rc2/Makefile.am deleted +0 -46

46 lines not on this page · raw message

utils/ffsb-6.0-rc2/Makefile.in deleted +0 -628

628 lines not on this page · raw message

utils/ffsb-6.0-rc2/README deleted +0 -413

413 lines not on this page · raw message

utils/ffsb-6.0-rc2/aclocal.m4 deleted +0 -880

880 lines not on this page · raw message

utils/ffsb-6.0-rc2/cirlist.c deleted +0 -106

106 lines not on this page · raw message

utils/ffsb-6.0-rc2/cirlist.h deleted +0 -41

41 lines not on this page · raw message

utils/ffsb-6.0-rc2/config.guess deleted +0 -1
deleted file mode 120000
index 2442af0f1..000000000

Lines of this file are not shown. View the raw message.

utils/ffsb-6.0-rc2/config.h.in deleted +0 -130

130 lines not on this page · raw message

utils/ffsb-6.0-rc2/config.sub deleted +0 -1
deleted file mode 120000
index f1d837bfb..000000000

Lines of this file are not shown. View the raw message.

utils/ffsb-6.0-rc2/configure deleted +0 -7000

7,000 lines not on this page · raw message

utils/ffsb-6.0-rc2/configure.in deleted +0 -50

50 lines not on this page · raw message

utils/ffsb-6.0-rc2/depcomp deleted +0 -472

472 lines not on this page · raw message

utils/ffsb-6.0-rc2/examples/profile_everything deleted +0 -119

119 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb.h deleted +0 -105

105 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_fc.c deleted +0 -109

109 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_fs.c deleted +0 -630

630 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_fs.h deleted +0 -184

184 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_op.c deleted +0 -192

192 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_op.h deleted +0 -102

102 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_stats.c deleted +0 -240

240 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_stats.h deleted +0 -109

109 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_tg.c deleted +0 -369

369 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_tg.h deleted +0 -206

206 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_thread.c deleted +0 -171

171 lines not on this page · raw message

utils/ffsb-6.0-rc2/ffsb_thread.h deleted +0 -108

108 lines not on this page · raw message

utils/ffsb-6.0-rc2/fh.c deleted +0 -280

280 lines not on this page · raw message

utils/ffsb-6.0-rc2/fh.h deleted +0 -43

43 lines not on this page · raw message

utils/ffsb-6.0-rc2/filelist.c deleted +0 -499

499 lines not on this page · raw message

utils/ffsb-6.0-rc2/filelist.h deleted +0 -145

145 lines not on this page · raw message

utils/ffsb-6.0-rc2/fileops.c deleted +0 -543

543 lines not on this page · raw message

utils/ffsb-6.0-rc2/fileops.h deleted +0 -51

51 lines not on this page · raw message

utils/ffsb-6.0-rc2/install-sh deleted +0 -250

250 lines not on this page · raw message

utils/ffsb-6.0-rc2/list.c deleted +0 -53

53 lines not on this page · raw message

utils/ffsb-6.0-rc2/list.h deleted +0 -53

53 lines not on this page · raw message

utils/ffsb-6.0-rc2/main.c deleted +0 -255

255 lines not on this page · raw message

utils/ffsb-6.0-rc2/metaops.c deleted +0 -112

112 lines not on this page · raw message

utils/ffsb-6.0-rc2/metaops.h deleted +0 -28
deleted file mode 100644
index 3f81e4fd6..000000000

Lines of this file are not shown. View the raw message.

utils/ffsb-6.0-rc2/missing deleted +0 -336

336 lines not on this page · raw message

utils/ffsb-6.0-rc2/mkinstalldirs deleted +0 -40
deleted file mode 100755
index 1790da117..000000000

Lines of this file are not shown. View the raw message.

utils/ffsb-6.0-rc2/parser.c deleted +0 -1051

1,051 lines not on this page · raw message

utils/ffsb-6.0-rc2/parser.h deleted +0 -151

151 lines not on this page · raw message

utils/ffsb-6.0-rc2/public-description deleted +0 -4
deleted file mode 100644
index f770dd0c9..000000000

Lines of this file are not shown. View the raw message.

utils/ffsb-6.0-rc2/rand.c deleted +0 -188

188 lines not on this page · raw message

utils/ffsb-6.0-rc2/rand.h deleted +0 -60

60 lines not on this page · raw message

utils/ffsb-6.0-rc2/rbt.c deleted +0 -1063

1,063 lines not on this page · raw message

utils/ffsb-6.0-rc2/rbt.h deleted +0 -316

316 lines not on this page · raw message

utils/ffsb-6.0-rc2/registration-description deleted +0 -7
deleted file mode 100644
index 9faaea2ae..000000000

Lines of this file are not shown. View the raw message.

utils/ffsb-6.0-rc2/rwlock.c deleted +0 -108

108 lines not on this page · raw message

utils/ffsb-6.0-rc2/rwlock.h deleted +0 -51

51 lines not on this page · raw message

utils/ffsb-6.0-rc2/stamp-h.in deleted +0 -1
deleted file mode 100644
index 9788f7023..000000000

Lines of this file are not shown. View the raw message.

utils/ffsb-6.0-rc2/util.c deleted +0 -345

345 lines not on this page · raw message

utils/ffsb-6.0-rc2/util.h deleted +0 -94

94 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.23.0

Part of the diff is not shown here. View the raw message.

#1 lore raw

RFC PATCH 1/1 Delete New ext4 features tests and ffsb tool

Hi!

Quoted 11 lines

The main reason is that these tests [1] (contributed in 2009) are mostly outdated and irrelevant. According to Theodore Y. Tso [2] and Jan Kara [3] the only partly valid tests are ext4_nsec_timestamps_test.sh and ext4_subdir_limit_test.sh, but even these would be better to migrate to xfstests, which Yong Sun is planning to do.

Also, some of the tests weren't in any runtest file anyway (ext4-alloc-test.sh, ext4_inode_version_test.sh, ext4_journal_checksum.sh, ext4_online_defrag_test.sh)

Quoted 7 lines

ffsb tool was used only in these New ext4 features tests.

[1] http://ext4.wiki.kernel.org/index.php/New_ext4_features
[2] https://marc.info/?l=linux-fsdevel&m=157187153211649&w=2
[3] https://marc.info/?l=linux-ext4&m=157190318618555&w=2

Closes #560

Acked.

The ffsb adds quite a bit of complexity to the LTP build with a very little added value. As far as the meaningful parts of the ext4 suite would be migrated to xfstests everyone should be happy about this.

Signature · 2 lines
Cyril Hrubis
[email protected]
author
#2 lore raw

RFC PATCH 1/1 Delete New ext4 features tests and ffsb tool

Hi Cyril,

Quoted 18 lines

Hi!

Quoted 16 lines

The main reason is that these tests [1] (contributed in 2009) are mostly outdated and irrelevant. According to Theodore Y. Tso [2] and Jan Kara [3] the only partly valid tests are ext4_nsec_timestamps_test.sh and ext4_subdir_limit_test.sh, but even these would be better to migrate to xfstests, which Yong Sun is planning to do.

Also, some of the tests weren't in any runtest file anyway (ext4-alloc-test.sh, ext4_inode_version_test.sh, ext4_journal_checksum.sh, ext4_online_defrag_test.sh)

ffsb tool was used only in these New ext4 features tests.

[1] http://ext4.wiki.kernel.org/index.php/New_ext4_features
[2] https://marc.info/?l=linux-fsdevel&m=157187153211649&w=2
[3] https://marc.info/?l=linux-ext4&m=157190318618555&w=2

Quoted 7 lines
Quoted 1 line
Closes #560

Acked.

The ffsb adds quite a bit of complexity to the LTP build with a very little added value. As far as the meaningful parts of the ext4 suite would be migrated to xfstests everyone should be happy about this.

Thanks for ack, merged.

Kind regards,
Petr