Skip to contentSkip to conversation

CONTRIBUTING: drop reference to blktap2

PATCH In review Wei Liu 4 participants 6 messages Oct 24, 2019

lore
Share & tools
lore

Wei Liu

author
#0 lore raw

PATCH 1/1 CONTRIBUTING: drop reference to blktap2

Blktap2 is gone.

---
 CONTRIBUTING | 1 -
 1 file changed, 1 deletion(-)
CONTRIBUTING +0 -1
index 47f53e9a49..4fff4fd9f6 100644
@@ -13,7 +13,6 @@ Most of the Xen Project code is licensed under GPLv2, but a number of
 directories are primarily licensed under different licenses.
 
 Most notably:
- - tools/blktap2      : BSD-Modified
  - tools/libxc        : LGPL v2.1
  - tools/libxl        : LGPL v2.1
  - tools/xl           : LGPL v2.1
Signature · 7 lines
2.20.1


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 13 lines · Wei Liu

Blktap2 is gone.

---
  CONTRIBUTING | 1 -
  1 file changed, 1 deletion(-)
CONTRIBUTING +0 -0
index 47f53e9a49..4fff4fd9f6 100644

CONTRIBUTING Most of the Xen Project code is licensed under GPLv2, but a number of · line 18

Quoted 7 lines
CONTRIBUTING +0 -1
@@ -13,7 +13,6 @@ Most of the Xen Project code is licensed under GPLv2, but a number of
  directories are primarily licensed under different licenses.
 
  Most notably:
- - tools/blktap2      : BSD-Modified
   - tools/libxc        : LGPL v2.1
   - tools/libxl        : LGPL v2.1
   - tools/xl           : LGPL v2.1

Mind adding tools/libs instead?

With that:

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

author
#2 lore raw
Quoted 8 lines · Jürgen Groß
Quoted 7 lines · Wei Liu

Blktap2 is gone.

---
  CONTRIBUTING | 1 -
  1 file changed, 1 deletion(-)
Quoted 14 lines

CONTRIBUTING Most of the Xen Project code is licensed under GPLv2, but a number of · line 18

Quoted 12 lines
CONTRIBUTING +0 -1
index 47f53e9a49..4fff4fd9f6 100644
@@ -13,7 +13,6 @@ Most of the Xen Project code is licensed under GPLv2, but a number of
  directories are primarily licensed under different licenses.
  Most notably:
- - tools/blktap2      : BSD-Modified
   - tools/libxc        : LGPL v2.1
   - tools/libxl        : LGPL v2.1
   - tools/xl           : LGPL v2.1
 

Mind adding tools/libs instead?

Sure. That can be done.

Because tools/libs' code is mostly split from libxc and friends, I assume it is going to be LGPL v2.1 as well.

Lars and Ian, your opinion?

Wei.

Quoted 7 lines

With that:

Quoted 6 lines

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw

On 24/10/2019, 12:22, "Wei Liu" <[email protected]> wrote:

On Thu, Oct 24, 2019 at 01:13:13PM +0200, Jürgen Groß wrote:
> On 24.10.19 13:06, Wei Liu wrote:
> > Blktap2 is gone.
> >
> > Signed-off-by: Wei Liu <[email protected]>
> > ---
> > CONTRIBUTING | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/CONTRIBUTING b/CONTRIBUTING
> > index 47f53e9a49..4fff4fd9f6 100644
> > --- a/CONTRIBUTING
> > +++ b/CONTRIBUTING
> > @@ -13,7 +13,6 @@ Most of the Xen Project code is licensed under GPLv2, but a number of
> > directories are primarily licensed under different licenses.
> > Most notably:
> > - - tools/blktap2 : BSD-Modified
> > - tools/libxc : LGPL v2.1
> > - tools/libxl : LGPL v2.1
> > - tools/xl : LGPL v2.1
> >
>
> Mind adding tools/libs instead?

Sure. That can be done.

Because tools/libs' code is mostly split from libxc and friends, I assume it is going to be LGPL v2.1 as well.

Lars and Ian, your opinion?

Tools/libs does not have a COPYING file, so it is GPL by default. However, all the files I checked appear to have LGPL v2.1 So, the directory should probably have an appropriate COPYING file, but we do need to check all files in it

Regards
Lars

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw
Quoted 30 lines · Lars Kurth

On 24/10/2019, 12:22, "Wei Liu" <[email protected]> wrote:

On Thu, Oct 24, 2019 at 01:13:13PM +0200, Jürgen Groß wrote:
> On 24.10.19 13:06, Wei Liu wrote:
> > Blktap2 is gone.
> >
> > Signed-off-by: Wei Liu <[email protected]>
> > ---
> > CONTRIBUTING | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/CONTRIBUTING b/CONTRIBUTING
> > index 47f53e9a49..4fff4fd9f6 100644
> > --- a/CONTRIBUTING
> > +++ b/CONTRIBUTING
> > @@ -13,7 +13,6 @@ Most of the Xen Project code is licensed under GPLv2, but a number of
> > directories are primarily licensed under different licenses.
> > Most notably:
> > - - tools/blktap2 : BSD-Modified
> > - tools/libxc : LGPL v2.1
> > - tools/libxl : LGPL v2.1
> > - tools/xl : LGPL v2.1
> >
>
> Mind adding tools/libs instead?

Sure. That can be done.

Quoted 7 lines

Because tools/libs' code is mostly split from libxc and friends, I assume it is going to be LGPL v2.1 as well.

Lars and Ian, your opinion?

Tools/libs does not have a COPYING file, so it is GPL by default. However, all the files I checked appear to have LGPL v2.1 So, the directory should probably have an appropriate COPYING file, but we do need to check all files in it

tools/libs/*/private.h have no license remark, all other *.c and *.h are LGPL 2.1.

Juergen

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#5 lore raw
In reply to Wei Liu

Wei Liu writes ("Re: [Xen-devel] [PATCH for-4.13] CONTRIBUTING: drop reference to blktap2"):

Quoted 9 lines · Jürgen Groß
Quoted 1 line

Mind adding tools/libs instead?

Sure. That can be done.

Because tools/libs' code is mostly split from libxc and friends, I assume it is going to be LGPL v2.1 as well.

Lars and Ian, your opinion?

Err, this is surely a mechanical question ? Ie, what licence are these files in already.

I did
git-grep -i -l copyright | xargs git-grep -L 'GNU Lesser General'
in tools/libs and there were no hits.

So I think the answer is indeed LGPL.

Ian.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel