Skip to contentSkip to conversation

btrfs: Remove btrfs_bio::flags member

PATCH In review Qu Wenruo 2 participants 2 messages Oct 24, 2019 Btrfs file system

lore
Share & tools
lore

Qu Wenruo

author
#0 lore raw

PATCH v2 1/1 btrfs: Remove btrfs_bio::flags member

This member is not used by any one, just remove it.

And since it's between two pointers, such removal should save us a pointer size of the structure.

The last user of btrfs_bio::flags is removed in commit 326e1dbb5736 ("block: remove management of bi_remaining when restoring original bi_end_io").

---
Changelog:
v2:
- Mention the when last user of btrfs_bio::flags is removed.
- Don't mention btrfs_bio::map_type in commit message. Since btrfs_bio::flags is for another purpose, it has nothing to do with btrfs_bio::map_type.

---
 fs/btrfs/volumes.h | 1 -
 1 file changed, 1 deletion(-)
fs/btrfs/volumes.h +0 -1
index a7da1f3e3627..5acf5c507ec2 100644
@@ -330,7 +330,6 @@ struct btrfs_bio {
 	u64 map_type; /* get from map_lookup->type */
 	bio_end_io_t *end_io;
 	struct bio *orig_bio;
-	unsigned long flags;
 	void *private;
 	atomic_t error;
 	int max_errors;
Signature · 1 line
2.23.0
#1 lore raw
Quoted 8 lines · Qu Wenruo

This member is not used by any one, just remove it.

And since it's between two pointers, such removal should save us a pointer size of the structure.

The last user of btrfs_bio::flags is removed in commit 326e1dbb5736 ("block: remove management of bi_remaining when restoring original bi_end_io").

Oh, that's an old patch, 2015. I'll add a stable tag though it's not a fix but the size reduction of a frequently used structure is a good thing. Thanks.