Skip to contentSkip to conversation

drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

PATCH In review [email protected] 4 participants 10 messages Oct 24, 2019 – Oct 28, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

From: Don Hiatt <[email protected]>

Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action.

On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of ability to enter RC6. Guard against this by only requesting the GuC action on platforms that support GuC submission.

I've verfied that intel_guc_resume() only gets called when driver is loaded with: guc_enable={1,2,3}, all other cases (no args, guc_enable={0,-1} the intel_guc_resume() is not called.

---
 drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/uc/intel_guc.c +4 -1
index 37f7bcbf7dac..33318ed135c0 100644
@@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
 		GUC_POWER_D0,
 	};
 
-	return intel_guc_send(guc, action, ARRAY_SIZE(action));
+	if (guc->submission_supported)
+		return intel_guc_send(guc, action, ARRAY_SIZE(action));
+
+	return 0;
 }
 
 /**
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 26 lines · On Thu, 2019-10-24 at 09:29 -0700, [email protected] wrote:

From: Don Hiatt <[email protected]>

Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action.

On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of ability to enter RC6. Guard against this by only requesting the GuC action on platforms that support GuC submission.

I've verfied that intel_guc_resume() only gets called when driver is loaded with: guc_enable={1,2,3}, all other cases (no args, guc_enable={0,-1} the intel_guc_resume() is not called.

---
 drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/uc/intel_guc.c +0 -0
index 37f7bcbf7dac..33318ed135c0 100644

drivers/gpu/drm/i915/gt/uc/intel_guc.c int intel_guc_resume(struct intel_guc *guc) · line 568

Quoted 5 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +1 -1
@@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
 		GUC_POWER_D0,
 	};
 
-	return intel_guc_send(guc, action, ARRAY_SIZE(action));
+	if (guc->submission_supported)

Hey Don,

I might be missing something here, but glancing over the code for submission_supported, it looks like this relies on the availability of the firmware for the intended platform. Looking at the GuC table for KBL, I do see this present (using KBL per your commit above). So wouldn't this return true here if enable_guc is set to 1 or 3?

Thanks,
Stuart

drivers/gpu/drm/i915/gt/uc/intel_guc.c int intel_guc_resume(struct intel_guc *guc) · line 574

Quoted 6 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +3 -0
+		return intel_guc_send(guc, action, ARRAY_SIZE(action));
+
+	return 0;
 }
 
 /**

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#2 lore raw
Quoted 35 lines · On Thu, 2019-10-24 at 09:29 -0700, [email protected] wrote:
Quoted 26 lines

From: Don Hiatt <[email protected]>

Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action.

On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of ability to enter RC6. Guard against this by only requesting the GuC action on platforms that support GuC submission.

I've verfied that intel_guc_resume() only gets called when driver is loaded with: guc_enable={1,2,3}, all other cases (no args, guc_enable={0,-1} the intel_guc_resume() is not called.

---
 drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/uc/intel_guc.c +0 -0
index 37f7bcbf7dac..33318ed135c0 100644

drivers/gpu/drm/i915/gt/uc/intel_guc.c int intel_guc_resume(struct intel_guc *guc) · line 568

Quoted 5 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +1 -1
@@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
 		GUC_POWER_D0,
 	};
 
-	return intel_guc_send(guc, action, ARRAY_SIZE(action));
+	if (guc->submission_supported)

Hey Don,

Quoted 8 lines

I might be missing something here, but glancing over the code for submission_supported, it looks like this relies on the availability of the firmware for the intended platform. Looking at the GuC table for KBL, I do see this present (using KBL per your commit above). So wouldn't this return true here if enable_guc is set to 1 or 3?

Thanks,
Stuart

Hi Stuart,

KBL does not support GuC submission, just HuC authentication. I've instrumented the code and verified that all guc->submission_supported is always false when guc_enable is set for KBL.

Thanks,

don

Quoted 7 lines

drivers/gpu/drm/i915/gt/uc/intel_guc.c int intel_guc_resume(struct intel_guc *guc) · line 574

Quoted 7 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +3 -0
+		return intel_guc_send(guc, action, ARRAY_SIZE(action));
+
+	return 0;
 }
 
 /**

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✓ Fi.CI.BAT: success for drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
URL : https://patchwork.freedesktop.org/series/68526/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7175 -> Patchwork_14971
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/index.html

Known issues
------------

Here are the changes found in Patchwork_14971 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][1] -> [DMESG-WARN][2] ([fdo#102614])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-hsw-peppy/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-hsw-peppy/igt@[email protected]

* igt@prime_vgem@basic-wait-default:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-icl-u3/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-icl-u3/igt@[email protected]

#### Possible fixes ####

* igt@gem_basic@create-close:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-icl-u3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-icl-u3/igt@[email protected]

* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8109u: [DMESG-FAIL][7] ([fdo#112050 ]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html

* igt@kms_busy@basic-flip-a:
- {fi-tgl-u2}: [DMESG-WARN][9] ([fdo#111600]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-tgl-u2/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-tgl-u2/igt@[email protected]

* igt@kms_chamelium@dp-edid-read:
- fi-kbl-7500u: [WARN][11] ([fdo#109483]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-kbl-7500u/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-kbl-7500u/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][13] ([fdo#111407]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-kbl-7500u/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-kbl-7500u/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111831]: https://bugs.freedesktop.org/show_bug.cgi?id=111831
[fdo#112050 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112050

Participating hosts (51 -> 43)
------------------------------

Additional (1): fi-tgl-u
Missing (9): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-icl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7175 -> Patchwork_14971

CI-20190529: 20190529
CI_DRM_7175: 29ffd6b6aac24cdf361aa11a5a18e2ebc95b3180 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5237: 9a46404de7c42c8cc2d492176e956597ef28d7c4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14971: ec048a07dfe678ac7728c210ed859f9c08a19efc @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

ec048a07dfe6 drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

✗ Fi.CI.IGT: failure for drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

In reply to [email protected]
== Series Details ==

== Series Details ==

Series: drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
URL : https://patchwork.freedesktop.org/series/68526/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7175_full -> Patchwork_14971_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_14971_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_14971_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_14971_full:

### IGT changes ###

#### Possible regressions ####

* igt@runner@aborted:
- shard-kbl: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_14971_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][2] -> [SKIP][3] ([fdo#112080]) +12 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb1/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@[email protected]

* igt@gem_ctx_isolation@vcs1-dirty-switch:
- shard-iclb: [PASS][4] -> [SKIP][5] ([fdo#109276] / [fdo#112080])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb1/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@[email protected]

* igt@gem_exec_reuse@contexts:
- shard-kbl: [PASS][6] -> [DMESG-WARN][7] ([fdo#105604] / [fdo#105763])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl2/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#111325]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb5/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@[email protected]

* igt@gem_exec_suspend@basic-s3:
- shard-snb: [PASS][10] -> [DMESG-WARN][11] ([fdo#102365])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb7/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb1/igt@[email protected]
- shard-skl: [PASS][12] -> [INCOMPLETE][13] ([fdo#104108])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl6/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl7/igt@[email protected]

* igt@gem_linear_blits@normal:
- shard-apl: [PASS][14] -> [INCOMPLETE][15] ([fdo#103927])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl6/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl1/igt@[email protected]

* igt@gem_mmap_gtt@hang:
- shard-snb: [PASS][16] -> [INCOMPLETE][17] ([fdo#105411])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb5/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb7/igt@[email protected]

* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-kbl: [PASS][18] -> [TIMEOUT][19] ([fdo#112068 ])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl7/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][20] -> [DMESG-WARN][21] ([fdo#111870])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw8/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw5/igt@[email protected]

* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-snb: [PASS][22] -> [DMESG-WARN][23] ([fdo#111870])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb4/igt@[email protected]

* igt@i915_selftest@live_hangcheck:
- shard-hsw: [PASS][24] -> [DMESG-FAIL][25] ([fdo#111991])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw1/igt@i915_selftest@live_hangcheck.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw1/igt@i915_selftest@live_hangcheck.html

* igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing:
- shard-hsw: [PASS][26] -> [INCOMPLETE][27] ([fdo#103540])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw1/igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw4/igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing.html

* igt@kms_color@pipe-c-ctm-max:
- shard-skl: [PASS][28] -> [FAIL][29] ([fdo#108147])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl5/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-64x21-random:
- shard-skl: [PASS][30] -> [FAIL][31] ([fdo#103232])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl6/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl8/igt@[email protected]

* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][32] -> [FAIL][33] ([fdo#105363])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl1/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl7/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][34] -> [DMESG-WARN][35] ([fdo#108566]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl2/igt@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: [PASS][36] -> [FAIL][37] ([fdo#103167]) +4 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb4/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb3/igt@[email protected]

* igt@kms_lease@page_flip_implicit_plane:
- shard-iclb: [PASS][38] -> [INCOMPLETE][39] ([fdo#107713])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb5/igt@kms_lease@page_flip_implicit_plane.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb7/igt@kms_lease@page_flip_implicit_plane.html

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][40] -> [DMESG-WARN][41] ([fdo#108566]) +4 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl1/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl1/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][42] -> [FAIL][43] ([fdo#108145]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl3/igt@[email protected]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl9/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][44] -> [FAIL][45] ([fdo#108145] / [fdo#110403])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl5/igt@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl6/igt@[email protected]

* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][46] -> [SKIP][47] ([fdo#109642] / [fdo#111068])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@[email protected]

* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][48] -> [SKIP][49] ([fdo#109441]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@kms_psr@psr2_basic.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb1/igt@kms_psr@psr2_basic.html

* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][50] -> [SKIP][51] ([fdo#109276]) +12 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@[email protected]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][52] ([fdo#108566]) -> [PASS][53] +6 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl4/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl6/igt@[email protected]

* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][54] ([fdo#109276] / [fdo#112080]) -> [PASS][55] +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb8/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@[email protected]

* igt@gem_ctx_switch@vcs1-heavy-queue:
- shard-iclb: [SKIP][56] ([fdo#112080]) -> [PASS][57] +8 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb8/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@[email protected]

* igt@gem_eio@reset-stress:
- shard-snb: [FAIL][58] ([fdo#109661]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb4/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb5/igt@[email protected]

* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][60] ([fdo#110854]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb3/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb1/igt@[email protected]

* igt@gem_exec_schedule@deep-render:
- shard-apl: [INCOMPLETE][62] ([fdo#103927]) -> [PASS][63] +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl6/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl1/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][64] ([fdo#109276]) -> [PASS][65] +15 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb8/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@[email protected]

* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][66] ([fdo#111325]) -> [PASS][67] +5 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb4/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb5/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- {shard-tglb}: [TIMEOUT][68] ([fdo#112068 ]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb3/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb3/igt@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][70] ([fdo#104108]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl4/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl8/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [DMESG-WARN][72] ([fdo#111870]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw7/igt@[email protected]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw6/igt@[email protected]
- shard-snb: [DMESG-WARN][74] ([fdo#111870]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb7/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb1/igt@[email protected]

* {igt@i915_pm_dc@dc6-psr}:
- shard-iclb: [FAIL][76] ([fdo#110548]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb6/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb8/igt@[email protected]

* igt@i915_pm_rpm@universal-planes:
- shard-kbl: [DMESG-WARN][78] ([fdo#103313]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl2/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@[email protected]

* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [DMESG-WARN][80] ([fdo#106107]) -> [PASS][81] +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl3/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl9/igt@[email protected]

* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled:
- {shard-tglb}: [INCOMPLETE][82] ([fdo#111747]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb4/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb3/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-skl: [INCOMPLETE][84] ([fdo#109507]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl8/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- {shard-tglb}: [FAIL][86] ([fdo#103167]) -> [PASS][87] +3 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb8/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- {shard-tglb}: [INCOMPLETE][88] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb7/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- {shard-tglb}: [INCOMPLETE][90] ([fdo#111884]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][92] ([fdo#103167]) -> [PASS][93] +7 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html

* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: [FAIL][94] ([fdo#103167] / [fdo#110378]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][96] ([fdo#108145]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl1/igt@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl2/igt@[email protected]

* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][98] ([fdo#108341]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb1/igt@kms_psr@no_drrs.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@kms_psr@no_drrs.html

* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][100] ([fdo#109441]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html

* igt@kms_rotation_crc@primary-x-tiled-reflect-x-0:
- shard-iclb: [INCOMPLETE][102] ([fdo#107713] / [fdo#110026]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb7/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb7/igt@[email protected]

* igt@kms_setmode@basic:
- shard-apl: [FAIL][104] ([fdo#99912]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl3/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl2/igt@[email protected]

#### Warnings ####

* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][106] ([fdo#109276] / [fdo#112080]) -> [FAIL][107] ([fdo#111329])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb3/igt@gem_ctx_isolation@vcs1

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
In reply to [email protected]
Quoted 5 lines · On 10/24/19 9:29 AM, [email protected] wrote:

From: Don Hiatt <[email protected]>

Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action.

You're only skipping the resume, but does it make any sense to do the suspend action if we're not going to call the resume one? Does guc do anything in the suspend action that we still require? I thought it only saved the submission status, which we don't care about if guc submission is disabled.

Daniele

Quoted 22 lines

On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of ability to enter RC6. Guard against this by only requesting the GuC action on platforms that support GuC submission.

I've verfied that intel_guc_resume() only gets called when driver is loaded with: guc_enable={1,2,3}, all other cases (no args, guc_enable={0,-1} the intel_guc_resume() is not called.

---
  drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/uc/intel_guc.c +0 -0
index 37f7bcbf7dac..33318ed135c0 100644
@@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
  		GUC_POWER_D0,

drivers/gpu/drm/i915/gt/uc/intel_guc.c int intel_guc_resume(struct intel_guc *guc) · line 574

Quoted 10 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +4 -1
  	};
 
-	return intel_guc_send(guc, action, ARRAY_SIZE(action));
+	if (guc->submission_supported)
+		return intel_guc_send(guc, action, ARRAY_SIZE(action));
+
+	return 0;
  }
 
  /**

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#6 lore raw
Quoted 15 lines

From: Ceraolo Spurio, Daniele <[email protected]>
Sent: Monday, October 28, 2019 9:44 AM
To: Hiatt, Don <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

Quoted 5 lines · On 10/24/19 9:29 AM, [email protected] wrote:

From: Don Hiatt <[email protected]>

Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action.

Quoted 8 lines

You're only skipping the resume, but does it make any sense to do the suspend action if we're not going to call the resume one? Does guc do anything in the suspend action that we still require? I thought it only saved the submission status, which we don't care about if guc submission is disabled.

Daniele

Hi Daniele,

I tried skipping the suspend all together but then the HuC gets timeouts waiting for the GuC to acknowledge the authentication request which leads to a wedged GPU. ☹

BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that up.

Thanks,

don

Quoted 31 lines
Quoted 10 lines

On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of ability to enter RC6. Guard against this by only requesting the GuC action on platforms that support GuC submission.

I've verfied that intel_guc_resume() only gets called when driver is loaded with: guc_enable={1,2,3}, all other cases (no args, guc_enable={0,-1} the intel_guc_resume() is not called.

Review

Quoted 6 lines
---
  drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/gt/uc/intel_guc.c

Quoted 14 lines

index 37f7bcbf7dac..33318ed135c0 100644

drivers/gpu/drm/i915/gt/uc/intel_guc.c +4 -1
@@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
  		GUC_POWER_D0,
  	};
 
-	return intel_guc_send(guc, action, ARRAY_SIZE(action));
+	if (guc->submission_supported)
+		return intel_guc_send(guc, action, ARRAY_SIZE(action));
+
+	return 0;
  }
 
Quoted 2 lines

drivers/gpu/drm/i915/gt/uc/intel_guc.c int intel_guc_resume(struct intel_guc *guc) · line 574

Quoted 2 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +0 -0
  /**

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw
Quoted 21 lines · Don
Quoted 21 lines

From: Ceraolo Spurio, Daniele <[email protected]>
Sent: Monday, October 28, 2019 9:44 AM
To: Hiatt, Don <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

Quoted 5 lines · On 10/24/19 9:29 AM, [email protected] wrote:

From: Don Hiatt <[email protected]>

Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action.

You're only skipping the resume, but does it make any sense to do the suspend action if we're not going to call the resume one? Does guc do anything in the suspend action that we still require? I thought it only saved the submission status, which we don't care about if guc submission is disabled.

Quoted 9 lines
Quoted 2 lines

Daniele

Hi Daniele,

I tried skipping the suspend all together but then the HuC gets timeouts waiting for the GuC to acknowledge the authentication request which leads to a wedged GPU. ☹

Do we know why? if we skip the suspend/resume H2G and reload the blobs after resetting the HW it should look like a clean boot from the HW perspective, so the fact that HuC auth times out feels weird and might hide other issues. I asked one of the guc devs and he also thinks this is not expected behavior. Can you dig a bit more?

Thanks,
Daniele

Quoted 39 lines

BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that up.

Thanks,

don

Quoted 31 lines
Quoted 10 lines

On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of ability to enter RC6. Guard against this by only requesting the GuC action on platforms that support GuC submission.

I've verfied that intel_guc_resume() only gets called when driver is loaded with: guc_enable={1,2,3}, all other cases (no args, guc_enable={0,-1} the intel_guc_resume() is not called.

Review

Quoted 6 lines
---
   drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
   1 file changed, 4 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/gt/uc/intel_guc.c

Quoted 14 lines

index 37f7bcbf7dac..33318ed135c0 100644

drivers/gpu/drm/i915/gt/uc/intel_guc.c +4 -1
@@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
   		GUC_POWER_D0,
   	};
 
-	return intel_guc_send(guc, action, ARRAY_SIZE(action));
+	if (guc->submission_supported)
+		return intel_guc_send(guc, action, ARRAY_SIZE(action));
+
+	return 0;
   }
 
Quoted 2 lines
Quoted 2 lines

drivers/gpu/drm/i915/gt/uc/intel_guc.c int intel_guc_resume(struct intel_guc *guc) · line 574

Quoted 2 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +0 -0
   /**

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#8 lore raw
Quoted 44 lines

From: Ceraolo Spurio, Daniele <[email protected]>
Sent: Monday, October 28, 2019 11:30 AM
To: Hiatt, Don <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled

Quoted 4 lines · Don
Quoted 4 lines

From: Ceraolo Spurio, Daniele <[email protected]>
Sent: Monday, October 28, 2019 9:44 AM
To: Hiatt, Don <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o

GuC

Quoted 17 lines
Quoted 17 lines

submission but enabled

Quoted 5 lines · On 10/24/19 9:29 AM, [email protected] wrote:

From: Don Hiatt <[email protected]>

Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action.

You're only skipping the resume, but does it make any sense to do the suspend action if we're not going to call the resume one? Does guc do anything in the suspend action that we still require? I thought it only saved the submission status, which we don't care about if guc submission is disabled.

Quoted 7 lines
Quoted 2 lines

Daniele

Hi Daniele,

I tried skipping the suspend all together but then the HuC gets timeouts waiting for the GuC to acknowledge the authentication request which leads to

a

Quoted 2 lines

wedged GPU. ☹

Quoted 9 lines

Do we know why? if we skip the suspend/resume H2G and reload the blobs after resetting the HW it should look like a clean boot from the HW perspective, so the fact that HuC auth times out feels weird and might hide other issues. I asked one of the guc devs and he also thinks this is not expected behavior. Can you dig a bit more?

Thanks,
Daniele

No idea why but I'll do some digging and see what I find.

Thanks!

don

Quoted 39 lines
Quoted 39 lines

BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that up.

Thanks,

don

Quoted 31 lines
Quoted 10 lines

On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of ability to enter RC6. Guard against this by only requesting the GuC action on platforms that support GuC submission.

I've verfied that intel_guc_resume() only gets called when driver is loaded with: guc_enable={1,2,3}, all other cases (no args, guc_enable={0,-1} the intel_guc_resume() is not called.

Review

Quoted 6 lines
---
   drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
   1 file changed, 4 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/gt/uc/intel_guc.c

Quoted 14 lines

index 37f7bcbf7dac..33318ed135c0 100644

drivers/gpu/drm/i915/gt/uc/intel_guc.c +4 -1
@@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
   		GUC_POWER_D0,
   	};
 
-	return intel_guc_send(guc, action, ARRAY_SIZE(action));
+	if (guc->submission_supported)
+		return intel_guc_send(guc, action, ARRAY_SIZE(action));
+
+	return 0;
   }
 
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers/gpu/drm/i915/gt/uc/intel_guc.c int intel_guc_resume(struct intel_guc *guc) · line 574

Quoted 2 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +0 -0
   /**

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

author
#9 lore raw
Quoted 56 lines
Quoted 6 lines

From: Ceraolo Spurio, Daniele <[email protected]>
Sent: Monday, October 28, 2019 11:30 AM
To: Hiatt, Don <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o

GuC

Quoted 4 lines

submission but enabled

Quoted 30 lines
Quoted 4 lines · Don
Quoted 4 lines

From: Ceraolo Spurio, Daniele <[email protected]>
Sent: Monday, October 28, 2019 9:44 AM
To: Hiatt, Don <[email protected]>; [email protected]
Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o

GuC

Quoted 24 lines
Quoted 11 lines

submission but enabled

Quoted 5 lines · On 10/24/19 9:29 AM, [email protected] wrote:

From: Don Hiatt <[email protected]>

Check to see if GuC submission is enabled before requesting the EXIT_S_STATE action.

Quoted 8 lines

You're only skipping the resume, but does it make any sense to do the suspend action if we're not going to call the resume one? Does guc do anything in the suspend action that we still require? I thought it only saved the submission status, which we don't care about if guc submission is disabled.

Daniele

Hi Daniele,

I tried skipping the suspend all together but then the HuC gets timeouts waiting for the GuC to acknowledge the authentication request which leads

to

Quoted 4 lines

a

Quoted 2 lines

wedged GPU. ☹

Quoted 9 lines

Do we know why? if we skip the suspend/resume H2G and reload the blobs after resetting the HW it should look like a clean boot from the HW perspective, so the fact that HuC auth times out feels weird and might hide other issues. I asked one of the guc devs and he also thinks this is not expected behavior. Can you dig a bit more?

Thanks,
Daniele

Quoted 6 lines

No idea why but I'll do some digging and see what I find.

Thanks!

don

Hi Daniele,

I was a little overzealous on my removal of suspend/resume. We still need to go through the steps of enable/disable GuC communication on suspend/resume but just not send the GuC action. My first attempt was not handling the GuC communication properly so that is why I was seeing the HuC authentication timesouts.

I'm submitting new patch -- with the proper 'drm/i915' -- and will CC you.

Thanks!

don

Quoted 39 lines
Quoted 39 lines
Quoted 39 lines

BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that up.

Thanks,

don

Quoted 31 lines
Quoted 10 lines

On some platforms (e.g. KBL) that do not support GuC submission, but the user enabled the GuC communication (e.g for HuC authentication) calling the GuC EXIT_S_STATE action results in lose of ability to enter RC6. Guard against this by only requesting the GuC action on platforms that support GuC submission.

I've verfied that intel_guc_resume() only gets called when driver is loaded with: guc_enable={1,2,3}, all other cases (no args, guc_enable={0,-1} the intel_guc_resume() is not called.

Review

Quoted 6 lines
---
   drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
   1 file changed, 4 insertions(+), 1 deletion(-)
(quoted diff) +0 -0

b/drivers/gpu/drm/i915/gt/uc/intel_guc.c

Quoted 14 lines

index 37f7bcbf7dac..33318ed135c0 100644

drivers/gpu/drm/i915/gt/uc/intel_guc.c +4 -1
@@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
   		GUC_POWER_D0,
   	};
 
-	return intel_guc_send(guc, action, ARRAY_SIZE(action));
+	if (guc->submission_supported)
+		return intel_guc_send(guc, action, ARRAY_SIZE(action));
+
+	return 0;
   }
 
Quoted 6 lines
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines

drivers/gpu/drm/i915/gt/uc/intel_guc.c int intel_guc_resume(struct intel_guc *guc) · line 574

Quoted 2 lines
drivers/gpu/drm/i915/gt/uc/intel_guc.c +0 -0
   /**

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx