Skip to contentSkip to conversation

package/libnetconf2: fixup the 'v' prefix in the version

PATCH Superseded Fabrice Fontaine 3 participants 5 messages Oct 24, 2019 – Oct 25, 2019

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/libnetconf2: fixup the 'v' prefix in the version

In order for the luvi version to match what is given by release-monitoring.org, the 'v' prefix should be encoded in LIBNETCONF2_SITE and not LIBNETCONF2_VERSION.

---
 package/libnetconf2/libnetconf2.hash | 2 +-
 package/libnetconf2/libnetconf2.mk   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
package/libnetconf2/libnetconf2.hash +1 -1
index c6d1f5185d..9b78049ffb 100644
@@ -1,2 +1,2 @@
-sha256 760061fb1c1fe87a2a068d5a9e5affcef280044c5940ef344854e9ea7ec26452  libnetconf2-v0.12-r2.tar.gz
+sha256 760061fb1c1fe87a2a068d5a9e5affcef280044c5940ef344854e9ea7ec26452  libnetconf2-0.12-r2.tar.gz
 sha256 085122ea91161812dda9cd2f42d8c50ecc3a48cc1a4f15044d86cfc5aa887577  LICENSE
package/libnetconf2/libnetconf2.mk +2 -2
index c3999b3e29..49a6de60a9 100644
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-LIBNETCONF2_VERSION = v0.12-r2
-LIBNETCONF2_SITE = $(call github,CESNET,libnetconf2,$(LIBNETCONF2_VERSION))
+LIBNETCONF2_VERSION = 0.12-r2
+LIBNETCONF2_SITE = $(call github,CESNET,libnetconf2,v$(LIBNETCONF2_VERSION))
 LIBNETCONF2_INSTALL_STAGING = YES
 LIBNETCONF2_LICENSE = BSD-3-Clause
 LIBNETCONF2_LICENSE_FILES = LICENSE
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/libnetconf2: fixup the 'v' prefix in the version

Quoted 5 lines · On Thu, 24 Oct 2019 20:06:53 +0200 Fabrice Fontaine…

In order for the luvi version to match what is given by release-monitoring.org, the 'v' prefix should be encoded in LIBNETCONF2_SITE and not LIBNETCONF2_VERSION.

Sorry for missing this when reviewing/applying those packages.

Perhaps it would make sense to add a check in the check-package logic, to verify that the version doesn't look like vX.Y.Z ?

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#2 lore raw

PATCH 1/1 package/libnetconf2: fixup the 'v' prefix in the version

Quoted 2 lines

Perhaps it would make sense to add a check in the check-package logic, to verify that the version doesn't look like vX.Y.Z ?

I would like to take care of that.

#3 lore raw

PATCH 1/1 package/libnetconf2: fixup the 'v' prefix in the version

Quoted 4 lines · On Fri, 25 Oct 2019 08:55:01 +0200 Heiko Thiery <[email protected]> wrote:
Quoted 2 lines

Perhaps it would make sense to add a check in the check-package logic, to verify that the version doesn't look like vX.Y.Z ?

I would like to take care of that.

Then you can poke around in utils/checkpackagelib/lib_mk.py and see to add another check. I'm not sure how the check should work exactly, but I'll let you figure that out :-)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#4 lore raw

PATCH 1/1 package/libnetconf2: fixup the 'v' prefix in the version

Dear all,

Le ven. 25 oct. 2019 ? 09:30, Thomas Petazzoni
<[email protected]> a ?crit :

Quoted 4 lines

On Fri, 25 Oct 2019 08:55:01 +0200
Heiko Thiery <[email protected]> wrote:

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Perhaps it would make sense to add a check in the check-package logic, to verify that the version doesn't look like vX.Y.Z ?

I would like to take care of that.

Then you can poke around in utils/checkpackagelib/lib_mk.py and see to add another check. I'm not sure how the check should work exactly, but I'll let you figure that out :-)

At very least, we should just check that there is no v prefix, this is the only requirement from release-monitoring: "Anitya will automatically strip this from versions it finds." (see
https://release-monitoring.org/static/docs/user-guide.html#creating-a-new-project).

release-monitoring doesn't require that the version is in the X.Y.Z form, X-Y-Z or X_Y_Z is allowed (and used in some packages).

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Best Regards,

Fabrice