drm/amdkfd: Delete duplicated queue bit map reservation
Subsystems (3)
PATCH 1/1 drm/amdkfd: Delete duplicated queue bit map reservation
The KIQ is on the second MEC and its reservation is covered in the latter logic, so no need to reserve its bit twice.
Change-Id Ieee390953a60c7d43de5a9aec38803f1f583a4a9
Signed-off-by Yong Zhao <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c +0 -8
@@ -130,14 +130,6 @@ void amdgpu_amdkfd_device_init(struct amdgpu_device *adev) adev->gfx.mec.queue_bitmap, KGD_MAX_QUEUES); -/* remove the KIQ bit as well */ -if (adev->gfx.kiq.ring.sched.ready) -clear_bit (amdgpu_gfx_mec_queue_to_bit (adev, - adev->gfx.kiq.ring.me -1 , - adev->gfx.kiq.ring.pipe, - adev->gfx.kiq.ring.queue), - gpu_resources.queue_bitmap); -/* According to linux/bitmap.h we shouldn't use bitmap_clear if * nbits is not compile time constant */
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): [email protected]
Kuehling, Felix
Reviewed-by Felix KuehlingQuoted 5 lines · Yong
The KIQ is on the second MEC and its reservation is covered in the latter logic, so no need to reserve its bit twice.
Change-Id Ieee390953a60c7d43de5a9aec38803f1f583a4a9Signed-off-by Yong Zhao <[email protected]>
Reviewed-by Felix Kuehling <[email protected]>
Quoted 13 lines
--- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c | 8 -------- 1 file changed, 8 deletions(-)drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c +0
-1@@ -130,14 +130,6 @@ void amdgpu_amdkfd_device_init(struct amdgpu_device *adev) adev->gfx.mec.queue_bitmap, KGD_MAX_QUEUES); -/* remove the KIQ bit as well */
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c void amdgpu_amdkfd_device_init(struct amdgpu_device *adev) · line 135
Quoted 10 lines
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c +0
-7-if (adev->gfx.kiq.ring.sched.ready) -clear_bit (amdgpu_gfx_mec_queue_to_bit (adev, - adev->gfx.kiq.ring.me -1 , - adev->gfx.kiq.ring.pipe, - adev->gfx.kiq.ring.queue), - gpu_resources.queue_bitmap); -/* According to linux/bitmap.h we shouldn't use bitmap_clear if * nbits is not compile time constant */
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx