Skip to contentSkip to conversation

package/lld: fix build with gcc < 5.1

PATCH New Joseph Kogut 3 participants 3 messages Oct 24, 2019 – Oct 25, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/lld: fix build with gcc < 5.1

This fix is based on commit 2a17fb6 used for llvm.

Fixes:
http://autobuild.buildroot.net/results/76310241a335a99a4ff2726edb517b067367fd41
http://autobuild.buildroot.net/results/88cbfae219fd4475be376c9558b5760cebd2148f

---
 package/lld/lld.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/lld/lld.mk +6 -0
index cd76c724ce..c284d6df7f 100644
@@ -13,6 +13,12 @@ LLD_LICENSE_FILES = LICENSE.TXT
 LLD_SUPPORTS_IN_SOURCE_BUILD = NO
 HOST_LLD_DEPENDENCIES = host-llvm
 
+# LLVM >= 9.0 will soon require C++14 support, building llvm 8.x using a
+# toolchain using gcc < 5.1 gives an error but actually still works. Setting
+# this option makes it still build with gcc >= 4.8.
+# https://reviews.llvm.org/D57264
+HOST_LLD_CONF_OPTS += -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON
+
 # GCC looks for tools in a different path from LLD's default installation path
 define HOST_LLD_CREATE_SYMLINKS
 	mkdir -p $(HOST_DIR)/$(GNU_TARGET_NAME)/bin
Signature · 1 line
2.23.0
#1 lore raw

PATCH 1/1 package/lld: fix build with gcc < 5.1

Hi Joseph,

Le 25/10/2019 ? 01:18, Joseph Kogut a ?crit?:

Quoted 15 lines

This fix is based on commit 2a17fb6 used for llvm.

Fixes:
http://autobuild.buildroot.net/results/76310241a335a99a4ff2726edb517b067367fd41
http://autobuild.buildroot.net/results/88cbfae219fd4475be376c9558b5760cebd2148f

---
 package/lld/lld.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/lld/lld.mk +0 -0
index cd76c724ce..c284d6df7f 100644

package/lld/lld.mk LLD_LICENSE_FILES = LICENSE.TXT · line 19

Quoted 7 lines
package/lld/lld.mk +4 -0
@@ -13,6 +13,12 @@ LLD_LICENSE_FILES = LICENSE.TXT
 LLD_SUPPORTS_IN_SOURCE_BUILD = NO
 HOST_LLD_DEPENDENCIES = host-llvm
 
+# LLVM >= 9.0 will soon require C++14 support, building llvm 8.x using a
+# toolchain using gcc < 5.1 gives an error but actually still works. Setting
+# this option makes it still build with gcc >= 4.8.
+# https://reviews.llvm.org/D57264

At the time this comment was written, I supposed that llvm >= 9.0 will require C++14. But llvm 9.0 was released with this option, so in practice we can still use gcc < 5.1 to build llvm. Maybe this comment should be updated.

Otherwise:

Best regards,
Romain

Quoted 6 lines
package/lld/lld.mk +2 -0
+HOST_LLD_CONF_OPTS += -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON
+
 # GCC looks for tools in a different path from LLD's default installation path
 define HOST_LLD_CREATE_SYMLINKS
 	mkdir -p $(HOST_DIR)/$(GNU_TARGET_NAME)/bin
#2 lore raw

PATCH 1/1 package/lld: fix build with gcc < 5.1

In reply to Joseph Kogut
Quoted 16 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Joseph" == Joseph Kogut <[email protected]> writes:

This fix is based on commit 2a17fb6 used for llvm. Fixes:
http://autobuild.buildroot.net/results/76310241a335a99a4ff2726edb517b067367fd41
http://autobuild.buildroot.net/results/88cbfae219fd4475be376c9558b5760cebd2148f

---
 package/lld/lld.mk | 6 ++++++
 1 file changed, 6 insertions(+)
package/lld/lld.mk +0 -0
index cd76c724ce..c284d6df7f 100644

package/lld/lld.mk LLD_LICENSE_FILES = LICENSE.TXT · line 21

Quoted 9 lines
package/lld/lld.mk +6 -0
@@ -13,6 +13,12 @@ LLD_LICENSE_FILES = LICENSE.TXT
 LLD_SUPPORTS_IN_SOURCE_BUILD = NO
 HOST_LLD_DEPENDENCIES = host-llvm
 
+# LLVM >= 9.0 will soon require C++14 support, building llvm 8.x using a
+# toolchain using gcc < 5.1 gives an error but actually still works. Setting
+# this option makes it still build with gcc >= 4.8.
+# https://reviews.llvm.org/D57264
+HOST_LLD_CONF_OPTS += -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN=ON
+

Committed after adjusting the comment as suggested by Romain, thanks.

Signature · 1 line
Bye, Peter Korsgaard