Skip to contentSkip to conversation

staging: vc04_services: fix warnings of scpace required between operator

PATCH RESEND In review Jules Irenge 2 participants 2 messages Oct 17, 2019 – Oct 25, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH RESEND 1/1 staging: vc04_services: fix warnings of scpace required between operator

Fix warnings of space required between operator and variables. Issue detected by checkpatch tool

---
This Resend patch includes fix for both vchi.h and vchi_cfg.h files Previous sent patch had onlyfix for vchi_cfg.h file

 drivers/staging/vc04_services/interface/vchi/vchi.h     | 8 ++++----
 drivers/staging/vc04_services/interface/vchi/vchi_cfg.h | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)
drivers/staging/vc04_services/interface/vchi/vchi.h +4 -4
index f85562b9ba9e..bdc393d36769 100644
@@ -11,14 +11,14 @@
  Global defs
  *****************************************************************************/
 
-#define VCHI_BULK_ROUND_UP(x)     ((((unsigned long)(x))+VCHI_BULK_ALIGN-1) & ~(VCHI_BULK_ALIGN-1))
-#define VCHI_BULK_ROUND_DOWN(x)   (((unsigned long)(x)) & ~(VCHI_BULK_ALIGN-1))
-#define VCHI_BULK_ALIGN_NBYTES(x) (VCHI_BULK_ALIGNED(x) ? 0 : (VCHI_BULK_ALIGN - ((unsigned long)(x) & (VCHI_BULK_ALIGN-1))))
+#define VCHI_BULK_ROUND_UP(x)     ((((unsigned long)(x)) + VCHI_BULK_ALIGN - 1) & ~(VCHI_BULK_ALIGN - 1))
+#define VCHI_BULK_ROUND_DOWN(x)   (((unsigned long)(x)) & ~(VCHI_BULK_ALIGN - 1))
+#define VCHI_BULK_ALIGN_NBYTES(x) (VCHI_BULK_ALIGNED(x) ? 0 : (VCHI_BULK_ALIGN - ((unsigned long)(x) & (VCHI_BULK_ALIGN - 1))))
 
 #ifdef USE_VCHIQ_ARM
 #define VCHI_BULK_ALIGNED(x)      1
 #else
-#define VCHI_BULK_ALIGNED(x)      (((unsigned long)(x) & (VCHI_BULK_ALIGN-1)) == 0)
+#define VCHI_BULK_ALIGNED(x)      (((unsigned long)(x) & (VCHI_BULK_ALIGN - 1)) == 0)
 #endif
 
 struct vchi_version {
drivers/staging/vc04_services/interface/vchi/vchi_cfg.h +2 -2
index 94c2fcf50468..138c36151a22 100644
@@ -175,9 +175,9 @@
  * by suspending parsing as the comment above says, but we don't.
  * This sweeps the issue under the carpet.
  */
-#if VCHI_RX_MSG_QUEUE_SIZE < (VCHI_MAX_MSG_SIZE/16 + 1) * VCHI_NUM_READ_SLOTS
+#if VCHI_RX_MSG_QUEUE_SIZE < (VCHI_MAX_MSG_SIZE / 16 + 1) * VCHI_NUM_READ_SLOTS
 #  undef VCHI_RX_MSG_QUEUE_SIZE
-#  define VCHI_RX_MSG_QUEUE_SIZE ((VCHI_MAX_MSG_SIZE/16 + 1) * VCHI_NUM_READ_SLOTS)
+#  define VCHI_RX_MSG_QUEUE_SIZE ((VCHI_MAX_MSG_SIZE / 16 + 1) * VCHI_NUM_READ_SLOTS)
 #endif
 
 /*
Signature · 1 line
2.21.0
maintainer
#1 lore raw
Quoted 7 lines · Jules Irenge

Fix warnings of space required between operator and variables. Issue detected by checkpatch tool

---
This Resend patch includes fix for both vchi.h and vchi_cfg.h files Previous sent patch had onlyfix for vchi_cfg.h file

That means this is not a "resend", but a totally different patch :(

Please make sure to get this correct next time, I'll take this now...

thanks,

greg k-h