Skip to contentSkip to conversation

Documentation: media: *_DEFAULT targets for subdevs

PATCH Superseded Ricardo Ribalda Delgado 2 participants 4 messages Oct 25, 2019

Subsystems (2)

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 Documentation: media: *_DEFAULT targets for subdevs

Some sensors have optical blanking areas, this is, pixels that are painted and do not account for light, only noise.

These special pixels are very useful for calibrating the sensor, but should not be displayed on a DEFAULT target.

---
 Documentation/media/uapi/v4l/v4l2-selection-targets.rst | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/media/uapi/v4l/v4l2-selection-targets.rst +4 -2
index f74f239b0510..a69571308a45 100644
@@ -38,8 +38,10 @@ of the two interfaces they are used.
     * - ``V4L2_SEL_TGT_CROP_DEFAULT``
       - 0x0001
       - Suggested cropping rectangle that covers the "whole picture".
+        This includes only active pixels and excludes other non-active
+        pixels such as black pixels.
+      - Yes
       - Yes
-      - No
     * - ``V4L2_SEL_TGT_CROP_BOUNDS``
       - 0x0002
       - Bounds of the crop rectangle. All valid crop rectangles fit inside
@@ -60,8 +62,8 @@ of the two interfaces they are used.
     * - ``V4L2_SEL_TGT_COMPOSE_DEFAULT``
       - 0x0101
       - Suggested composition rectangle that covers the "whole picture".
-      - Yes
       - No
+      - Yes
     * - ``V4L2_SEL_TGT_COMPOSE_BOUNDS``
       - 0x0102
       - Bounds of the compose rectangle. All valid compose rectangles fit
Signature · 1 line
2.23.0
#1 lore raw

PATCH v3 1/1 v4l2-compliance: Allow all the selection targets for subdevs

Subdev can also have non-active pixels, and using the _DEFAULT targets we can capture only the active pixels.

---
 utils/v4l2-compliance/v4l2-test-subdevs.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
utils/v4l2-compliance/v4l2-test-subdevs.cpp +1 -1
index 29987b31..ec4b9512 100644
@@ -395,7 +395,7 @@ struct target_info {
 
 static target_info targets[] = {
 	{ V4L2_SEL_TGT_CROP, true },
-	{ V4L2_SEL_TGT_CROP_DEFAULT, false, true },
+	{ V4L2_SEL_TGT_CROP_DEFAULT, true, true },
 	{ V4L2_SEL_TGT_CROP_BOUNDS, true, true },
 	{ V4L2_SEL_TGT_NATIVE_SIZE, true },
 	{ V4L2_SEL_TGT_COMPOSE, true },
Signature · 1 line
2.23.0
#2 lore raw
In reply to Ricardo Ribalda Delgado
Quoted 29 lines · Ricardo Ribalda Delgado

Some sensors have optical blanking areas, this is, pixels that are painted and do not account for light, only noise.

These special pixels are very useful for calibrating the sensor, but should not be displayed on a DEFAULT target.

---
 Documentation/media/uapi/v4l/v4l2-selection-targets.rst | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/media/uapi/v4l/v4l2-selection-targets.rst +3 -1
index f74f239b0510..a69571308a45 100644
@@ -38,8 +38,10 @@ of the two interfaces they are used.
     * - ``V4L2_SEL_TGT_CROP_DEFAULT``
       - 0x0001
       - Suggested cropping rectangle that covers the "whole picture".
+        This includes only active pixels and excludes other non-active
+        pixels such as black pixels.
+      - Yes
       - Yes
-      - No
     * - ``V4L2_SEL_TGT_CROP_BOUNDS``
       - 0x0002
       - Bounds of the crop rectangle. All valid crop rectangles fit inside

Documentation/media/uapi/v4l/v4l2-selection-targets.rst of the two interfaces they are used. · line 66

Quoted 6 lines
Documentation/media/uapi/v4l/v4l2-selection-targets.rst +1 -1
@@ -60,8 +62,8 @@ of the two interfaces they are used.
     * - ``V4L2_SEL_TGT_COMPOSE_DEFAULT``
       - 0x0101
       - Suggested composition rectangle that covers the "whole picture".
-      - Yes
       - No
+      - Yes

Was this intended?

v4?

Quoted 3 lines
Documentation/media/uapi/v4l/v4l2-selection-targets.rst +0 -0
     * - ``V4L2_SEL_TGT_COMPOSE_BOUNDS``
       - 0x0102
       - Bounds of the compose rectangle. All valid compose rectangles fit
Signature · 1 line
Sakari Ailus
#3 lore raw

No, I am retarded on friday :)

Sorry about that

Quoted 48 lines · Sakari Ailus
Quoted 29 lines · Ricardo Ribalda Delgado

Some sensors have optical blanking areas, this is, pixels that are painted and do not account for light, only noise.

These special pixels are very useful for calibrating the sensor, but should not be displayed on a DEFAULT target.

---
 Documentation/media/uapi/v4l/v4l2-selection-targets.rst | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Documentation/media/uapi/v4l/v4l2-selection-targets.rst +3 -1
index f74f239b0510..a69571308a45 100644
@@ -38,8 +38,10 @@ of the two interfaces they are used.
     * - ``V4L2_SEL_TGT_CROP_DEFAULT``
       - 0x0001
       - Suggested cropping rectangle that covers the "whole picture".
+        This includes only active pixels and excludes other non-active
+        pixels such as black pixels.
+      - Yes
       - Yes
-      - No
     * - ``V4L2_SEL_TGT_CROP_BOUNDS``
       - 0x0002
       - Bounds of the crop rectangle. All valid crop rectangles fit inside

Documentation/media/uapi/v4l/v4l2-selection-targets.rst of the two interfaces they are used. · line 66

Quoted 6 lines
Documentation/media/uapi/v4l/v4l2-selection-targets.rst +1 -1
@@ -60,8 +62,8 @@ of the two interfaces they are used.
     * - ``V4L2_SEL_TGT_COMPOSE_DEFAULT``
       - 0x0101
       - Suggested composition rectangle that covers the "whole picture".
-      - Yes
       - No
+      - Yes

Was this intended?

v4?

Documentation/media/uapi/v4l/v4l2-selection-targets.rst of the two interfaces they are used. · line 69

Quoted 3 lines
Documentation/media/uapi/v4l/v4l2-selection-targets.rst +0 -0
     * - ``V4L2_SEL_TGT_COMPOSE_BOUNDS``
       - 0x0102
       - Bounds of the compose rectangle. All valid compose rectangles fit

--
Sakari Ailus