arm64: dts: qcom: sdm845-cheza: delete zap-shader
PATCH 1/1 arm64: dts: qcom: sdm845-cheza: delete zap-shader
From: Rob Clark <[email protected]>
This is unused on cheza. Delete the node to get ride of the reserved- memory section, and to avoid the driver from attempting to load a zap shader that doesn't exist every time it powers up the GPU.
(This also avoids a massive amount of dmesg spam about missing zap fw.)
--- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi +2 -0
@@ -165,6 +165,8 @@ /delete-node/ &venus_mem; /delete-node/ &cdsp_mem; /delete-node/ &cdsp_pas; +/delete-node/ &zap_shader; +/delete-node/ &gpu_mem; /* Increase the size from 120 MB to 128 MB */ &mpss_region {
arch/arm64/boot/dts/qcom/sdm845.dtsi +1 -1
@@ -2824,7 +2824,7 @@ qcom,gmu = <&gmu>; - zap-shader { + zap_shader: zap-shader { memory-region = <&gpu_mem>; };
Signature · 1 line
2.21.0
Hi,
Quoted 8 lines · Rob Clark
From: Rob Clark <[email protected]>
This is unused on cheza. Delete the node to get ride of the reserved- memory section, and to avoid the driver from attempting to load a zap shader that doesn't exist every time it powers up the GPU.
(This also avoids a massive amount of dmesg spam about missing zap fw.)
optional nit: maybe when this is applied Bjorn / Andy can put in the actual error message to make this easier to find if anyone is seeing this problem. Specifically:
msm ae00000.mdss: [drm:adreno_request_fw] *ERROR* failed to load
qcom/a630_zap.mdt: -2
adreno 5000000.gpu: [drm:adreno_zap_shader_load] *ERROR* Unable to
load a630_zap.mdt
Quoted 6 lines
Signed-off-by Rob Clark <[email protected]>Cc Douglas Anderson <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
I probably would have put it in two patches (one for sdm845.dtsi and one for cheza) but that's more because I'm obsessive-compulsive than for any real reason. ;-) In any case:
-Doug
Quoted 29 lines · Doug Anderson
Hi,
Quoted 8 lines · Rob Clark
From: Rob Clark <[email protected]>
This is unused on cheza. Delete the node to get ride of the reserved- memory section, and to avoid the driver from attempting to load a zap shader that doesn't exist every time it powers up the GPU.
(This also avoids a massive amount of dmesg spam about missing zap fw.)
optional nit: maybe when this is applied Bjorn / Andy can put in the actual error message to make this easier to find if anyone is seeing this problem. Specifically:
msm ae00000.mdss: [drm:adreno_request_fw] *ERROR* failed to load
qcom/a630_zap.mdt: -2
adreno 5000000.gpu: [drm:adreno_zap_shader_load] *ERROR* Unable to
load a630_zap.mdtQuoted 6 lines
Signed-off-by Rob Clark <[email protected]>Cc Douglas Anderson <[email protected]>--- arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi | 2 ++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-)
Quoted 7 lines
I probably would have put it in two patches (one for
sdm845.dtsiand one for cheza) but that's more because I'm obsessive-compulsive than for any real reason. ;-) In any case:Fixes 3fdeaee951aa ("arm64: dts: sdm845: Add zap shader region for GPU")Reviewed-by Douglas Anderson <[email protected]>Tested-by Douglas Anderson <[email protected]>
Applied this patch and added in the dmesg error messages.
Andy