package/acpid: refactor init script
PATCH 1/1 package/acpid: refactor init script
From: Carlos Santos <[email protected]>
Adapt the format to the current template, used in other init scripts.
Move the one socond delay in restart to stop, giving acpid time to send dying gasp to syslog.
Users willing to add start arguments can set the ACPID_ARGS variable in /etc/default/acpid instead of rewriting the init script.
--- package/acpid/S02acpid | 65 +++++++++++++++++++++++++++++++----------- 1 file changed, 48 insertions(+), 17 deletions(-)
package/acpid/S02acpid +48 -17
@@ -1,22 +1,53 @@ #!/bin/sh -case "$1" in - start) - printf "Starting acpid: " - start-stop-daemon -S -q -m -b -p /var/run/acpid.pid --exec /usr/sbin/acpid -- -n - [ $? = 0 ] && echo "OK" || echo "FAIL" - ;; - stop) - printf "Stopping acpid: " - start-stop-daemon -K -q -p /var/run/acpid.pid - [ $? = 0 ] && echo "OK" || echo "FAIL" - ;; - restart) - "$0" stop +DAEMON="acpid" +EXEC="/usr/sbin/$DAEMON" +PIDFILE="/var/run/$DAEMON.pid" + +ACPID_ARGS="" + +# shellcheck source=/dev/null +[ -r "/etc/default/$DAEMON" ] && . "/etc/default/$DAEMON" + +start() { + printf 'Starting %s: ' "$DAEMON" + # shellcheck disable=SC2086 # we need the word splitting + start-stop-daemon -S -q -p "$PIDFILE" -x "$EXEC" \ + -- -n $ACPID_ARGS + status=$? + if [ "$status" -eq 0 ]; then + echo "OK" + else + echo "FAIL" + fi + return "$status" +} + +stop() { + printf 'Stopping %s: ' "$DAEMON" + start-stop-daemon -K -q -p "$PIDFILE" -x "$EXEC" + status=$? + if [ "$status" -eq 0 ]; then + # Give acpid time to send dying gasp to syslog sleep 1 - "$0" start - ;; + echo "OK" + else + echo "FAIL" + fi + return "$status" +} + +restart() { + stop + start +} + +case "$1" in + start|stop|restart) + "$1";; + reload) + restart;; *) - echo "Usage: $0 {start|stop|restart}" - ;; + echo "Usage: $0 {start|stop|restart|reload}" + exit 1 esac
Signature · 1 line
2.18.1
Thomas Petazzoni
AppliedPATCH 1/1 package/acpid: refactor init script
Quoted 7 lines · On Wed, 23 Oct 2019 15:05:12 -0300 unixmania at gmail.com wrote:
From: Carlos Santos <[email protected]>
Adapt the format to the current template, used in other init scripts.
Move the one socond delay in restart to stop, giving acpid time to send dying gasp to syslog.
Quoted 7 lines
Users willing to add start arguments can set the
ACPID_ARGSvariable in/etc/default/acpidinstead of rewriting the init script.Signed-off-by Carlos Santos <[email protected]>--- package/acpid/S02acpid | 65 +++++++++++++++++++++++++++++++----------- 1 file changed, 48 insertions(+), 17 deletions(-)
Applied to master, thanks.
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com