package/python-libconfig: fix build with python 3.8
PATCH 1/1 package/python-libconfig: fix build with python 3.8
Fixes:
- http://autobuild.buildroot.org/results/edf32c178b7912a987e119f776a51f464424dceb
Signed-off-by Fabrice Fontaine <[email protected]>
--- ...python-name-depending-on-current-Pyt.patch | 44 ------------------- package/python-libconfig/python-libconfig.mk | 12 +++++ 2 files changed, 12 insertions(+), 44 deletions(-) delete mode 100644 package/python-libconfig/0001-Determine-boost_python-name-depending-on-current-Pyt.patch
package/python-libconfig/0001-Determine-boost_python-name-depending-on-current-Pyt.patch deleted +0 -44
@@ -1,44 +0,0 @@ -From 3bc4b9c0d60a735b1d63e52f74492ace39f02824 Mon Sep 17 00:00:00 2001 -From: Yegor Yefremov <[email protected]> -Date: Thu, 27 Jul 2017 09:46:07 +0200 -Subject: [PATCH] Determine boost_python name depending on current Python - version - -Python2 requires boost_python27 and Python3 requires boost_python37 -(since boost 1.67). - -Signed-off-by: Yegor Yefremov <[email protected]> -Signed-off-by: Fabrice Fontaine <[email protected]> -[Bernd: adapted for python-3.7] -Signed-off-by: Bernd Kuhls <[email protected]> ---- - setup.py | 6 +++++- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/setup.py b/setup.py -index fdf5c27..4b38569 100644 ---- a/setup.py -+++ b/setup.py -@@ -3,6 +3,10 @@ - from setuptools import setup, find_packages, Extension - import sys, os - -+boostlib = "boost_python37" -+if sys.version_info < (3, 0): -+ boostlib = "boost_python27" -+ - setup( - name = 'pylibconfig', - description = "libconfig bindings for Python", -@@ -19,7 +23,7 @@ setup( - Extension( - "pylibconfig", - ["src/pylibconfig.cc"], -- libraries=["boost_python", "config++"] -+ libraries=[boostlib, "config++"] - #include_dirs=includes, - #extra_link_args=lflags - ) --- -2.11.0 -
package/python-libconfig/python-libconfig.mk +12 -0
@@ -14,4 +14,16 @@ PYTHON_LIBCONFIG_SETUP_TYPE = setuptools PYTHON_LIBCONFIG_DEPENDENCIES = libconfig boost +ifeq ($(BR2_PACKAGE_PYTHON),y) +PYTHON_LIBCONFIG_PYVER = $(PYTHON_VERSION_MAJOR) +else ifeq ($(BR2_PACKAGE_PYTHON3),y) +PYTHON_LIBCONFIG_PYVER = $(PYTHON3_VERSION_MAJOR) +endif + +define PYTHON_LIBCONFIG_FIX_SETUP + $(SED) 's/boost_python/boost_python$(subst .,,$(PYTHON_LIBCONFIG_PYVER))/g' \ + $(@D)/setup.py +endef +PYTHON_LIBCONFIG_POST_PATCH_HOOKS += PYTHON_LIBCONFIG_FIX_SETUP + $(eval $(python-package))
Signature · 1 line
2.23.0
PATCH 1/1 package/python-libconfig: fix build with python 3.8
Hello Fabrice,
Quoted 9 lines · On Fri, 25 Oct 2019 18:42:36 +0200 Fabrice Fontaine…
Fixes:
- http://autobuild.buildroot.org/results/edf32c178b7912a987e119f776a51f464424dcebSigned-off-by Fabrice Fontaine <[email protected]>--- ...python-name-depending-on-current-Pyt.patch | 44 ------------------- package/python-libconfig/python-libconfig.mk | 12 +++++ 2 files changed, 12 insertions(+), 44 deletions(-) delete mode 100644 package/python-libconfig/0001-Determine-boost_python-name-depending-on-current-Pyt.patch
I've applied, but really this commit log was not descriptive enough. Could you make sure for your next patches to include more details in your commit log ?
Thanks!
Thomas
Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com