staging: greybus: Fix line ending with a '('
Subsystems (3)
PATCH 1/1 staging: greybus: Fix line ending with a '('
checkpatch.pl message:
"CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"
Signed-off-by Frank A. Cancio Bello <[email protected]>
--- .../staging/greybus/audio_manager_module.c | 32 ++++++++----------- .../staging/greybus/audio_manager_private.h | 7 ++-- 2 files changed, 16 insertions(+), 23 deletions(-)
drivers/staging/greybus/audio_manager_module.c +13 -19
@@ -70,9 +70,8 @@ static void gb_audio_module_release(struct kobject *kobj)kfree (module); } -static ssize_t gb_audio_module_name_show ( -struct gb_audio_manager_module *module, -struct gb_audio_manager_module_attribute *attr,char *buf) +static ssize_t gb_audio_module_name_show (struct gb_audio_manager_module *module, +struct gb_audio_manager_module_attribute *attr,char *buf) {return sprintf (buf,"%s" , module->desc.name); }
@@ -80,9 +79,8 @@ static ssize_t gb_audio_module_name_show(static struct gb_audio_manager_module_attribute gb_audio_module_name_attribute =__ATTR (name,0664 , gb_audio_module_name_show,NULL ); -static ssize_t gb_audio_module_vid_show ( -struct gb_audio_manager_module *module, -struct gb_audio_manager_module_attribute *attr,char *buf) +static ssize_t gb_audio_module_vid_show (struct gb_audio_manager_module *module, +struct gb_audio_manager_module_attribute *attr,char *buf) {return sprintf (buf,"%d" , module->desc.vid); }
@@ -90,9 +88,8 @@ static ssize_t gb_audio_module_vid_show(static struct gb_audio_manager_module_attribute gb_audio_module_vid_attribute =__ATTR (vid,0664 , gb_audio_module_vid_show,NULL ); -static ssize_t gb_audio_module_pid_show ( -struct gb_audio_manager_module *module, -struct gb_audio_manager_module_attribute *attr,char *buf) +static ssize_t gb_audio_module_pid_show (struct gb_audio_manager_module *module, +struct gb_audio_manager_module_attribute *attr,char *buf) {return sprintf (buf,"%d" , module->desc.pid); }
@@ -111,9 +108,8 @@ static struct gb_audio_manager_module_attribute gb_audio_module_intf_id_attribute =__ATTR (intf_id,0664 , gb_audio_module_intf_id_show,NULL ); -static ssize_t gb_audio_module_ip_devices_show ( -struct gb_audio_manager_module *module, -struct gb_audio_manager_module_attribute *attr,char *buf) +static ssize_t gb_audio_module_ip_devices_show (struct gb_audio_manager_module *module, +struct gb_audio_manager_module_attribute *attr,char *buf) {return sprintf (buf,"0x%X" , module->desc.ip_devices); }
@@ -122,9 +118,8 @@ static struct gb_audio_manager_module_attribute gb_audio_module_ip_devices_attribute =__ATTR (ip_devices,0664 , gb_audio_module_ip_devices_show,NULL ); -static ssize_t gb_audio_module_op_devices_show ( -struct gb_audio_manager_module *module, -struct gb_audio_manager_module_attribute *attr,char *buf) +static ssize_t gb_audio_module_op_devices_show (struct gb_audio_manager_module *module, +struct gb_audio_manager_module_attribute *attr,char *buf) {return sprintf (buf,"0x%X" , module->desc.op_devices); }
@@ -180,10 +175,9 @@ static void send_add_uevent(struct gb_audio_manager_module *module)kobject_uevent_env (&module->kobj,KOBJ_ADD , envp); } -int gb_audio_manager_module_create ( -struct gb_audio_manager_module **module, -struct kset *manager_kset, -int id,struct gb_audio_manager_module_descriptor *desc) +int gb_audio_manager_module_create (struct gb_audio_manager_module **module, +struct kset *manager_kset, +int id,struct gb_audio_manager_module_descriptor *desc) {int err;struct gb_audio_manager_module *m;
drivers/staging/greybus/audio_manager_private.h +3 -4
@@ -12,10 +12,9 @@#include "audio_manager.h" -int gb_audio_manager_module_create ( -struct gb_audio_manager_module **module, -struct kset *manager_kset, -int id,struct gb_audio_manager_module_descriptor *desc); +int gb_audio_manager_module_create (struct gb_audio_manager_module **module, +struct kset *manager_kset, +int id,struct gb_audio_manager_module_descriptor *desc);/* module destroyed via kobject_put */
Signature · 1 line
2.17.1
Greg KH
maintainerQuoted 14 lines · Frank A. Cancio Bello
checkpatch.pl message:
"CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"Signed-off-by Frank A. Cancio Bello <[email protected]>--- .../staging/greybus/audio_manager_module.c | 32 ++++++++----------- .../staging/greybus/audio_manager_private.h | 7 ++-- 2 files changed, 16 insertions(+), 23 deletions(-)drivers/staging/greybus/audio_manager_module.c +0
-0
drivers/staging/greybus/audio_manager_module.c static void gb_audio_module_release(struct kobject *kobj) · line 74
Quoted 8 lines
drivers/staging/greybus/audio_manager_module.c +2
-3@@ -70,9 +70,8 @@ static void gb_audio_module_release(struct kobject *kobj)kfree (module); } -static ssize_t gb_audio_module_name_show ( -struct gb_audio_manager_module *module, -struct gb_audio_manager_module_attribute *attr,char *buf) +static ssize_t gb_audio_module_name_show (struct gb_audio_manager_module *module, +struct gb_audio_manager_module_attribute *attr,char *buf)
Same thing here, your line is too long now, it's fine as-is.
thanks,
greg k-h
Quoted 18 lines · Greg KH
Quoted 17 lines · Frank A. Cancio Bello
checkpatch.pl message:
"CHECK:OPEN_ENDED_LINE: Lines should not end with a '('"Signed-off-by Frank A. Cancio Bello <[email protected]>--- .../staging/greybus/audio_manager_module.c | 32 ++++++++----------- .../staging/greybus/audio_manager_private.h | 7 ++-- 2 files changed, 16 insertions(+), 23 deletions(-)drivers/staging/greybus/audio_manager_module.c +0
-0@@ -70,9 +70,8 @@ static void gb_audio_module_release(struct kobject *kobj)kfree (module); }
Quoted 8 lines
drivers/staging/greybus/audio_manager_module.c static void gb_audio_module_release(struct kobject *kobj) · line 74
Quoted 5 lines
drivers/staging/greybus/audio_manager_module.c +2
-3-static ssize_t gb_audio_module_name_show ( -struct gb_audio_manager_module *module, -struct gb_audio_manager_module_attribute *attr,char *buf) +static ssize_t gb_audio_module_name_show (struct gb_audio_manager_module *module, +struct gb_audio_manager_module_attribute *attr,char *buf)Same thing here, your line is too long now, it's fine as-is.
Thank you one more time for your quick response.
frank a.
Quoted 3 lines
thanks,
greg k-h