Skip to contentSkip to conversation

Input: colibri-vf50-ts - remove unneeded gpio.h header file

PATCH Applied Fabio Estevam 2 participants 6 messages Oct 26, 2019 – Oct 27, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 Input: colibri-vf50-ts - remove unneeded gpio.h header file

The touchscreen device is a GPIO consumer, not a GPIO controller, so there is no need to include <linux/gpio.h>.

Remove the unneeded header file.

---
 drivers/input/touchscreen/colibri-vf50-ts.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/touchscreen/colibri-vf50-ts.c +0 -1
index 0e40897949bb..aa829725ded7 100644
@@ -9,7 +9,6 @@
 
 #include <linux/delay.h>
 #include <linux/err.h>
-#include <linux/gpio.h>
 #include <linux/gpio/consumer.h>
 #include <linux/iio/consumer.h>
 #include <linux/iio/types.h>
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/3 Input: s3c2410_ts - remove unneeded gpio.h header file

There is no gpio functions used in the driver that is exported by the gpio.h header, so remove this unneeded header.

---
 drivers/input/touchscreen/s3c2410_ts.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/touchscreen/s3c2410_ts.c +0 -1
index b346e7cafd62..82920ff46f72 100644
@@ -13,7 +13,6 @@
 #include <linux/errno.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/gpio.h>
 #include <linux/input.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
Signature · 1 line
2.17.1
maintainer Applied
#2 lore raw

Re: [PATCH 2/3] Input: s3c2410_ts - remove unneeded gpio.h header file

Quoted 4 lines · Fabio Estevam

There is no gpio functions used in the driver that is exported by the gpio.h header, so remove this unneeded header.

Applied, thank you.

Quoted 19 lines
---
 drivers/input/touchscreen/s3c2410_ts.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/touchscreen/s3c2410_ts.c +0 -1
index b346e7cafd62..82920ff46f72 100644
@@ -13,7 +13,6 @@
 #include <linux/errno.h>
 #include <linux/kernel.h>
 #include <linux/module.h>
-#include <linux/gpio.h>
 #include <linux/input.h>
 #include <linux/delay.h>
 #include <linux/interrupt.h>
Signature · 1 line
2.17.1
Signature · 1 line
Dmitry
#3 lore raw

PATCH 3/3 Input: wacom_i2c - remove unneeded gpio.h header file

In reply to Fabio Estevam

There is no gpio functions used in the driver that is exported by the gpio.h header, so remove this unneeded header.

---
 drivers/input/touchscreen/wacom_i2c.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/touchscreen/wacom_i2c.c +0 -1
index f017af8c2aa3..1afc6bde2891 100644
@@ -12,7 +12,6 @@
 #include <linux/slab.h>
 #include <linux/irq.h>
 #include <linux/interrupt.h>
-#include <linux/gpio.h>
 #include <asm/unaligned.h>
 
 #define WACOM_CMD_QUERY0	0x04
Signature · 1 line
2.17.1
maintainer Applied
#4 lore raw

Re: [PATCH 3/3] Input: wacom_i2c - remove unneeded gpio.h header file

Quoted 4 lines · Fabio Estevam

There is no gpio functions used in the driver that is exported by the gpio.h header, so remove this unneeded header.

Applied, thank you.

Quoted 19 lines
---
 drivers/input/touchscreen/wacom_i2c.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/touchscreen/wacom_i2c.c +0 -1
index f017af8c2aa3..1afc6bde2891 100644
@@ -12,7 +12,6 @@
 #include <linux/slab.h>
 #include <linux/irq.h>
 #include <linux/interrupt.h>
-#include <linux/gpio.h>
 #include <asm/unaligned.h>
 
 #define WACOM_CMD_QUERY0	0x04
Signature · 1 line
2.17.1
Signature · 1 line
Dmitry
maintainer Applied
#5 lore raw
In reply to Fabio Estevam
Quoted 6 lines · Fabio Estevam

The touchscreen device is a GPIO consumer, not a GPIO controller, so there is no need to include <linux/gpio.h>.

Remove the unneeded header file.

Applied, thank you.

Quoted 19 lines
---
 drivers/input/touchscreen/colibri-vf50-ts.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/touchscreen/colibri-vf50-ts.c +0 -1
index 0e40897949bb..aa829725ded7 100644
@@ -9,7 +9,6 @@
 
 #include <linux/delay.h>
 #include <linux/err.h>
-#include <linux/gpio.h>
 #include <linux/gpio/consumer.h>
 #include <linux/iio/consumer.h>
 #include <linux/iio/types.h>
Signature · 1 line
2.17.1
Signature · 1 line
Dmitry