ASoC: SOF: Fix memory leak in sof_dfsentry_write
Subsystems (3)
PATCH 1/1 ASoC: SOF: Fix memory leak in sof_dfsentry_write
In the implementation of sof_dfsentry_write() memory allocated for string is leaked in case of an error. Go to error handling path if the d_name.name is not valid.
--- sound/soc/sof/debug.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
sound/soc/sof/debug.c +4 -2
@@ -152,8 +152,10 @@ static ssize_t sof_dfsentry_write(struct file *file, const char __user *buffer,*/ dentry = file->f_path.dentry;if (strcmp (dentry->d_name.name,"ipc_flood_count" ) && -strcmp (dentry->d_name.name,"ipc_flood_duration_ms" )) -return -EINVAL ; +strcmp (dentry->d_name.name,"ipc_flood_duration_ms" )) { + ret = -EINVAL ; + goto out; + }if (!strcmp (dentry->d_name.name,"ipc_flood_duration_ms" )) flood_duration_test = true;
Signature · 1 line
2.17.1
Quoted 6 lines · Navid Emamdoost
In the implementation of
sof_dfsentry_write()memory allocated for string is leaked in case of an error. Go to error handling path if the d_name.name is not valid.Fixes 091c12e1f50c ("ASoC: SOF: debug: add new debugfs entries for IPC flood test")Signed-off-by Navid Emamdoost <[email protected]>
Quoted 22 lines
--- sound/soc/sof/debug.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)sound/soc/sof/debug.c +4
-2@@ -152,8 +152,10 @@ static ssize_t sof_dfsentry_write(struct file *file, const char __user *buffer,*/ dentry = file->f_path.dentry;if (strcmp (dentry->d_name.name,"ipc_flood_count" ) && -strcmp (dentry->d_name.name,"ipc_flood_duration_ms" )) -return -EINVAL ; +strcmp (dentry->d_name.name,"ipc_flood_duration_ms" )) { + ret = -EINVAL ; + goto out; + }if (!strcmp (dentry->d_name.name,"ipc_flood_duration_ms" )) flood_duration_test = true;
Mark Brown
maintainerApplied "ASoC: SOF: Fix memory leak in sof_dfsentry_write" to the asoc tree
In reply to Navid EmamdoostThe patch
ASoC: SOF: Fix memory leak in sof_dfsentry_write
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark
From c0a333d842ef67ac04adc72ff79dc1ccc3dca4ed Mon Sep 17 00:00:00 2001
From: Navid Emamdoost <[email protected]>
Date: Sun, 27 Oct 2019 14:48:47 -0500
Subject: [PATCH] ASoC: SOF: Fix memory leak in sof_dfsentry_write
In the implementation of sof_dfsentry_write() memory allocated for string is leaked in case of an error. Go to error handling path if the d_name.name is not valid.
--- sound/soc/sof/debug.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
sound/soc/sof/debug.c +4 -2
@@ -152,8 +152,10 @@ static ssize_t sof_dfsentry_write(struct file *file, const char __user *buffer,*/ dentry = file->f_path.dentry;if (strcmp (dentry->d_name.name,"ipc_flood_count" ) && -strcmp (dentry->d_name.name,"ipc_flood_duration_ms" )) -return -EINVAL ; +strcmp (dentry->d_name.name,"ipc_flood_duration_ms" )) { + ret = -EINVAL ; + goto out; + }if (!strcmp (dentry->d_name.name,"ipc_flood_duration_ms" )) flood_duration_test = true;
Signature · 1 line
2.20.1