ALSA: usb-audio: Fix memory leak in __snd_usbmidi_create
Subsystems (2)
PATCH 1/1 ALSA: usb-audio: Fix memory leak in __snd_usbmidi_create
In the implementation of __snd_usbmidi_create() there is a memory leak caused by incorrect goto destination. Go to free_midi if snd_usbmidi_create_endpoints_midiman() or snd_usbmidi_create_endpoints() fail.
--- sound/usb/midi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/usb/midi.c +1 -1
@@ -2476,7 +2476,7 @@ int __snd_usbmidi_create(struct snd_card *card,else err =snd_usbmidi_create_endpoints (umidi, endpoints);if (err <0 ) - goto exit; + goto free_midi;usb_autopm_get_interface_no_resume (umidi->iface);
Signature · 1 line
2.17.1
Quoted 5 lines · Navid Emamdoost
In the implementation of
__snd_usbmidi_create()there is a memory leak caused by incorrect goto destination. Go tofree_midiifsnd_usbmidi_create_endpoints_midiman()orsnd_usbmidi_create_endpoints()fail.
No, this will lead to double-free. After registering the rawmidi interface at snd_usbmidi_create_rawmidi(), the common destructor will be called via rawmidi private_free callback, and this will release the all resources already.
thanks,
Takashi
Quoted 23 lines
Fixes 731209cc0417 ("ALSA: usb-midi: Use common error handling code in __snd_usbmidi_create()")Signed-off-by Navid Emamdoost <[email protected]>--- sound/usb/midi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/usb/midi.c +1
-1@@ -2476,7 +2476,7 @@ int __snd_usbmidi_create(struct snd_card *card,else err =snd_usbmidi_create_endpoints (umidi, endpoints);if (err <0 ) - goto exit; + goto free_midi;usb_autopm_get_interface_no_resume (umidi->iface);Signature · 1 line
2.17.1
Thanks for the explanation,
Quoted 9 lines · Takashi Iwai
Quoted 5 lines · Navid Emamdoost
In the implementation of
__snd_usbmidi_create()there is a memory leak caused by incorrect goto destination. Go tofree_midiifsnd_usbmidi_create_endpoints_midiman()orsnd_usbmidi_create_endpoints()fail.
Quoted 4 lines
No, this will lead to double-free. After registering the rawmidi interface at
snd_usbmidi_create_rawmidi(), the common destructor will be called via rawmidiprivate_freecallback, and this will release the all resources already.
Now I can see how rawmidi private_free is set up to release the resources, but what concerns me is that at the moment of endpoint/port creation umidi is not yet added to the midi_list.
In other words, what I see is that we still have just one local pointer to umidi if any of snd_usbmidi_create_endpoint* fail. Am I missing something?
Quoted 29 lines
thanks,
Takashi
Quoted 23 lines
Fixes 731209cc0417 ("ALSA: usb-midi: Use common error handling code in __snd_usbmidi_create()")Signed-off-by Navid Emamdoost <[email protected]>--- sound/usb/midi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/usb/midi.c +1
-2@@ -2476,7 +2476,7 @@ int __snd_usbmidi_create(struct snd_card *card,else err =snd_usbmidi_create_endpoints (umidi, endpoints);if (err <0 ) - goto exit; + goto free_midi;usb_autopm_get_interface_no_resume (umidi->iface); --2.17.1
Signature · 1 line
Navid.
Quoted 17 lines · Navid Emamdoost
Thanks for the explanation,
Quoted 9 lines · Takashi Iwai
Quoted 5 lines · Navid Emamdoost
In the implementation of
__snd_usbmidi_create()there is a memory leak caused by incorrect goto destination. Go tofree_midiifsnd_usbmidi_create_endpoints_midiman()orsnd_usbmidi_create_endpoints()fail.Quoted 4 lines
No, this will lead to double-free. After registering the rawmidi interface at
snd_usbmidi_create_rawmidi(), the common destructor will be called via rawmidiprivate_freecallback, and this will release the all resources already.
Quoted 6 lines
Now I can see how rawmidi
private_freeis set up to release the resources, but what concerns me is that at the moment of endpoint/port creation umidi is not yet added to themidi_list.
In other words, what I see is that we still have just one local pointer to umidi if any of snd_usbmidi_create_endpoint* fail. Am I missing something?
The rawmidi object that is created via snd_rawmidi_new() is managed via snd_device list, and it's traversed at snd_card_disconnect() and snd_card_free() calls. It's something like devm-stuff (but implemented in a different way). The midi_list is an explicit list for the USB MIDI driver, and it's an individual one from the device list.
Takashi
Quoted 37 lines
Quoted 31 lines
thanks,
Takashi
Quoted 23 lines
Fixes 731209cc0417 ("ALSA: usb-midi: Use common error handling code in __snd_usbmidi_create()")Signed-off-by Navid Emamdoost <[email protected]>--- sound/usb/midi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/usb/midi.c +1
-2@@ -2476,7 +2476,7 @@ int __snd_usbmidi_create(struct snd_card *card,else err =snd_usbmidi_create_endpoints (umidi, endpoints);if (err <0 ) - goto exit; + goto free_midi;usb_autopm_get_interface_no_resume (umidi->iface); --2.17.1
Signature · 1 line
Navid.
Quoted 27 lines · Takashi Iwai
Quoted 17 lines · Navid Emamdoost
Thanks for the explanation,
Quoted 9 lines · Takashi Iwai
Quoted 5 lines · Navid Emamdoost
In the implementation of
__snd_usbmidi_create()there is a memory leak caused by incorrect goto destination. Go tofree_midiifsnd_usbmidi_create_endpoints_midiman()orsnd_usbmidi_create_endpoints()fail.Quoted 4 lines
No, this will lead to double-free. After registering the rawmidi interface at
snd_usbmidi_create_rawmidi(), the common destructor will be called via rawmidiprivate_freecallback, and this will release the all resources already.Quoted 6 lines
Now I can see how rawmidi
private_freeis set up to release the resources, but what concerns me is that at the moment of endpoint/port creation umidi is not yet added to themidi_list.
In other words, what I see is that we still have just one local pointer to umidi if any of snd_usbmidi_create_endpoint* fail. Am I missing something?
Quoted 6 lines
The rawmidi object that is created via
snd_rawmidi_new()is managed viasnd_devicelist, and it's traversed atsnd_card_disconnect()andsnd_card_free()calls. It's something like devm-stuff (but implemented in a different way). Themidi_listis an explicit list for the USB MIDI driver, and it's an individual one from the device list.
Thanks for the clarification.
Quoted 41 lines
Takashi
Quoted 37 lines
Quoted 26 lines
thanks,
Takashi
Quoted 18 lines
Fixes 731209cc0417 ("ALSA: usb-midi: Use common error handling code in __snd_usbmidi_create()")Signed-off-by Navid Emamdoost <[email protected]>--- sound/usb/midi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)sound/usb/midi.c +1
-1@@ -2476,7 +2476,7 @@ int __snd_usbmidi_create(struct snd_card *card,else err =snd_usbmidi_create_endpoints (umidi, endpoints);if (err <0 ) - goto exit; + goto free_midi;Quoted 5 lines
Quoted 5 lines
sound/usb/midi.c +0
-1usb_autopm_get_interface_no_resume (umidi->iface); --2.17.1
--
Navid.
Signature · 1 line
Navid.
Clemens Ladisch
maintainerQuoted 13 lines · Navid Emamdoost
Quoted 11 lines · Takashi Iwai
Quoted 4 lines · Navid Emamdoost
In the implementation of
__snd_usbmidi_create()there is a memory leak caused by incorrect goto destination. Go tofree_midiifsnd_usbmidi_create_endpoints_midiman()orsnd_usbmidi_create_endpoints()fail.No, this will lead to double-free. After registering the rawmidi interface at
snd_usbmidi_create_rawmidi(), the common destructor will be called via rawmidiprivate_freecallback, and this will release the all resources already.
Quoted 5 lines
Now I can see how rawmidi
private_freeis set up to release the resources, but what concerns me is that at the moment of endpoint/port creation umidi is not yet added to themidi_list.
In other words, what I see is that we still have just one local pointer to umidi if any of snd_usbmidi_create_endpoint* fail.
The snd_rawmidi device is automatically registered with the card, so the line "rmidi->private_free = snd_usbmidi_rawmidi_free;" is the exact point where the ownership of umidi changes. midi_list does not matter.
Regards,
Clemens
_______________________________________________
Alsa-devel mailing list
[email protected]
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel