media: dvb: Fix memory leak in af9005_identify_state
PATCH 1/1 media: dvb: Fix memory leak in af9005_identify_state
In the implementation of af9005_identify_state() there is a memory leak when checking the reply of af9005_boot_packet(). Go to error path to release buf.
Fixes af4e067e1dcf ("V4L/DVB (5625): Add support for the AF9005 demodulator from Afatech")
Signed-off-by Navid Emamdoost <[email protected]>
--- drivers/media/usb/dvb-usb/af9005.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/media/usb/dvb-usb/af9005.c +4 -2
@@ -975,8 +975,10 @@ static int af9005_identify_state(struct usb_device *udev, *cold =1 ; else if (reply == 0x02) *cold =0 ; - else - return -EIO; + else { + ret = -EIO ; + goto err; + }deb_info ("Identify state cold = %d\n" , *cold); err:
Signature · 1 line
2.17.1
Quoted 6 lines · Navid Emamdoost
In the implementation of
af9005_identify_state()there is a memory leak when checking the reply ofaf9005_boot_packet(). Go to error path to release buf.Fixes af4e067e1dcf ("V4L/DVB (5625): Add support for the AF9005 demodulator from Afatech")Signed-off-by Navid Emamdoost <[email protected]>
Thank you for the patch.
Unfortunately a similar patch is already merged:
https://git.linuxtv.org/media_tree.git/commit/?id=2289adbfa559050d2a38bcd9caac1c18b800e928
Sean
Quoted 23 lines
--- drivers/media/usb/dvb-usb/af9005.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/media/usb/dvb-usb/af9005.c +4
-2@@ -975,8 +975,10 @@ static int af9005_identify_state(struct usb_device *udev, *cold =1 ; else if (reply == 0x02) *cold =0 ; - else - return -EIO; + else { + ret = -EIO ; + goto err; + }deb_info ("Identify state cold = %d\n" , *cold); err:Signature · 1 line
2.17.1