staging: mt7621-dma: Remove unnecessary line continuations
Subsystems (2)
PATCH 1/1 staging: mt7621-dma: Remove unnecessary line continuations
checkpatch message:
"WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations"
--- drivers/staging/mt7621-dma/mtk-hsdma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/staging/mt7621-dma/mtk-hsdma.c +5 -5
@@ -208,8 +208,8 @@ static void mtk_hsdma_reset_chan(struct mtk_hsdam_engine *hsdma,static void hsdma_dump_reg (struct mtk_hsdam_engine *hsdma) { - dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, " \ - "tctx %08x, tdtx: %08x, rbase %08x, " \ + dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, " + "tctx %08x, tdtx: %08x, rbase %08x, " "rcnt %08x, rctx %08x, rdtx %08x\n", mtk_hsdma_read(hsdma, HSDMA_REG_TX_BASE), mtk_hsdma_read(hsdma, HSDMA_REG_TX_CNT),
@@ -220,7 +220,7 @@ static void hsdma_dump_reg(struct mtk_hsdam_engine *hsdma)mtk_hsdma_read (hsdma,HSDMA_REG_RX_CRX ), mtk_hsdma_read(hsdma, HSDMA_REG_RX_DRX)); - dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, " \ + dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, " "intr_stat %08x, intr_mask %08x\n", mtk_hsdma_read(hsdma, HSDMA_REG_INFO), mtk_hsdma_read(hsdma, HSDMA_REG_GLO_CFG),
@@ -243,9 +243,9 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma, tx_desc = &chan->tx_ring[i]; rx_desc = &chan->rx_ring[i]; -dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, " \ +dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, " "tx addr1: %08x, rx addr0 %08x, flags %08x\n" , - i, tx_desc->addr0, tx_desc->flags, \ + i, tx_desc->addr0, tx_desc->flags, tx_desc->addr1, rx_desc->addr0, rx_desc->flags); } }
Signature · 1 line
2.17.1
Quoted 13 lines · Frank A. Cancio Bello
checkpatch message:
"WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations"Signed-off-by Frank A. Cancio Bello <[email protected]>--- drivers/staging/mt7621-dma/mtk-hsdma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/staging/mt7621-dma/mtk-hsdma.c +0
-0
drivers/staging/mt7621-dma/mtk-hsdma.c static void mtk_hsdma_reset_chan(struct mtk_hsdam_engine *hsdma, · line 213
Quoted 8 lines
drivers/staging/mt7621-dma/mtk-hsdma.c +2
-2@@ -208,8 +208,8 @@ static void mtk_hsdma_reset_chan(struct mtk_hsdam_engine *hsdma,static void hsdma_dump_reg (struct mtk_hsdam_engine *hsdma) { - dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, " \ - "tctx %08x, tdtx: %08x, rbase %08x, " \ + dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, " + "tctx %08x, tdtx: %08x, rbase %08x, " "rcnt %08x, rctx %08x, rdtx %08x\n",
String should not be cut over multiple lines, even if it results in exceeding 80 characters. This makes it easier to grep for messages in the code. You could fix both problems at once, since they affect the same code in each case.
julia
Quoted 31 lines
drivers/staging/mt7621-dma/mtk-hsdma.c +3
-4mtk_hsdma_read (hsdma,HSDMA_REG_TX_BASE ), mtk_hsdma_read(hsdma, HSDMA_REG_TX_CNT),@@ -220,7 +220,7 @@ static void hsdma_dump_reg(struct mtk_hsdam_engine *hsdma)mtk_hsdma_read (hsdma,HSDMA_REG_RX_CRX ), mtk_hsdma_read(hsdma, HSDMA_REG_RX_DRX)); - dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, " \ + dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, " "intr_stat %08x, intr_mask %08x\n", mtk_hsdma_read(hsdma, HSDMA_REG_INFO), mtk_hsdma_read(hsdma, HSDMA_REG_GLO_CFG),@@ -243,9 +243,9 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma, tx_desc = &chan->tx_ring[i]; rx_desc = &chan->rx_ring[i]; -dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, " \ +dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, " "tx addr1: %08x, rx addr0 %08x, flags %08x\n" , - i, tx_desc->addr0, tx_desc->flags, \ + i, tx_desc->addr0, tx_desc->flags, tx_desc->addr1, rx_desc->addr0, rx_desc->flags); } } --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191028051237.3row7xnbr6pgn4bp%40linux-kernel-dev.
Quoted 31 lines · Julia Lawall
Quoted 13 lines · Frank A. Cancio Bello
checkpatch message:
"WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations"Signed-off-by Frank A. Cancio Bello <[email protected]>--- drivers/staging/mt7621-dma/mtk-hsdma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)drivers/staging/mt7621-dma/mtk-hsdma.c +0
-0drivers/staging/mt7621-dma/mtk-hsdma.c static void mtk_hsdma_reset_chan(struct mtk_hsdam_engine *hsdma, · line 213
Quoted 8 lines
drivers/staging/mt7621-dma/mtk-hsdma.c +2
-2@@ -208,8 +208,8 @@ static void mtk_hsdma_reset_chan(struct mtk_hsdam_engine *hsdma,static void hsdma_dump_reg (struct mtk_hsdam_engine *hsdma) { - dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, " \ - "tctx %08x, tdtx: %08x, rbase %08x, " \ + dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, " + "tctx %08x, tdtx: %08x, rbase %08x, " "rcnt %08x, rctx %08x, rdtx %08x\n",String should not be cut over multiple lines, even if it results in exceeding 80 characters. This makes it easier to grep for messages in the code. You could fix both problems at once, since they affect the same code in each case.
Quoted 2 lines
julia
Thank you Julia for the suggestion. I already sent a new version of the patch.
frank a.
Quoted 31 lines
Quoted 31 lines
drivers/staging/mt7621-dma/mtk-hsdma.c +3
-4mtk_hsdma_read (hsdma,HSDMA_REG_TX_BASE ), mtk_hsdma_read(hsdma, HSDMA_REG_TX_CNT),@@ -220,7 +220,7 @@ static void hsdma_dump_reg(struct mtk_hsdam_engine *hsdma)mtk_hsdma_read (hsdma,HSDMA_REG_RX_CRX ), mtk_hsdma_read(hsdma, HSDMA_REG_RX_DRX)); - dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, " \ + dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, " "intr_stat %08x, intr_mask %08x\n", mtk_hsdma_read(hsdma, HSDMA_REG_INFO), mtk_hsdma_read(hsdma, HSDMA_REG_GLO_CFG),@@ -243,9 +243,9 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma, tx_desc = &chan->tx_ring[i]; rx_desc = &chan->rx_ring[i]; -dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, " \ +dev_dbg (hsdma->ddev.dev,"%d tx addr0: %08x, flags %08x, " "tx addr1: %08x, rx addr0 %08x, flags %08x\n" , - i, tx_desc->addr0, tx_desc->flags, \ + i, tx_desc->addr0, tx_desc->flags, tx_desc->addr1, rx_desc->addr0, rx_desc->flags); } } --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191028051237.3row7xnbr6pgn4bp%40linux-kernel-dev.