Skip to contentSkip to conversation

net: aquantia: fix error handling in aq_ptp_poll

PATCH Applied Gustavo A. R. Silva 3 participants 3 messages Oct 28, 2019 – Oct 29, 2019

Subsystems (4)
Networking Network drivers Aquantia Ethernet driver (atlantic) Aquantia Ethernet driver PTP
lore
Share & tools
lore

Gustavo A. R. Silva

author
#0 lore raw

PATCH 1/1 net: aquantia: fix error handling in aq_ptp_poll

Fix currenty ignored returned error by properly checking *err* after calling aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill().

Addresses-Coverity-ID: 1487357 ("Unused value")

Fixes 04a1839950d9 ("net: aquantia: implement data PTP datapath")
Signed-off-by Gustavo A. R. Silva <[email protected]>
---
 drivers/net/ethernet/aquantia/atlantic/aq_ptp.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/net/ethernet/aquantia/atlantic/aq_ptp.c +2 -0
index 3ec08415e53e..92b666f7d242 100644
@@ -678,6 +678,8 @@ static int aq_ptp_poll(struct napi_struct *napi, int budget)
 
 		err = aq_nic->aq_hw_ops->hw_ring_hwts_rx_fill(aq_nic->aq_hw,
 							      &aq_ptp->hwts_rx);
+		if (err < 0)
+			goto err_exit;
 
 		was_cleaned = true;
 	}
Signature · 1 line
2.23.0