Skip to contentSkip to conversation

pci: strengthen requirement of the correct subsystem id

PATCH In review Michael S. Tsirkin 3 participants 6 messages Oct 28, 2019 – Nov 27, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pci: strengthen requirement of the correct subsystem id

If a hardware implementation of virtio does not have the correct subsystem id, then drivers can't report ir properly, or detect and work around bugs. Change the requirement from MAY to SHOULD.

We can't make it a MUST since we did not require this historically.

---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
content.tex +1 -1
index 4bcb728..8f1518c 100644
@@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
 For example, the network card device with the Virtio Device ID 1
 has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
 
-The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
+The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
 the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
 
 Non-transitional devices SHOULD have a PCI Device ID in the range
Signature · 7 lines
MST


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
#1 lore raw
Quoted 9 lines · Michael S. Tsirkin

If a hardware implementation of virtio does not have the correct subsystem id, then drivers can't report ir properly, or detect and work around bugs. Change the requirement from MAY to SHOULD.

We can't make it a MUST since we did not require this historically.

Quoted 25 lines
---
 content.tex | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
content.tex +1 -1
index 4bcb728..8f1518c 100644
@@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
 For example, the network card device with the Virtio Device ID 1
 has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
 
-The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
+The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
 the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
 
 Non-transitional devices SHOULD have a PCI Device ID in the range
Signature · 7 lines
MST


---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php

#2 lore raw
In reply to Michael S. Tsirkin
Quoted 3 lines · Michael S. Tsirkin

If a hardware implementation of virtio does not have the correct subsystem id, then drivers can't report ir properly, or detect and work around bugs.

s/ir/it.

Jan

Quoted 24 lines

Change the requirement from MAY to SHOULD.

We can't make it a MUST since we did not require this historically.

---
  content.tex | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
content.tex +1 -1
index 4bcb728..8f1518c 100644
@@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
  For example, the network card device with the Virtio Device ID 1
  has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
 
-The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
+The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
  the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
 
  Non-transitional devices SHOULD have a PCI Device ID in the range
Signature · 6 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that generates this mail.  Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php 
#3 lore raw
Quoted 15 lines · Jan Kiszka
Quoted 3 lines · Michael S. Tsirkin

If a hardware implementation of virtio does not have the correct subsystem id, then drivers can't report ir properly, or detect and work around bugs.

s/ir/it.

Jan

Quoted 6 lines

Change the requirement from MAY to SHOULD.

We can't make it a MUST since we did not require this historically.

One thing I noticed is that for transitional devices, windows drivers bind to a specific vendor id. I guess we need to make this SHOULD for non-transitional only?

Quoted 4 lines
Quoted 4 lines
---
  content.tex | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 12 lines
content.tex +1 -1
index 4bcb728..8f1518c 100644
@@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
  For example, the network card device with the Virtio Device ID 1
  has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
-The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
+The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
  the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
  Non-transitional devices SHOULD have a PCI Device ID in the range
 
Signature · 2 lines
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php

#4 lore raw
Quoted 15 lines · On Mon, 25 Nov 2019 03:22:13 -0500 "Michael S. Tsirkin" <[email protected]> wrote:
Quoted 14 lines · Jan Kiszka
Quoted 3 lines · Michael S. Tsirkin

If a hardware implementation of virtio does not have the correct subsystem id, then drivers can't report ir properly, or detect and work around bugs.

s/ir/it.

Jan

Quoted 5 lines

Change the requirement from MAY to SHOULD.

We can't make it a MUST since we did not require this historically.

Quoted 6 lines
Quoted 1 line
Quoted 1 line

One thing I noticed is that for transitional devices, windows drivers bind to a specific vendor id. I guess we need to make this SHOULD for non-transitional only?

So, they have different binding behaviour for transitional vs non-transitional devices? Or transitional vs non-transitional drivers?

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

---
  content.tex | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines
Quoted 11 lines

content.tex \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov · line 566

Quoted 11 lines
content.tex +1 -1
index 4bcb728..8f1518c 100644
@@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
  For example, the network card device with the Virtio Device ID 1
  has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
-The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
+The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
  the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
  Non-transitional devices SHOULD have a PCI Device ID in the range

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php

#5 lore raw
Quoted 21 lines · Cornelia Huck
Quoted 18 lines · On Mon, 25 Nov 2019 03:22:13 -0500 "Michael S. Tsirkin" <[email protected]> wrote:
Quoted 15 lines · Jan Kiszka
Quoted 3 lines · Michael S. Tsirkin

If a hardware implementation of virtio does not have the correct subsystem id, then drivers can't report ir properly, or detect and work around bugs.

s/ir/it.

Jan

Quoted 6 lines

Change the requirement from MAY to SHOULD.

We can't make it a MUST since we did not require this historically.

Quoted 6 lines
Quoted 3 lines

One thing I noticed is that for transitional devices, windows drivers bind to a specific vendor id. I guess we need to make this SHOULD for non-transitional only?

So, they have different binding behaviour for transitional vs non-transitional devices? Or transitional vs non-transitional drivers?

Transitional vs non-transitional have different IDs, sure. That's in the spec.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

---
  content.tex | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 16 lines
Quoted 11 lines
Quoted 11 lines

content.tex \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov · line 566

Quoted 11 lines
content.tex +1 -1
index 4bcb728..8f1518c 100644
@@ -562,7 +562,7 @@ \subsection{PCI Device Discovery}\label{sec:Virtio Transport Options / Virtio Ov
  For example, the network card device with the Virtio Device ID 1
  has the PCI Device ID 0x1041 or the Transitional PCI Device ID 0x1000.
-The PCI Subsystem Vendor ID and the PCI Subsystem Device ID MAY reflect
+The PCI Subsystem Vendor ID and the PCI Subsystem Device ID SHOULD reflect
  the PCI Vendor and Device ID of the environment (for informational purposes by the driver).
  Non-transitional devices SHOULD have a PCI Device ID in the range

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]

---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php