Skip to contentSkip to conversation

net/bnxt: don't log at error level on flow creation

PATCH In review Stephen Hemminger 2 participants 3 messages Oct 28, 2019 – Oct 31, 2019 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/bnxt: don't log at error level on flow creation

Creating a flow is a normal event; should not be logged at error level.

Fixes 5c1171c97216 ("net/bnxt: refactor filter/flow")
---
 drivers/net/bnxt/bnxt_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_flow.c +1 -1
index cad232aba7da..8f386cdf1331 100644
@@ -1758,7 +1758,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
 		}
 
 		STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
-		PMD_DRV_LOG(ERR, "Successfully created flow.\n");
+		PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
 		STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
 		bnxt_release_flow_lock(bp);
 		return flow;
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Stephen Hemminger

Creating a flow is a normal event; should not be logged at error level.

Fixes 5c1171c97216 ("net/bnxt: refactor filter/flow")
Quoted 21 lines
---
 drivers/net/bnxt/bnxt_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_flow.c +1 -2
index cad232aba7da..8f386cdf1331 100644
@@ -1758,7 +1758,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
                }
 
                STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
-               PMD_DRV_LOG(ERR, "Successfully created flow.\n");
+               PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
                STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
                bnxt_release_flow_lock(bp);
                return flow;
--

2.20.1

#2 lore raw
Quoted 5 lines · Ajit Khaparde

On Mon, Oct 28, 2019 at 9:53 AM Stephen Hemminger < [email protected]> wrote:

Quoted 7 lines
Quoted 5 lines

Creating a flow is a normal event; should not be logged at error level.

Fixes 5c1171c97216 ("net/bnxt: refactor filter/flow")

Patch applied to dpdk-next-net-brcm.

Quoted 23 lines
Quoted 23 lines

---
 drivers/net/bnxt/bnxt_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_flow.c +1 -2
index cad232aba7da..8f386cdf1331 100644
@@ -1758,7 +1758,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
                }
 
                STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
-               PMD_DRV_LOG(ERR, "Successfully created flow.\n");
+               PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
                STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
                bnxt_release_flow_lock(bp);
                return flow;
--

2.20.1