Skip to contentSkip to conversation

net: wireless: rtlwifi: rtl8192c:Drop condition with no effect

PATCH In review Saurav Girepunje 2 participants 2 messages Oct 28, 2019 – Oct 29, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: wireless: rtlwifi: rtl8192c:Drop condition with no effect

As the "else if" and "else" branch body are identical the condition has no effect. So drop the "else if" condition.

---
 drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/wireless/realtek/rtlwifi/rtl8192c/dm_common.c +0 -2
index f2908ee5f860..4bef237f488d 100644
@@ -1649,8 +1649,6 @@ static void rtl92c_bt_ant_isolation(struct ieee80211_hw *hw, u8 tmp1byte)
 			    (rtlpriv->btcoexist.bt_rssi_state &
 			    BT_RSSI_STATE_SPECIAL_LOW)) {
 			rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, 0xa0);
-		} else if (rtlpriv->btcoexist.bt_service == BT_PAN) {
-			rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, tmp1byte);
 		} else {
 			rtl_write_byte(rtlpriv, REG_GPIO_MUXCFG, tmp1byte);
 		}
Signature · 1 line
2.20.1
#1 lore raw
Quoted 4 lines · Saurav Girepunje

As the "else if" and "else" branch body are identical the condition has no effect. So drop the "else if" condition.

Thanks, I see these patches in patchwork now.

But then you submit a new version of a patch, please mark it as "[PATCH v2]":

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#patch_version_missing

This is for future submissions, no need to resend because of this.

Signature · 1 line
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches