Skip to contentSkip to conversation

b43: Fix use true/false for bool type

PATCH In review Saurav Girepunje 4 participants 6 messages Oct 28, 2019 – Oct 31, 2019

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 b43: Fix use true/false for bool type

use true/false on bool type variable assignment.

---
 drivers/net/wireless/broadcom/b43/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/broadcom/b43/main.c +3 -3
index b85603e91c7a..39da1a4c30ac 100644
@@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)
 			else
 				err = b43_dma_tx(dev, skb);
 			if (err == -ENOSPC) {
-				wl->tx_queue_stopped[queue_num] = 1;
+				wl->tx_queue_stopped[queue_num] = true;
 				ieee80211_stop_queue(wl->hw, queue_num);
 				skb_queue_head(&wl->tx_queue[queue_num], skb);
 				break;
@@ -3611,7 +3611,7 @@ static void b43_tx_work(struct work_struct *work)
 		}
 
 		if (!err)
-			wl->tx_queue_stopped[queue_num] = 0;
+			wl->tx_queue_stopped[queue_num] = false;
 	}
 
 #if B43_DEBUG
@@ -5603,7 +5603,7 @@ static struct b43_wl *b43_wireless_init(struct b43_bus_dev *dev)
 	/* Initialize queues and flags. */
 	for (queue_num = 0; queue_num < B43_QOS_QUEUE_NUM; queue_num++) {
 		skb_queue_head_init(&wl->tx_queue[queue_num]);
-		wl->tx_queue_stopped[queue_num] = 0;
+		wl->tx_queue_stopped[queue_num] = false;
 	}
 
 	snprintf(chip_name, ARRAY_SIZE(chip_name),
Signature · 1 line
2.20.1
#1 lore raw

Hi Saurav,

thanks for your patch.

Quoted 3 lines · Saurav Girepunje

use true/false on bool type variable assignment.

This does not seem to cover the case in dma.c, which seems to want fixing for the sake of consistency.

Also, I wonder why bools rather than a bitmask was chosen for this field, it seems rather space intensive in its current form.

Quoted 38 lines
---
 drivers/net/wireless/broadcom/b43/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/broadcom/b43/main.c +3 -3
index b85603e91c7a..39da1a4c30ac 100644
@@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)
 			else
 				err = b43_dma_tx(dev, skb);
 			if (err == -ENOSPC) {
-				wl->tx_queue_stopped[queue_num] = 1;
+				wl->tx_queue_stopped[queue_num] = true;
 				ieee80211_stop_queue(wl->hw, queue_num);
 				skb_queue_head(&wl->tx_queue[queue_num], skb);
 				break;
@@ -3611,7 +3611,7 @@ static void b43_tx_work(struct work_struct *work)
 		}
 
 		if (!err)
-			wl->tx_queue_stopped[queue_num] = 0;
+			wl->tx_queue_stopped[queue_num] = false;
 	}
 
 #if B43_DEBUG
@@ -5603,7 +5603,7 @@ static struct b43_wl *b43_wireless_init(struct b43_bus_dev *dev)
 	/* Initialize queues and flags. */
 	for (queue_num = 0; queue_num < B43_QOS_QUEUE_NUM; queue_num++) {
 		skb_queue_head_init(&wl->tx_queue[queue_num]);
-		wl->tx_queue_stopped[queue_num] = 0;
+		wl->tx_queue_stopped[queue_num] = false;
 	}
 
 	snprintf(chip_name, ARRAY_SIZE(chip_name),
Signature · 1 line
2.20.1
#2 lore raw
Quoted 2 lines · Simon Horman

I wonder why bools rather than a bitmask was chosen
for this field, it seems rather space intensive in its current form.

4 bools is not intensive.

Quoted 1 line

drivers/net/wireless/broadcom/b43/main.c

Quoted 1 line
drivers/net/wireless/broadcom/b43/main.c +0 -0

[]

Quoted 1 line

drivers/net/wireless/broadcom/b43/main.c static void b43_tx_work(struct work_struct *work)

Quoted 1 line
drivers/net/wireless/broadcom/b43/main.c +0 -0
@@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)

[]

Quoted 2 lines
Quoted 2 lines
drivers/net/wireless/broadcom/b43/main.c +1 -1
-				wl->tx_queue_stopped[queue_num] = 1;
+				wl->tx_queue_stopped[queue_num] = true;
#3 lore raw
Quoted 5 lines · Joe Perches
Quoted 2 lines · Simon Horman

I wonder why bools rather than a bitmask was chosen
for this field, it seems rather space intensive in its current form.

4 bools is not intensive.

Thanks, point taken.

Quoted 9 lines
Quoted 2 lines

drivers/net/wireless/broadcom/b43/main.c

Quoted 2 lines
drivers/net/wireless/broadcom/b43/main.c +0 -0

[]

Quoted 1 line

drivers/net/wireless/broadcom/b43/main.c static void b43_tx_work(struct work_struct *work)

Quoted 1 line
drivers/net/wireless/broadcom/b43/main.c +0 -0
@@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)

[]

Quoted 2 lines
Quoted 2 lines
drivers/net/wireless/broadcom/b43/main.c +1 -1
-				wl->tx_queue_stopped[queue_num] = 1;
+				wl->tx_queue_stopped[queue_num] = true;
#4 lore raw
In reply to Simon Horman
Quoted 11 lines · Simon Horman

Hi Saurav,

thanks for your patch.

Quoted 3 lines · Saurav Girepunje

use true/false on bool type variable assignment.

This does not seem to cover the case in dma.c, which seems to want fixing for the sake of consistency.

I now see this handled in a separate patch, sorry for the noise.

Quoted 42 lines

Also, I wonder why bools rather than a bitmask was chosen for this field, it seems rather space intensive in its current form.

Quoted 38 lines
---
 drivers/net/wireless/broadcom/b43/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/wireless/broadcom/b43/main.c +3 -3
index b85603e91c7a..39da1a4c30ac 100644
@@ -3600,7 +3600,7 @@ static void b43_tx_work(struct work_struct *work)
 			else
 				err = b43_dma_tx(dev, skb);
 			if (err == -ENOSPC) {
-				wl->tx_queue_stopped[queue_num] = 1;
+				wl->tx_queue_stopped[queue_num] = true;
 				ieee80211_stop_queue(wl->hw, queue_num);
 				skb_queue_head(&wl->tx_queue[queue_num], skb);
 				break;
@@ -3611,7 +3611,7 @@ static void b43_tx_work(struct work_struct *work)
 		}
 
 		if (!err)
-			wl->tx_queue_stopped[queue_num] = 0;
+			wl->tx_queue_stopped[queue_num] = false;
 	}
 
 #if B43_DEBUG
@@ -5603,7 +5603,7 @@ static struct b43_wl *b43_wireless_init(struct b43_bus_dev *dev)
 	/* Initialize queues and flags. */
 	for (queue_num = 0; queue_num < B43_QOS_QUEUE_NUM; queue_num++) {
 		skb_queue_head_init(&wl->tx_queue[queue_num]);
-		wl->tx_queue_stopped[queue_num] = 0;
+		wl->tx_queue_stopped[queue_num] = false;
 	}
 
 	snprintf(chip_name, ARRAY_SIZE(chip_name),
Signature · 1 line
2.20.1
#5 lore raw

Re: [PATCH] b43: main: Fix use true/false for bool type

In reply to Saurav Girepunje
Quoted 3 lines · Saurav Girepunje

use true/false on bool type variable assignment.

Patch applied to wireless-drivers-next.git, thanks.

6db774c17250 b43: main: Fix use true/false for bool type

Signature · 3 lines
https://patchwork.kernel.org/patch/11216303/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches