pci: controller: dwc: Remove dev_err use after platform_get_irq
Subsystems (4)
PATCH 1/1 pci: controller: dwc: Remove dev_err use after platform_get_irq
Don't need dev_err() messages when platform_get_irq() fails now that platform_get_irq() prints an error message itself when something goes wrong.
--- drivers/pci/controller/dwc/pci-exynos.c | 2 -- 1 file changed, 2 deletions(-)
drivers/pci/controller/dwc/pci-exynos.c +0 -2
@@ -403,7 +403,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep, pp->irq =platform_get_irq (pdev,1 );if (pp->irq <0 ) { -dev_err (dev,"failed to get irq\n" );return pp->irq; } ret = devm_request_irq(dev, pp->irq, exynos_pcie_irq_handler,
@@ -416,7 +415,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,if (IS_ENABLED (CONFIG_PCI_MSI )) { pp->msi_irq =platform_get_irq (pdev,0 );if (pp->msi_irq <0 ) { -dev_err (dev,"failed to get msi irq\n" );return pp->msi_irq; } }
Signature · 1 line
2.20.1
Please run "git log --oneline drivers/pci/controller/dwc/pci-exynos.c" and make your subject line match, e.g.,
PCI: exynos: Remove dev_err() usage after platform_get_irq()
The body of that was copied from similar commits like:
fb5a35dbee8d pwm: Remove dev_err() usage after platform_get_irq() 9a7957d0c955 mmc: Remove dev_err() usage after platform_get_irq() 1df217868178 tty: Remove dev_err() usage after platform_get_irq()
It's nice when similar commits have similar subject lines.
In fact, this whole thing has been approached before:
https://lore.kernel.org/lkml/[email protected]/
That patch would have fixed many similar issues in PCI, but I don't know what happened to it. Would you mind resurrecting that and fixing the minor issues so we can do everything in PCI at once?
Quoted 32 lines · Saurav Girepunje
Don't need
dev_err()messages whenplatform_get_irq()fails now thatplatform_get_irq()prints an error message itself when something goes wrong.Signed-off-by Saurav Girepunje <[email protected]>--- drivers/pci/controller/dwc/pci-exynos.c | 2 -- 1 file changed, 2 deletions(-)drivers/pci/controller/dwc/pci-exynos.c +0
-2@@ -403,7 +403,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep, pp->irq =platform_get_irq (pdev,1 );if (pp->irq <0 ) { -dev_err (dev,"failed to get irq\n" );return pp->irq; } ret = devm_request_irq(dev, pp->irq, exynos_pcie_irq_handler,@@ -416,7 +415,6 @@ static int __init exynos_add_pcie_port(struct exynos_pcie *ep,if (IS_ENABLED (CONFIG_PCI_MSI )) { pp->msi_irq =platform_get_irq (pdev,0 );if (pp->msi_irq <0 ) { -dev_err (dev,"failed to get msi irq\n" );return pp->msi_irq; } }Signature · 1 line
2.20.1