Skip to contentSkip to conversation

dma-debug: add a schedule point in debug_dma_dump_mappings()

PATCH Applied Eric Dumazet 2 participants 2 messages Oct 28, 2019 – Oct 30, 2019 DMA mapping helpers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dma-debug: add a schedule point in debug_dma_dump_mappings()

debug_dma_dump_mappings() can take a lot of cpu cycles :

lpk43:/# time wc -l /sys/kernel/debug/dma-api/dump
163435 /sys/kernel/debug/dma-api/dump

real 0m0.463s
user 0m0.003s
sys 0m0.459s

Let's add a cond_resched() to avoid holding cpu for too long.

Cc Corentin Labbe <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Marek Szyprowski <[email protected]>
---
 kernel/dma/debug.c | 1 +
 1 file changed, 1 insertion(+)
kernel/dma/debug.c +1 -0
index 099002d84f466af0a8e421d035ac8eb119e08bd8..4ad74f5987ea9e95f9bb5e2d1592254e367d24fb 100644
@@ -420,6 +420,7 @@ void debug_dma_dump_mappings(struct device *dev)
 		}
 
 		spin_unlock_irqrestore(&bucket->lock, flags);
+		cond_resched();
 	}
 }
 
Signature · 1 line
2.24.0.rc0.303.g954a862665-goog