Skip to contentSkip to conversation

hwmon: (ina3221) Fix read timeout issue

PATCH Applied Nicolin Chen 2 participants 2 messages Oct 22, 2019 – Oct 29, 2019 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hwmon: (ina3221) Fix read timeout issue

After introducing "samples" to the calculation of wait time, the driver might timeout at the regmap_field_read_poll_timeout call, because the wait time could be longer than the 100000 usec limit due to a large "samples" number.

So this patch sets the timeout limit to 2 times of the wait time in order to fix this issue.

Fixes 5c090abf945b ("hwmon: (ina3221) Add averaging mode support")
---
 drivers/hwmon/ina3221.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/ina3221.c +1 -1
index ef37479991be..f335d0cb0c77 100644
@@ -213,7 +213,7 @@ static inline int ina3221_wait_for_data(struct ina3221_data *ina)
 
 	/* Polling the CVRF bit to make sure read data is ready */
 	return regmap_field_read_poll_timeout(ina->fields[F_CVRF],
-					      cvrf, cvrf, wait, 100000);
+					      cvrf, cvrf, wait, wait * 2);
 }
 
 static int ina3221_read_value(struct ina3221_data *ina, unsigned int reg,
Signature · 1 line
2.17.1
maintainer Applied
#1 lore raw
Quoted 10 lines · Nicolin Chen

After introducing "samples" to the calculation of wait time, the driver might timeout at the regmap_field_read_poll_timeout call, because the wait time could be longer than the 100000 usec limit due to a large "samples" number.

So this patch sets the timeout limit to 2 times of the wait time in order to fix this issue.

Fixes 5c090abf945b ("hwmon: (ina3221) Add averaging mode support")

Applied.

Thanks,
Guenter

Quoted 17 lines
---
 drivers/hwmon/ina3221.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/hwmon/ina3221.c +1 -1
index ef37479991be..f335d0cb0c77 100644
@@ -213,7 +213,7 @@ static inline int ina3221_wait_for_data(struct ina3221_data *ina)
 
 	/* Polling the CVRF bit to make sure read data is ready */
 	return regmap_field_read_poll_timeout(ina->fields[F_CVRF],
-					      cvrf, cvrf, wait, 100000);
+					      cvrf, cvrf, wait, wait * 2);
 }
 
 static int ina3221_read_value(struct ina3221_data *ina, unsigned int reg,