Skip to contentSkip to conversation

pstore: make 'pstore_choose_compression' static

PATCH In review Ben Dooks (Codethink) 2 participants 2 messages Oct 16, 2019 – Oct 29, 2019 Pstore filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pstore: make 'pstore_choose_compression' static

The pstore_choose_compression function is not exported so make it static to avoid the following sparse warning:

fs/pstore/platform.c:796:13: warning: symbol 'pstore_choose_compression' was not declared. Should it be static?

---
Cc: Kees Cook <[email protected]>
Cc: Anton Vorontsov <[email protected]>
Cc: Colin Cross <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: [email protected]

---
 fs/pstore/platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/pstore/platform.c +1 -1
index 3d7024662d29..d896457e7c11 100644
@@ -793,7 +793,7 @@ static void pstore_timefunc(struct timer_list *unused)
 			  jiffies + msecs_to_jiffies(pstore_update_ms));
 }
 
-void __init pstore_choose_compression(void)
+static void __init pstore_choose_compression(void)
 {
 	const struct pstore_zbackend *step;
 
Signature · 1 line
2.23.0
#1 lore raw
Quoted 6 lines · Ben Dooks (Codethink)

The pstore_choose_compression function is not exported so make it static to avoid the following sparse warning:

fs/pstore/platform.c:796:13: warning: symbol 'pstore_choose_compression' was not declared. Should it be static?

Oops! Yes, thank you. Applied to my for-next/pstore branch. :)

-Kees

Quoted 26 lines

---
Cc: Kees Cook <[email protected]>
Cc: Anton Vorontsov <[email protected]>
Cc: Colin Cross <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: [email protected]

---
 fs/pstore/platform.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/pstore/platform.c +1 -1
index 3d7024662d29..d896457e7c11 100644
@@ -793,7 +793,7 @@ static void pstore_timefunc(struct timer_list *unused)
 			  jiffies + msecs_to_jiffies(pstore_update_ms));
 }
 
-void __init pstore_choose_compression(void)
+static void __init pstore_choose_compression(void)
 {
 	const struct pstore_zbackend *step;
 
Signature · 1 line
2.23.0
Signature · 1 line
Kees Cook