Skip to contentSkip to conversation

drm/i915: define i915_ggtt_has_aperture

PATCH Superseded Matthew Auld 4 participants 24 messages Oct 29, 2019

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/7 drm/i915: define i915_ggtt_has_aperture

From: Daniele Ceraolo Spurio <[email protected]>

The following patches in the series will use it to avoid certain operations when the mappable aperture is not available in HW.

---
 drivers/gpu/drm/i915/i915_gem_gtt.h | 5 +++++
 1 file changed, 5 insertions(+)
drivers/gpu/drm/i915/i915_gem_gtt.h +5 -0
index f074f1de66e8..28044449aa41 100644
@@ -575,6 +575,11 @@ void i915_ggtt_disable_guc(struct i915_ggtt *ggtt);
 int i915_init_ggtt(struct drm_i915_private *dev_priv);
 void i915_ggtt_driver_release(struct drm_i915_private *dev_priv);
 
+static inline bool i915_ggtt_has_aperture(struct i915_ggtt *ggtt)
+{
+	return ggtt->mappable_end > 0;
+}
+
 int i915_ppgtt_init_hw(struct intel_gt *gt);
 
 struct i915_ppgtt *i915_ppgtt_create(struct drm_i915_private *dev_priv);
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/7 drm/i915: do not map aperture if it is not available.

From: Daniele Ceraolo Spurio <[email protected]>

Skip both setup and cleanup of the aperture mapping if the HW doesn't have an aperture bar.

---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 31 ++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +19 -12
index eebc7fee81e2..73dad8c6acc2 100644
@@ -2770,7 +2770,9 @@ static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)
 	i915_address_space_fini(&ggtt->vm);
 
 	arch_phys_wc_del(ggtt->mtrr);
-	io_mapping_fini(&ggtt->iomap);
+
+	if (ggtt->iomap.size)
+		io_mapping_fini(&ggtt->iomap);
 }
 
 /**
@@ -2997,10 +2999,12 @@ static int gen8_gmch_probe(struct i915_ggtt *ggtt)
 	int err;
 
 	/* TODO: We're not aware of mappable constraints on gen8 yet */
-	ggtt->gmadr =
-		(struct resource) DEFINE_RES_MEM(pci_resource_start(pdev, 2),
-						 pci_resource_len(pdev, 2));
-	ggtt->mappable_end = resource_size(&ggtt->gmadr);
+	if (!IS_DGFX(dev_priv)) {
+		ggtt->gmadr =
+			(struct resource) DEFINE_RES_MEM(pci_resource_start(pdev, 2),
+							 pci_resource_len(pdev, 2));
+		ggtt->mappable_end = resource_size(&ggtt->gmadr);
+	}
 
 	err = pci_set_dma_mask(pdev, DMA_BIT_MASK(39));
 	if (!err)
@@ -3223,14 +3227,17 @@ static int ggtt_init_hw(struct i915_ggtt *ggtt)
 	if (!HAS_LLC(i915) && !HAS_PPGTT(i915))
 		ggtt->vm.mm.color_adjust = i915_ggtt_color_adjust;
 
-	if (!io_mapping_init_wc(&ggtt->iomap,
-				ggtt->gmadr.start,
-				ggtt->mappable_end)) {
-		ggtt->vm.cleanup(&ggtt->vm);
-		return -EIO;
-	}
+	if (ggtt->mappable_end) {
+		if (!io_mapping_init_wc(&ggtt->iomap,
+					ggtt->gmadr.start,
+					ggtt->mappable_end)) {
+			ggtt->vm.cleanup(&ggtt->vm);
+			return -EIO;
+		}
 
-	ggtt->mtrr = arch_phys_wc_add(ggtt->gmadr.start, ggtt->mappable_end);
+		ggtt->mtrr = arch_phys_wc_add(ggtt->gmadr.start,
+					      ggtt->mappable_end);
+	}
 
 	i915_ggtt_init_fences(ggtt);
 
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 2/7
#2 lore raw

Re: [PATCH 2/7] drm/i915: do not map aperture if it is not available.

Quoting Matthew Auld (2019-10-29 09:58:51)

Quoted 16 lines

From: Daniele Ceraolo Spurio <[email protected]>

Skip both setup and cleanup of the aperture mapping if the HW doesn't have an aperture bar.

---
 drivers/gpu/drm/i915/i915_gem_gtt.c | 31 ++++++++++++++++++-----------
 1 file changed, 19 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +0 -0
index eebc7fee81e2..73dad8c6acc2 100644

drivers/gpu/drm/i915/i915_gem_gtt.c static void ggtt_cleanup_hw(struct i915_ggtt *ggtt) · line 2775

Quoted 7 lines
drivers/gpu/drm/i915/i915_gem_gtt.c +3 -1
@@ -2770,7 +2770,9 @@ static void ggtt_cleanup_hw(struct i915_ggtt *ggtt)
        i915_address_space_fini(&ggtt->vm);
 
        arch_phys_wc_del(ggtt->mtrr);
-       io_mapping_fini(&ggtt->iomap);
+
+       if (ggtt->iomap.size)
+               io_mapping_fini(&ggtt->iomap);

Marginally annoying we had not made io_mapping_fini() nop-proof.

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

PATCH 3/7 drm/i915: set num_fence_regs to 0 if there is no aperture

In reply to Matthew Auld

From: Daniele Ceraolo Spurio <[email protected]>

We can't fence anything without aperture.

---
 drivers/gpu/drm/i915/i915_gem_fence_reg.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_gem_fence_reg.c +4 -2
index 321189e1b0f2..71efccfde122 100644
@@ -846,8 +846,10 @@ void i915_ggtt_init_fences(struct i915_ggtt *ggtt)
 
 	detect_bit_6_swizzle(ggtt);
 
-	if (INTEL_GEN(i915) >= 7 &&
-	    !(IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)))
+	if (!i915_ggtt_has_aperture(ggtt))
+		num_fences = 0;
+	else if (INTEL_GEN(i915) >= 7 &&
+		 !(IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)))
 		num_fences = 32;
 	else if (INTEL_GEN(i915) >= 4 ||
 		 IS_I945G(i915) || IS_I945GM(i915) ||
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 3/7
#4 lore raw

Re: [PATCH 3/7] drm/i915: set num_fence_regs to 0 if there is no aperture

Quoting Matthew Auld (2019-10-29 09:58:52)

Quoted 7 lines

From: Daniele Ceraolo Spurio <[email protected]>

We can't fence anything without aperture.

Neat.

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Re: [PATCH 3/7] drm/i915: set num_fence_regs to 0 if there is no aperture

In reply to Matthew Auld
Quoted 16 lines · Matthew Auld

From: Daniele Ceraolo Spurio <[email protected]>

We can't fence anything without aperture.

---
  drivers/gpu/drm/i915/i915_gem_fence_reg.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_gem_fence_reg.c +0 -0
index 321189e1b0f2..71efccfde122 100644

drivers/gpu/drm/i915/i915_gem_fence_reg.c void i915_ggtt_init_fences(struct i915_ggtt *ggtt) · line 849

Quoted 6 lines
drivers/gpu/drm/i915/i915_gem_fence_reg.c +1 -2
@@ -846,8 +846,10 @@ void i915_ggtt_init_fences(struct i915_ggtt *ggtt)
 
  	detect_bit_6_swizzle(ggtt);
 
-	if (INTEL_GEN(i915) >= 7 &&
-	    !(IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)))
+	if (!i915_ggtt_has_aperture(ggtt))

Daniel had mentioned that the fencing HW has been nerfed in gen12 and suggested settings num_fences to zero for all gen12+. Should we go directly with that?

Daniele

drivers/gpu/drm/i915/i915_gem_fence_reg.c void i915_ggtt_init_fences(struct i915_ggtt *ggtt) · line 855

Quoted 7 lines
drivers/gpu/drm/i915/i915_gem_fence_reg.c +3 -0
+		num_fences = 0;
+	else if (INTEL_GEN(i915) >= 7 &&
+		 !(IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)))
  		num_fences = 32;
  	else if (INTEL_GEN(i915) >= 4 ||
  		 IS_I945G(i915) || IS_I945GM(i915) ||

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Re: [PATCH 3/7] drm/i915: set num_fence_regs to 0 if there is no aperture

Quoting Daniele Ceraolo Spurio (2019-10-29 21:23:16)

Quoted 22 lines · Matthew Auld
Quoted 19 lines

From: Daniele Ceraolo Spurio <[email protected]>

We can't fence anything without aperture.

---
  drivers/gpu/drm/i915/i915_gem_fence_reg.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_gem_fence_reg.c +0 -0
index 321189e1b0f2..71efccfde122 100644
@@ -846,8 +846,10 @@ void i915_ggtt_init_fences(struct i915_ggtt *ggtt)
 
      detect_bit_6_swizzle(ggtt);
 
Quoted 7 lines

drivers/gpu/drm/i915/i915_gem_fence_reg.c void i915_ggtt_init_fences(struct i915_ggtt *ggtt) · line 849

Quoted 3 lines
drivers/gpu/drm/i915/i915_gem_fence_reg.c +1 -2
-     if (INTEL_GEN(i915) >= 7 &&
-         !(IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)))
+     if (!i915_ggtt_has_aperture(ggtt))

Daniel had mentioned that the fencing HW has been nerfed in gen12 and suggested settings num_fences to zero for all gen12+. Should we go directly with that?

Do fences exist, yes/no? If there are literally no fences forevermore... tgl begs to differ though.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

Re: [PATCH 3/7] drm/i915: set num_fence_regs to 0 if there is no aperture

Quoted 31 lines · Chris Wilson

Quoting Daniele Ceraolo Spurio (2019-10-29 21:23:16)

Quoted 22 lines · Matthew Auld
Quoted 19 lines

From: Daniele Ceraolo Spurio <[email protected]>

We can't fence anything without aperture.

---
   drivers/gpu/drm/i915/i915_gem_fence_reg.c | 6 ++++--
   1 file changed, 4 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_gem_fence_reg.c +0 -0
index 321189e1b0f2..71efccfde122 100644
@@ -846,8 +846,10 @@ void i915_ggtt_init_fences(struct i915_ggtt *ggtt)
 
       detect_bit_6_swizzle(ggtt);
 
Quoted 7 lines

drivers/gpu/drm/i915/i915_gem_fence_reg.c void i915_ggtt_init_fences(struct i915_ggtt *ggtt) · line 849

Quoted 3 lines
drivers/gpu/drm/i915/i915_gem_fence_reg.c +1 -2
-     if (INTEL_GEN(i915) >= 7 &&
-         !(IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)))
+     if (!i915_ggtt_has_aperture(ggtt))

Daniel had mentioned that the fencing HW has been nerfed in gen12 and suggested settings num_fences to zero for all gen12+. Should we go directly with that?

Quoted 4 lines

Do fences exist, yes/no? If there are literally no fences forevermore... tgl begs to differ though.
-Chris

The registers are there in the specs and I don't see any special notes about their usage. I'll leave it to Daniel to comment on the capability reduction he mentioned. Not a blocker for this patch in the meantime.

Daniele

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

PATCH 4/7 drm/i915: error capture with no ggtt slot

In reply to Matthew Auld

From: Daniele Ceraolo Spurio <[email protected]>

If the aperture is not available in HW we can't use a ggtt slot and wc copy, so fall back to regular kmap.

---
 drivers/gpu/drm/i915/i915_gem_gtt.c   | 19 ++++----
 drivers/gpu/drm/i915/i915_gpu_error.c | 66 ++++++++++++++++++++++-----
 2 files changed, 65 insertions(+), 20 deletions(-)
drivers/gpu/drm/i915/i915_gem_gtt.c +11 -8
index 73dad8c6acc2..ba047e329028 100644
@@ -2661,7 +2661,8 @@ static void ggtt_release_guc_top(struct i915_ggtt *ggtt)
 static void cleanup_init_ggtt(struct i915_ggtt *ggtt)
 {
 	ggtt_release_guc_top(ggtt);
-	drm_mm_remove_node(&ggtt->error_capture);
+	if (drm_mm_node_allocated(&ggtt->error_capture))
+		drm_mm_remove_node(&ggtt->error_capture);
 }
 
 static int init_ggtt(struct i915_ggtt *ggtt)
@@ -2692,13 +2693,15 @@ static int init_ggtt(struct i915_ggtt *ggtt)
 	if (ret)
 		return ret;
 
-	/* Reserve a mappable slot for our lockless error capture */
-	ret = drm_mm_insert_node_in_range(&ggtt->vm.mm, &ggtt->error_capture,
-					  PAGE_SIZE, 0, I915_COLOR_UNEVICTABLE,
-					  0, ggtt->mappable_end,
-					  DRM_MM_INSERT_LOW);
-	if (ret)
-		return ret;
+	if (ggtt->mappable_end) {
+		/* Reserve a mappable slot for our lockless error capture */
+		ret = drm_mm_insert_node_in_range(&ggtt->vm.mm, &ggtt->error_capture,
+						  PAGE_SIZE, 0, I915_COLOR_UNEVICTABLE,
+						  0, ggtt->mappable_end,
+						  DRM_MM_INSERT_LOW);
+		if (ret)
+			return ret;
+	}
 
 	/*
 	 * The upper portion of the GuC address space has a sizeable hole
drivers/gpu/drm/i915/i915_gpu_error.c +54 -12

119 lines not on this page · raw message

Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 4/7
#9 lore raw

Re: [PATCH 4/7] drm/i915: error capture with no ggtt slot

Quoting Matthew Auld (2019-10-29 09:58:53)

Quoted 9 lines

From: Daniele Ceraolo Spurio <[email protected]>

If the aperture is not available in HW we can't use a ggtt slot and wc copy, so fall back to regular kmap.

---

drivers/gpu/drm/i915/i915_gpu_error.c i915_error_object_create(struct drm_i915_private *i915, · line 1023

Quoted 9 lines
drivers/gpu/drm/i915/i915_gpu_error.c +9 -0
+       } else if (i915_gem_object_is_lmem(vma->obj)) {
+               struct intel_memory_region *mem = vma->obj->mm.region;
+               dma_addr_t dma;
+
+               for_each_sgt_daddr(dma, iter, vma->pages) {
+                       void __iomem *s;
+
+                       s = io_mapping_map_atomic_wc(&mem->iomap, dma);
+                       ret = compress_page(compress, s, dst);

Just a (void __force *)s required here.

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#10 lore raw

PATCH 5/7 drm/i915: Don't try to place HWS in non-existing mappable region

In reply to Matthew Auld

From: Michal Wajdeczko <[email protected]>

HWS placement restrictions can't just rely on HAS_LLC flag.

---
 drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/intel_engine_cs.c +1 -1
index 9cc1ea6519ec..355523114c71 100644
@@ -528,7 +528,7 @@ static int pin_ggtt_status_page(struct intel_engine_cs *engine,
 	unsigned int flags;
 
 	flags = PIN_GLOBAL;
-	if (!HAS_LLC(engine->i915))
+	if (!HAS_LLC(engine->i915) && i915_ggtt_has_aperture(engine->gt->ggtt))
 		/*
 		 * On g33, we cannot place HWS above 256MiB, so
 		 * restrict its pinning to the low mappable arena.
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Acked-by on v1 5/7
#11 lore raw

Re: [PATCH 5/7] drm/i915: Don't try to place HWS in non-existing mappable region

Quoting Matthew Auld (2019-10-29 09:58:54)

Quoted 16 lines

From: Michal Wajdeczko <[email protected]>

HWS placement restrictions can't just rely on HAS_LLC flag.

---
 drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/intel_engine_cs.c +0 -0
index 9cc1ea6519ec..355523114c71 100644

drivers/gpu/drm/i915/gt/intel_engine_cs.c static int pin_ggtt_status_page(struct intel_engine_cs *engine, · line 534

Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_engine_cs.c +1 -1
@@ -528,7 +528,7 @@ static int pin_ggtt_status_page(struct intel_engine_cs *engine,
        unsigned int flags;
 
        flags = PIN_GLOBAL;
-       if (!HAS_LLC(engine->i915))
+       if (!HAS_LLC(engine->i915) && i915_ggtt_has_aperture(engine->gt->ggtt))
                /*
                 * On g33, we cannot place HWS above 256MiB, so
                 * restrict its pinning to the low mappable arena.

How we will laugh if it turns out future HW cannot handle having the HWSP placed anywhere! :)

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#12 lore raw

PATCH 6/7 drm/i915: don't allocate the ring in stolen if we lack aperture

In reply to Matthew Auld

Since we have no way access it from the CPU. For such cases just fallback to internal objects.

---
 drivers/gpu/drm/i915/gt/intel_ring.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/intel_ring.c +3 -1
index fa01c1407760..ece20504d240 100644
@@ -108,7 +108,9 @@ static struct i915_vma *create_ring_vma(struct i915_ggtt *ggtt, int size)
 	struct drm_i915_gem_object *obj;
 	struct i915_vma *vma;
 
-	obj = i915_gem_object_create_stolen(i915, size);
+	obj = ERR_PTR(-ENODEV);
+	if (i915_ggtt_has_aperture(ggtt))
+		obj = i915_gem_object_create_stolen(i915, size);
 	if (IS_ERR(obj))
 		obj = i915_gem_object_create_internal(i915, size);
 	if (IS_ERR(obj))
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 6/7
#13 lore raw

Re: [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

Quoting Matthew Auld (2019-10-29 09:58:55)

Quoted 4 lines

Since we have no way access it from the CPU. For such cases just fallback to internal objects.

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#14 lore raw

Re: [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

In reply to Matthew Auld
Quoted 3 lines · Matthew Auld

Since we have no way access it from the CPU. For such cases just fallback to internal objects.

Since the problem is not limited to rings but it applies to all stolen objects, wouldn't it be better to just skip the stolen initialization or return an error from i915_gem_object_create_stolen()?

Daniele

Quoted 11 lines
---
  drivers/gpu/drm/i915/gt/intel_ring.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/gt/intel_ring.c +0 -0
index fa01c1407760..ece20504d240 100644

drivers/gpu/drm/i915/gt/intel_ring.c static struct i915_vma *create_ring_vma(struct i915_ggtt *ggtt, int size) · line 116

Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_ring.c +3 -1
@@ -108,7 +108,9 @@ static struct i915_vma *create_ring_vma(struct i915_ggtt *ggtt, int size)
  	struct drm_i915_gem_object *obj;
  	struct i915_vma *vma;
 
-	obj = i915_gem_object_create_stolen(i915, size);
+	obj = ERR_PTR(-ENODEV);
+	if (i915_ggtt_has_aperture(ggtt))
+		obj = i915_gem_object_create_stolen(i915, size);
  	if (IS_ERR(obj))
  		obj = i915_gem_object_create_internal(i915, size);
  	if (IS_ERR(obj))

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#15 lore raw

Re: [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

Quoting Daniele Ceraolo Spurio (2019-10-29 21:46:46)

Quoted 10 lines · Matthew Auld
Quoted 3 lines

Since we have no way access it from the CPU. For such cases just fallback to internal objects.

Since the problem is not limited to rings but it applies to all stolen objects, wouldn't it be better to just skip the stolen initialization or return an error from i915_gem_object_create_stolen()?

Not all stolen objects are accessed on the CPU, the problem expressed here is not universal.
-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#16 lore raw

Re: [PATCH 6/7] drm/i915: don't allocate the ring in stolen if we lack aperture

Quoted 8 lines · Chris Wilson

Quoting Daniele Ceraolo Spurio (2019-10-29 21:46:46)

Quoted 7 lines · Matthew Auld
Quoted 3 lines

Since we have no way access it from the CPU. For such cases just fallback to internal objects.

Quoted 8 lines
Quoted 3 lines

Since the problem is not limited to rings but it applies to all stolen objects, wouldn't it be better to just skip the stolen initialization or return an error from i915_gem_object_create_stolen()?

Not all stolen objects are accessed on the CPU, the problem expressed here is not universal.
-Chris

ok, please ignore my comment then.

Daniele
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#17 lore raw

PATCH 7/7 drm/i915/selftests: check for missing aperture

In reply to Matthew Auld

We may be missing support for the mappable aperture on some platforms.

Cc Daniele Ceraolo Spurio <[email protected]>
---
 .../drm/i915/gem/selftests/i915_gem_coherency.c    |  5 ++++-
 drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c |  6 ++++++
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c       | 14 ++++++++++----
 drivers/gpu/drm/i915/selftests/i915_gem.c          |  4 ++++
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c      |  3 +++
 5 files changed, 27 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c +4 -1
index 0a195e5b98e6..279e9047bc6d 100644
@@ -250,7 +250,10 @@ static bool always_valid(struct context *ctx)
 
 static bool needs_fence_registers(struct context *ctx)
 {
-	return !intel_gt_is_wedged(ctx->engine->gt);
+	if (intel_gt_is_wedged(ctx->engine->gt))
+		return false;
+
+	return ctx->engine->gt->ggtt->num_fences;
 }
 
 static bool needs_mi_store_dword(struct context *ctx)
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c +6 -0
index d45a93928ff5..29b2077b73d2 100644
@@ -301,6 +301,9 @@ static int igt_partial_tiling(void *arg)
 	int tiling;
 	int err;
 
+	if (!i915_ggtt_has_aperture(&i915->ggtt))
+		return 0;
+
 	/* We want to check the page mapping and fencing of a large object
 	 * mmapped through the GTT. The object we create is larger than can
 	 * possibly be mmaped as a whole, and so we must use partial GGTT vma.
@@ -431,6 +434,9 @@ static int igt_smoke_tiling(void *arg)
 	IGT_TIMEOUT(end);
 	int err;
 
+	if (!i915_ggtt_has_aperture(&i915->ggtt))
+		return 0;
+
 	/*
 	 * igt_partial_tiling() does an exhastive check of partial tiling
 	 * chunking, but will undoubtably run out of time. Here, we do a
drivers/gpu/drm/i915/gt/selftest_hangcheck.c +10 -4
index b7207b488391..8abc0a1d692b 100644
@@ -1149,8 +1149,12 @@ static int __igt_reset_evict_vma(struct intel_gt *gt,
 	struct i915_request *rq;
 	struct evict_vma arg;
 	struct hang h;
+	unsigned int pin_flags;
 	int err;
 
+	if (!gt->ggtt->num_fences && flags & EXEC_OBJECT_NEEDS_FENCE)
+		return 0;
+
 	if (!engine || !intel_engine_can_store_dword(engine))
 		return 0;
 
@@ -1186,10 +1190,12 @@ static int __igt_reset_evict_vma(struct intel_gt *gt,
 		goto out_obj;
 	}
 
-	err = i915_vma_pin(arg.vma, 0, 0,
-			   i915_vma_is_ggtt(arg.vma) ?
-			   PIN_GLOBAL | PIN_MAPPABLE :
-			   PIN_USER);
+	pin_flags = i915_vma_is_ggtt(arg.vma) ? PIN_GLOBAL : PIN_USER;
+
+	if (flags & EXEC_OBJECT_NEEDS_FENCE)
+		pin_flags |= PIN_MAPPABLE;
+
+	err = i915_vma_pin(arg.vma, 0, 0, pin_flags);
 	if (err) {
 		i915_request_add(rq);
 		goto out_obj;
drivers/gpu/drm/i915/selftests/i915_gem.c +4 -0
index 6d22567ad620..e378543ed453 100644
@@ -45,6 +45,10 @@ static void trash_stolen(struct drm_i915_private *i915)
 	unsigned long page;
 	u32 prng = 0x12345678;
 
+	/* XXX: fsck. needs some more thought... */
+	if (!i915_ggtt_has_aperture(ggtt))
+		return;
+
 	for (page = 0; page < size; page += PAGE_SIZE) {
 		const dma_addr_t dma = i915->dsm.start + page;
 		u32 __iomem *s;
drivers/gpu/drm/i915/selftests/i915_gem_gtt.c +3 -0
index a1cb072e4a1b..3f7e80fb3bbd 100644
@@ -1149,6 +1149,9 @@ static int igt_ggtt_page(void *arg)
 	unsigned int *order, n;
 	int err;
 
+	if (!i915_ggtt_has_aperture(ggtt))
+		return 0;
+
 	obj = i915_gem_object_create_internal(i915, PAGE_SIZE);
 	if (IS_ERR(obj))
 		return PTR_ERR(obj);
Signature · 6 lines
2.20.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 7/7
#18 lore raw

Re: [PATCH 7/7] drm/i915/selftests: check for missing aperture

Quoting Matthew Auld (2019-10-29 09:58:56)

Quoted 17 lines

We may be missing support for the mappable aperture on some platforms.

Cc Daniele Ceraolo Spurio <[email protected]>
---
 .../drm/i915/gem/selftests/i915_gem_coherency.c    |  5 ++++-
 drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c |  6 ++++++
 drivers/gpu/drm/i915/gt/selftest_hangcheck.c       | 14 ++++++++++----
 drivers/gpu/drm/i915/selftests/i915_gem.c          |  4 ++++
 drivers/gpu/drm/i915/selftests/i915_gem_gtt.c      |  3 +++
 5 files changed, 27 insertions(+), 5 deletions(-)
drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c +0 -0
index 0a195e5b98e6..279e9047bc6d 100644

drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c static bool always_valid(struct context *ctx) · line 252

Quoted 3 lines
drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c +0 -0
@@ -250,7 +250,10 @@ static bool always_valid(struct context *ctx)
 
 static bool needs_fence_registers(struct context *ctx)
 {

I vote for a struct intel_gt *gt = ctx->engine->gt;

drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c static bool always_valid(struct context *ctx) · line 257

Quoted 6 lines
drivers/gpu/drm/i915/gem/selftests/i915_gem_coherency.c +4 -1
-       return !intel_gt_is_wedged(ctx->engine->gt);
+       if (intel_gt_is_wedged(ctx->engine->gt))
+               return false;
+
+       return ctx->engine->gt->ggtt->num_fences;
 }

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reviewed-by on v1 1/7
#19 lore raw
In reply to Matthew Auld

Quoting Matthew Auld (2019-10-29 09:58:50)

Quoted 7 lines

From: Daniele Ceraolo Spurio <[email protected]>

The following patches in the series will use it to avoid certain operations when the mappable aperture is not available in HW.

-Chris
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#20 lore raw

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: define i915_ggtt_has_aperture

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: series starting with [1/7] drm/i915: define i915_ggtt_has_aperture
URL : https://patchwork.freedesktop.org/series/68705/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6d8f88fa8405 drm/i915: define i915_ggtt_has_aperture
d802efde66e4 drm/i915: do not map aperture if it is not available.
-:38: CHECK:SPACING: No space is necessary after a cast
#38: FILE: drivers/gpu/drm/i915/i915_gem_gtt.c:3004:
+			(struct resource) DEFINE_RES_MEM(pci_resource_start(pdev, 2),

total: 0 errors, 0 warnings, 1 checks, 50 lines checked a7a2178c7393 drm/i915: set num_fence_regs to 0 if there is no aperture 7cfb9135592b drm/i915: error capture with no ggtt slot 8bb585d4866a drm/i915: Don't try to place HWS in non-existing mappable region 1c42b31bf095 drm/i915: don't allocate the ring in stolen if we lack aperture 5a85b5a48a60 drm/i915/selftests: check for missing aperture

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#21 lore raw

✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm/i915: define i915_ggtt_has_aperture

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: series starting with [1/7] drm/i915: define i915_ggtt_has_aperture
URL : https://patchwork.freedesktop.org/series/68705/
State : warning

== Summary ==

$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915: define i915_ggtt_has_aperture
Okay!

Commit: drm/i915: do not map aperture if it is not available. Okay!

Commit: drm/i915: set num_fence_regs to 0 if there is no aperture Okay!

Commit: drm/i915: error capture with no ggtt slot
-
+drivers/gpu/drm/i915/i915_gpu_error.c:1023:55: expected void *src
+drivers/gpu/drm/i915/i915_gpu_error.c:1023:55: got void [noderef] <asn:2> *[assigned] s
+drivers/gpu/drm/i915/i915_gpu_error.c:1023:55: warning: incorrect type in argument 2 (different address spaces)

Commit: drm/i915: Don't try to place HWS in non-existing mappable region Okay!

Commit: drm/i915: don't allocate the ring in stolen if we lack aperture Okay!

Commit: drm/i915/selftests: check for missing aperture Okay!

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#22 lore raw

✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: define i915_ggtt_has_aperture

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: series starting with [1/7] drm/i915: define i915_ggtt_has_aperture
URL : https://patchwork.freedesktop.org/series/68705/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7208 -> Patchwork_15045
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/index.html

Known issues
------------

Here are the changes found in Patchwork_15045 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_mmap_gtt@basic-small-bo-tiledy:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/fi-icl-u3/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/fi-icl-u3/igt@[email protected]

* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][3] -> [DMESG-WARN][4] ([fdo#102614])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/fi-hsw-peppy/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/fi-hsw-peppy/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_create@basic:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/fi-icl-u3/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/fi-icl-u3/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- {fi-icl-u4}: [DMESG-WARN][7] ([fdo#106107]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/fi-icl-u4/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/fi-icl-u4/igt@[email protected]
- fi-icl-u3: [DMESG-WARN][9] ([fdo#106107]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/fi-icl-u3/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/fi-icl-u3/igt@[email protected]

* igt@i915_selftest@live_execlists:
- {fi-icl-guc}: [INCOMPLETE][11] ([fdo#107713]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/fi-icl-guc/igt@i915_selftest@live_execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/fi-icl-guc/igt@i915_selftest@live_execlists.html

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-icl-u2: [DMESG-WARN][13] ([fdo#102505] / [fdo#110390]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/fi-icl-u2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/fi-icl-u2/igt@[email protected]

* igt@kms_chamelium@hdmi-crc-fast:
- fi-icl-u2: [FAIL][15] ([fdo#109635 ]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/fi-icl-u2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/fi-icl-u2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#102505]: https://bugs.freedesktop.org/show_bug.cgi?id=102505
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109635 ]: https://bugs.freedesktop.org/show_bug.cgi?id=109635
[fdo#110390]: https://bugs.freedesktop.org/show_bug.cgi?id=110390

Participating hosts (51 -> 43)
------------------------------

Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-tgl-y fi-byt-clapper fi-bdw-samus

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7208 -> Patchwork_15045

CI-20190529: 20190529
CI_DRM_7208: 0e6cec76a950de7c4284f588846616027080ec3d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5248: 81e55f1f97d73e48f00caa7e4fb98295023c5afa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15045: 5a85b5a48a60eca3deee049cfa34597569b22498 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

5a85b5a48a60 drm/i915/selftests: check for missing aperture 1c42b31bf095 drm/i915: don't allocate the ring in stolen if we lack aperture 8bb585d4866a drm/i915: Don't try to place HWS in non-existing mappable region 7cfb9135592b drm/i915: error capture with no ggtt slot a7a2178c7393 drm/i915: set num_fence_regs to 0 if there is no aperture d802efde66e4 drm/i915: do not map aperture if it is not available. 6d8f88fa8405 drm/i915: define i915_ggtt_has_aperture

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#23 lore raw

✓ Fi.CI.IGT: success for series starting with [1/7] drm/i915: define i915_ggtt_has_aperture

In reply to Matthew Auld
== Series Details ==

== Series Details ==

Series: series starting with [1/7] drm/i915: define i915_ggtt_has_aperture
URL : https://patchwork.freedesktop.org/series/68705/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7208_full -> Patchwork_15045_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_15045_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_isolation@vcs1-dirty-switch:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#109276] / [fdo#112080])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb2/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb5/igt@[email protected]

* igt@gem_ctx_switch@vcs1-heavy-queue:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#112080]) +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb8/igt@[email protected]

* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][5] -> [SKIP][6] ([fdo#112146]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][7] -> [SKIP][8] ([fdo#109276]) +11 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb1/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb6/igt@[email protected]

* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [PASS][9] -> [DMESG-WARN][10] ([fdo#111870]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-hsw7/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-hsw1/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#111870]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-snb2/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-snb1/igt@[email protected]

* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-kbl: [PASS][13] -> [INCOMPLETE][14] ([fdo#103665])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-kbl1/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-kbl2/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [PASS][15] -> [DMESG-WARN][16] ([fdo#108566]) +5 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-kbl2/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-kbl4/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-legacy:
- shard-skl: [PASS][17] -> [FAIL][18] ([fdo#102670])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-skl1/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-skl10/igt@[email protected]

* igt@kms_flip@2x-modeset-vs-vblank-race-interruptible:
- shard-glk: [PASS][19] -> [FAIL][20] ([fdo#111609])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-glk8/igt@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-glk6/igt@[email protected]

* igt@kms_flip@absolute-wf_vblank:
- shard-apl: [PASS][21] -> [INCOMPLETE][22] ([fdo#103927]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-apl3/igt@kms_flip@absolute-wf_vblank.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-apl6/igt@kms_flip@absolute-wf_vblank.html

* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [PASS][23] -> [FAIL][24] ([fdo#105363])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-skl3/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-skl5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [PASS][25] -> [INCOMPLETE][26] ([fdo#103540])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-hsw7/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-hsw2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-pgflip-blt:
- shard-iclb: [PASS][27] -> [FAIL][28] ([fdo#103167]) +5 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb2/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][29] -> [DMESG-WARN][30] ([fdo#108566]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-apl2/igt@[email protected]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-apl6/igt@[email protected]

* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441]) +1 similar issue
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb4/igt@kms_psr@psr2_primary_mmap_cpu.html

#### Possible fixes ####

* igt@gem_ctx_isolation@bcs0-s3:
- shard-apl: [DMESG-WARN][33] ([fdo#108566]) -> [PASS][34] +4 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-apl6/igt@[email protected]
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-apl4/igt@[email protected]

* igt@gem_ctx_isolation@vcs1-s3:
- shard-iclb: [SKIP][35] ([fdo#109276] / [fdo#112080]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb3/igt@[email protected]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb1/igt@[email protected]

* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][37] ([fdo#110854]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb3/igt@[email protected]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb1/igt@[email protected]

* igt@gem_exec_nop@basic-series:
- {shard-tglb}: [INCOMPLETE][39] ([fdo#111747]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-tglb5/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-tglb7/igt@[email protected]

* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [SKIP][41] ([fdo#109276]) -> [PASS][42] +18 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb8/igt@[email protected]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb2/igt@[email protected]

* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][43] ([fdo#112146]) -> [PASS][44] +6 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb1/igt@[email protected]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb3/igt@[email protected]

* igt@gem_exec_schedule@preempt-queue-chain-bsd2:
- {shard-tglb}: [INCOMPLETE][45] ([fdo#111677]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-tglb6/igt@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-tglb7/igt@[email protected]

* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-snb: [FAIL][47] ([fdo#112037]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-snb6/igt@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-snb4/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][49] ([fdo#111870]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-snb4/igt@[email protected]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-snb4/igt@[email protected]

* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [DMESG-WARN][51] ([fdo#111870]) -> [PASS][52] +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-hsw4/igt@[email protected]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-hsw4/igt@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-kbl: [FAIL][53] ([fdo#103375]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-kbl1/igt@[email protected]
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-kbl6/igt@[email protected]

* {igt@i915_pm_dc@dc6-psr}:
- shard-iclb: [FAIL][55] ([fdo#110548]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb6/igt@[email protected]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb7/igt@[email protected]

* igt@kms_busy@basic-flip-a:
- shard-apl: [INCOMPLETE][57] ([fdo#103927]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-apl2/igt@[email protected]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-apl7/igt@[email protected]

* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-snb: [SKIP][59] ([fdo#109271]) -> [PASS][60] +5 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-snb2/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-snb7/igt@[email protected]

* igt@kms_flip@absolute-wf_vblank:
- {shard-tglb}: [INCOMPLETE][61] ([fdo#112031]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-tglb3/igt@kms_flip@absolute-wf_vblank.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-tglb1/igt@kms_flip@absolute-wf_vblank.html

* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][63] ([fdo#103167]) -> [PASS][64] +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html

* igt@kms_frontbuffer_tracking@fbc-stridechange:
- {shard-tglb}: [FAIL][65] ([fdo#103167]) -> [PASS][66] +4 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-tglb4/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-tglb8/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-onoff:
- shard-skl: [FAIL][67] ([fdo#103167]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-skl7/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-skl2/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-rgb565-draw-render:
- {shard-tglb}: [INCOMPLETE][69] -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-tglb6/igt@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-tglb5/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][71] ([fdo#108566]) -> [PASS][72] +1 similar issue
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-kbl3/igt@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-kbl3/igt@[email protected]

* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- {shard-tglb}: [INCOMPLETE][73] ([fdo#111832] / [fdo#111850]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-tglb1/igt@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-tglb6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [FAIL][75] ([fdo#108145]) -> [PASS][76] +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-skl3/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-skl5/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][77] ([fdo#108145] / [fdo#110403]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-skl9/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-skl10/igt@[email protected]

* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][79] ([fdo#103166]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb5/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb3/igt@[email protected]

* igt@perf_pmu@busy-accuracy-98-vcs1:
- shard-iclb: [SKIP][81] ([fdo#112080]) -> [PASS][82] +12 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb8/igt@[email protected]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb2/igt@[email protected]

#### Warnings ####

* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [SKIP][83] ([fdo#109276]) -> [FAIL][84] ([fdo#111330])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7208/shard-iclb5/igt@[email protected]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/shard-iclb1/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo# 112000 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 112000 [fdo#102670]: https://bugs.freedesktop.org/show_bug.cgi?id=102670
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111609]: https://bugs.freedesktop.org/show_bug.cgi?id=111609
[fdo#111677]: https://bugs.freedesktop.org/show_bug.cgi?id=111677
[fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111781]: https://bugs.freedesktop.org/show_bug.cgi?id=111781
[fdo#111831]: https://bugs.freedesktop.org/show_bug.cgi?id=111831
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
[fdo#112031]: https://bugs.freedesktop.org/show_bug.cgi?id=112031
[fdo#112037]: https://bugs.freedesktop.org/show_bug.cgi?id=112037
[fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112126]: https://bugs.freedesktop.org/show_bug.cgi?id=112126
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146

Participating hosts (11 -> 11)
------------------------------

No changes in participating hosts

Build changes
-------------

* CI: CI-20190529 -> None
* Linux: CI_DRM_7208 -> Patchwork_15045

CI-20190529: 20190529
CI_DRM_7208: 0e6cec76a950de7c4284f588846616027080ec3d @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5248: 81e55f1f97d73e48f00caa7e4fb98295023c5afa @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15045: 5a85b5a48a60eca3deee049cfa34597569b22498 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15045/index.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx