Skip to contentSkip to conversation

nodejs: allow use of system c-ares (and make default)

PATCH New André Draszik 1 participant 1 message Oct 29, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nodejs: allow use of system c-ares (and make default)

Use system c-ares via PACKAGECONFIG by default. So far, nodejs had been built using its embedded copy of c-ares, which we generally try to avoid, for the known reasons (independent updates, cve & license checks, etc).

Notes:
* otherwise nodejs uses its bundled version of c-ares
* the PACKAGECONFIG variable is 'ares' so as to be in line with other uses of this (wget & curl recipes in OE core)

---
 meta-oe/recipes-devtools/nodejs/nodejs_10.16.3.bb | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
meta-oe/recipes-devtools/nodejs/nodejs_10.16.3.bb +3 -2
index 30724d41a..6dacc2824 100644
@@ -49,9 +49,10 @@ ARCHFLAGS_arm = "${@bb.utils.contains('TUNE_FEATURES', 'callconvention-hard', '-
 GYP_DEFINES_append_mipsel = " mips_arch_variant='r1' "
 ARCHFLAGS ?= ""
 
-PACKAGECONFIG ??= "zlib icu"
-PACKAGECONFIG[zlib] = "--shared-zlib,,zlib"
+PACKAGECONFIG ??= "ares icu zlib"
+PACKAGECONFIG[ares] = "--shared-cares,,c-ares"
 PACKAGECONFIG[icu] = "--with-intl=system-icu,--without-intl,icu"
+PACKAGECONFIG[zlib] = "--shared-zlib,,zlib"
 
 # Node is way too cool to use proper autotools, so we install two wrappers to forcefully inject proper arch cflags to workaround gypi
 do_configure () {
Signature · 1 line
2.23.0.rc1