selftests: Move kselftest_module.sh into kselftest/
PATCH 1/1 selftests: Move kselftest_module.sh into kselftest/
The kselftest_module.sh file was not being installed by the Makefile "install" target, rendering the lib/*.sh tests nonfunction. This fixes that and takes the opportunity to move it into the kselftest/ subdirectory which is where the kselftest infrastructure bits are collecting.
---
tools/testing/selftests/Makefile | 1 +
.../selftests/{kselftest_module.sh => kselftest/module.sh} | 0
tools/testing/selftests/lib/bitmap.sh | 2 +-
tools/testing/selftests/lib/prime_numbers.sh | 2 +-
tools/testing/selftests/lib/printf.sh | 2 +-
tools/testing/selftests/lib/strscpy.sh | 2 +-
6 files changed, 5 insertions(+), 4 deletions(-)
rename tools/testing/selftests/{kselftest_module.sh => kselftest/module.sh} (100%)tools/testing/selftests/Makefile +1 -0
@@ -193,6 +193,7 @@ install: all ifdef INSTALL_PATH @# Ask all targets to install their files mkdir -p $(INSTALL_PATH)/kselftest + install -m 744 kselftest/module.sh $(INSTALL_PATH)/kselftest/ install -m 744 kselftest/runner.sh $(INSTALL_PATH)/kselftest/ install -m 744 kselftest/prefix.pl $(INSTALL_PATH)/kselftest/ @for TARGET in $(TARGETS); do \
tools/testing/selftests/kselftest/module.sh renamed from tools/testing/selftests/kselftest_module.sh +0 -0
tools/testing/selftests/lib/bitmap.sh +1 -1
@@ -1,3 +1,3 @@ #!/bin/sh # SPDX-License-Identifier: GPL-2.0 -$(dirname $0)/../kselftest_module.sh "bitmap" test_bitmap +$(dirname $0)/../kselftest/module.sh "bitmap" test_bitmap
tools/testing/selftests/lib/prime_numbers.sh +1 -1
@@ -1,4 +1,4 @@ #!/bin/sh # SPDX-License-Identifier: GPL-2.0 # Checks fast/slow prime_number generation for inconsistencies -$(dirname $0)/../kselftest_module.sh "prime numbers" prime_numbers selftest=65536 +$(dirname $0)/../kselftest/module.sh "prime numbers" prime_numbers selftest=65536
tools/testing/selftests/lib/printf.sh +1 -1
@@ -1,4 +1,4 @@ #!/bin/sh # SPDX-License-Identifier: GPL-2.0 # Tests the printf infrastructure using test_printf kernel module. -$(dirname $0)/../kselftest_module.sh "printf" test_printf +$(dirname $0)/../kselftest/module.sh "printf" test_printf
tools/testing/selftests/lib/strscpy.sh +1 -1
@@ -1,3 +1,3 @@ #!/bin/sh # SPDX-License-Identifier: GPL-2.0+ -$(dirname $0)/../kselftest_module.sh "strscpy*" test_strscpy +$(dirname $0)/../kselftest/module.sh "strscpy*" test_strscpy
Signature · 5 lines
2.17.1 -- Kees Cook
Hi Kees,
Thanks for the fix patch.
Quoted 10 lines · Kees Cook
The
kselftest_module.shfile was not being installed by theMakefile"install" target, rendering thelib/*.shtests nonfunction. This fixes that and takes the opportunity to move it into the kselftest/ subdirectory which is where the kselftest infrastructure bits are collecting.Reported-by Naresh Kamboju <[email protected]>Link https://lore.kernel.org/lkml/CA+G9fYsfJpXQvOvHdjtg8z4a89dSStOQZOKa9zMjjQgWKng1aw@mail.gmail.com open hereFixes d3460527706e ("kselftest: Add test runner creation script")Signed-off-by Kees Cook <[email protected]>
Now this patch merged into linux next tree.
Following tests getting pass.
kselftest:
* lib/bitmap.sh
* lib/printf.sh
* lib/strscpy.sh
Thank you.
Best regards
Naresh Kamboju