Skip to contentSkip to conversation

"splash: fix splash banner output" and newer llvm-7

U-Boot Tom Rini 2 participants 2 messages Oct 30, 2019

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

Hey,

With a patch to fix Travis-CI so that it actually uses LLVM-7 to build, I see I've let in a problem (the LLVM-7 I use locally is older and didn't catch it) with:
commit d2a8271c88514f30c2fe00d2584401348f39c3d4

Author: Anatolij Gustschin <[email protected]>
Date:   Fri Sep 20 17:23:41 2019 +0200

splash: fix splash banner output

Old splash code in cfb_console driver displayed U-Boot version string by default. Restore this behaviour for DM_VIDEO enabled configurations.

which from https://travis-ci.org/trini/u-boot/jobs/604644412
is:
+common/splash.c:148:20: error: unused function 'splash_display_banner' [-Werror,-Wunused-function] +static inline void splash_display_banner(void) { }
+ ^
+1 error generated.
+make[2]: *** [common/splash.o] Error 1
+make[1]: *** [common] Error 2
+make: *** [sub-make] Error 2

Can you please take a look? Thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191030/44ada4f2/attachment.sig>
#1 lore raw

Hi Tom,

On Wed, 30 Oct 2019 09:01:37 -0400
Tom Rini trini at konsulko.com wrote:
...

Quoted 9 lines
(quoted diff) +7 -0
+common/splash.c:148:20: error: unused function 'splash_display_banner' [-Werror,-Wunused-function]
+static inline void splash_display_banner(void) { }
+                   ^
+1 error generated.
+make[2]: *** [common/splash.o] Error 1
+make[1]: *** [common] Error 2
+make: *** [sub-make] Error 2

Can you please take a look? Thanks!

I'll send a fix soon.

Thanks,

--
Anatolij