dlmalloc: calloc: fix zeroing early allocations
PATCH 1/1 dlmalloc: calloc: fix zeroing early allocations
When full malloc is enabled and SYS_MALLOC_F is also enabled, the simple pre-reloc heap is used before relocation. In this case, calloc() uses the MALLOC_ZERO macro to zero out the allocated memory. However, since this macro is specially crafted for the dlmalloc implementation, it does not always work for simple malloc.
For example, when allocating 16 bytes via simple malloc, only the first 12 bytes get zeroed out. The last 4 bytes will remain untouched.
This is a problem for DM drivers that are allocated before relocation:
memory allocated via 'platdata_auto_alloc_size' might not be set to zero, resulting in bogus behaviour.
To fix this, use 'memset' instead of 'MALLOC_ZERO' to zero out memory that compes from simple malloc.
---
common/dlmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
common/dlmalloc.c +1 -1
@@ -2086,7 +2086,7 @@ Void_t* cALLOc(n, elem_size) size_t n; size_t elem_size; {#if CONFIG_VAL (SYS_MALLOC_F_LEN )if (!(gd->flags &GD_FLG_FULL_MALLOC_INIT )) { -MALLOC_ZERO (mem, sz); +memset (mem,0 , sz);return mem; }#endif
Signature · 1 line
2.20.1
PATCH 1/1 dlmalloc: calloc: fix zeroing early allocations
Quoted 9 lines · Simon Goldschmidt
When full malloc is enabled and
SYS_MALLOC_Fis also enabled, the simple pre-reloc heap is used before relocation. In this case,calloc()uses theMALLOC_ZEROmacro to zero out the allocated memory. However, since this macro is specially crafted for the dlmalloc implementation, it does not always work for simple malloc.For example, when allocating 16 bytes via simple malloc, only the first 12 bytes get zeroed out. The last 4 bytes will remain untouched.
Quoted 8 lines
This is a problem for DM drivers that are allocated before relocation:
memory allocated via 'platdata_auto_alloc_size' might not be set to zero, resulting in bogus behaviour.To fix this, use 'memset' instead of '
MALLOC_ZERO' to zero out memory that compes from simple malloc.Signed-off-by Simon Goldschmidt <[email protected]>
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191030/e42f9052/attachment.sig>
PATCH 1/1 dlmalloc: calloc: fix zeroing early allocations
In reply to Simon GoldschmidtQuoted 13 lines · Simon Goldschmidt
When full malloc is enabled and
SYS_MALLOC_Fis also enabled, the simple pre-reloc heap is used before relocation. In this case,calloc()uses theMALLOC_ZEROmacro to zero out the allocated memory. However, since this macro is specially crafted for the dlmalloc implementation, it does not always work for simple malloc.For example, when allocating 16 bytes via simple malloc, only the first 12 bytes get zeroed out. The last 4 bytes will remain untouched.
This is a problem for DM drivers that are allocated before relocation:
memory allocated via 'platdata_auto_alloc_size' might not be set to zero, resulting in bogus behaviour.
Quoted 5 lines
To fix this, use 'memset' instead of '
MALLOC_ZERO' to zero out memory that compes from simple malloc.Signed-off-by Simon Goldschmidt <[email protected]>Reviewed-by Tom Rini <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191108/75a20b2d/attachment.sig>