Skip to contentSkip to conversation

WIP Add support for i.MXRT family

RFC PATCH New Giulio Benetti 2 participants 13 messages Oct 30, 2019 – Nov 4, 2019

Subsystems (10)
lore
Share & tools
lore
#0 lore raw

cover WIP Add support for i.MXRT family

This patchset is a WIP for adding i.MXRT family.
It provides:
- soc family entry
- pinctrl driver
- serial driver tweaking
- partial sdram controller driver
- imxrt1050-evk board partial support

To get it working as at least SPL and Falcon mode it still needs sdram controller driver to be finished and clock driver to be done.

I would like to receive some comment from you all since this is my first big contribution(at least for me it is).

Giulio Benetti (5):
Add support for the NXP IMXRT10xx SoC family
pinctrl: add i.MXRT driver
serial_lpuart: add support for i.MXRT
ram: add SDRAM driver for i.MXRT SoCs
Add support for the NXP IMXRT1050-EVK board

 arch/arm/Kconfig                              |  10 +
 arch/arm/Makefile                             |   4 +-
 arch/arm/dts/Makefile                         |   2 +
 arch/arm/dts/imxrt1050-evk.dts                | 124 +++
 arch/arm/dts/imxrt1050.dtsi                   |  73 ++
 arch/arm/include/asm/arch-imxrt/clock.h       |  10 +
 arch/arm/include/asm/arch-imxrt/gpio.h        |  10 +
 arch/arm/include/asm/arch-imxrt/imx-regs.h    |  10 +
 arch/arm/include/asm/arch-imxrt/imxrt.h       |  11 +
 arch/arm/mach-imx/Makefile                    |   1 +
 arch/arm/mach-imx/imxrt/Kconfig               |  17 +
 arch/arm/mach-imx/imxrt/Makefile              |   7 +
 arch/arm/mach-imx/imxrt/soc.c                 |  29 +
 board/freescale/imxrt1050-evk/Kconfig         |  19 +
 board/freescale/imxrt1050-evk/MAINTAINERS     |   6 +
 board/freescale/imxrt1050-evk/Makefile        |   6 +
 board/freescale/imxrt1050-evk/imxrt1050-evk.c |  94 ++
 configs/imxrt1050-evk_defconfig               |  52 +
 drivers/pinctrl/nxp/Kconfig                   |  14 +
 drivers/pinctrl/nxp/Makefile                  |   1 +
 drivers/pinctrl/nxp/pinctrl-imxrt.c           |  40 +
 drivers/ram/Kconfig                           |   8 +
 drivers/ram/Makefile                          |   2 +
 drivers/ram/imxrt_sdram.c                     | 406 +++++++
 drivers/serial/serial_lpuart.c                |  15 +-
 include/configs/imxrt1050-evk.h               |  68 ++
 include/dt-bindings/clock/imxrt-clock.h       | 272 +++++
 include/dt-bindings/memory/imxrt-sdram.h      | 168 +++
 include/dt-bindings/pinctrl/pins-imxrt1050.h  | 993 ++++++++++++++++++
 include/fsl_lpuart.h                          |   3 +-
 30 files changed, 2468 insertions(+), 7 deletions(-)
 create mode 100644 arch/arm/dts/imxrt1050-evk.dts
 create mode 100644 arch/arm/dts/imxrt1050.dtsi
 create mode 100644 arch/arm/include/asm/arch-imxrt/clock.h
 create mode 100644 arch/arm/include/asm/arch-imxrt/gpio.h
 create mode 100644 arch/arm/include/asm/arch-imxrt/imx-regs.h
 create mode 100644 arch/arm/include/asm/arch-imxrt/imxrt.h
 create mode 100644 arch/arm/mach-imx/imxrt/Kconfig
 create mode 100644 arch/arm/mach-imx/imxrt/Makefile
 create mode 100644 arch/arm/mach-imx/imxrt/soc.c
 create mode 100644 board/freescale/imxrt1050-evk/Kconfig
 create mode 100644 board/freescale/imxrt1050-evk/MAINTAINERS
 create mode 100644 board/freescale/imxrt1050-evk/Makefile
 create mode 100644 board/freescale/imxrt1050-evk/imxrt1050-evk.c
 create mode 100644 configs/imxrt1050-evk_defconfig
 create mode 100644 drivers/pinctrl/nxp/pinctrl-imxrt.c
 create mode 100644 drivers/ram/imxrt_sdram.c
 create mode 100644 include/configs/imxrt1050-evk.h
 create mode 100644 include/dt-bindings/clock/imxrt-clock.h
 create mode 100644 include/dt-bindings/memory/imxrt-sdram.h
 create mode 100644 include/dt-bindings/pinctrl/pins-imxrt1050.h
Signature · 1 line
2.20.1
#1 lore raw

RFC PATCH 1/5 Add support for the NXP IMXRT10xx SoC family

TODO...

---
 arch/arm/Kconfig                           | 10 ++++++++
 arch/arm/Makefile                          |  4 +--
 arch/arm/include/asm/arch-imxrt/clock.h    | 10 ++++++++
 arch/arm/include/asm/arch-imxrt/gpio.h     | 10 ++++++++
 arch/arm/include/asm/arch-imxrt/imx-regs.h | 10 ++++++++
 arch/arm/include/asm/arch-imxrt/imxrt.h    | 11 ++++++++
 arch/arm/mach-imx/Makefile                 |  1 +
 arch/arm/mach-imx/imxrt/Kconfig            |  6 +++++
 arch/arm/mach-imx/imxrt/Makefile           |  7 ++++++
 arch/arm/mach-imx/imxrt/soc.c              | 29 ++++++++++++++++++++++
 10 files changed, 96 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/include/asm/arch-imxrt/clock.h
 create mode 100644 arch/arm/include/asm/arch-imxrt/gpio.h
 create mode 100644 arch/arm/include/asm/arch-imxrt/imx-regs.h
 create mode 100644 arch/arm/include/asm/arch-imxrt/imxrt.h
 create mode 100644 arch/arm/mach-imx/imxrt/Kconfig
 create mode 100644 arch/arm/mach-imx/imxrt/Makefile
 create mode 100644 arch/arm/mach-imx/imxrt/soc.c
arch/arm/Kconfig +10 -0
index 3b0e315061..672a2a1fe3 100644
@@ -780,6 +780,14 @@ config ARCH_IMX8M
 	select SUPPORT_SPL
 	imply CMD_DM
 
+config ARCH_IMXRT
+	bool "NXP i.MXRT platform"
+	select CPU_V7M
+	select DM
+	select DM_SERIAL
+	select SUPPORT_SPL
+	imply CMD_DM
+
 config ARCH_MX23
 	bool "NXP i.MX23 family"
 	select CPU_ARM926EJS
@@ -1694,6 +1702,8 @@ source "arch/arm/mach-imx/imx8/Kconfig"
 
 source "arch/arm/mach-imx/imx8m/Kconfig"
 
+source "arch/arm/mach-imx/imxrt/Kconfig"
+
 source "arch/arm/mach-imx/mxs/Kconfig"
 
 source "arch/arm/mach-omap2/Kconfig"
arch/arm/Makefile +2 -2
index 5384981c17..5dd9f5b1f6 100644
@@ -104,11 +104,11 @@ libs-y += arch/arm/cpu/
 libs-y += arch/arm/lib/
 
 ifeq ($(CONFIG_SPL_BUILD),y)
-ifneq (,$(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_MX35)$(filter $(SOC), mx25 mx5 mx6 mx7 mx35 imx8m imx8))
+ifneq (,$(CONFIG_MX23)$(CONFIG_MX28)$(CONFIG_MX35)$(filter $(SOC), mx25 mx5 mx6 mx7 mx35 imx8m imx8 imxrt))
 libs-y += arch/arm/mach-imx/
 endif
 else
-ifneq (,$(filter $(SOC), mx25 mx27 mx5 mx6 mx7 mx7ulp mx31 mx35 mxs imx8m imx8 vf610))
+ifneq (,$(filter $(SOC), mx25 mx27 mx5 mx6 mx7 mx7ulp mx31 mx35 mxs imx8m imx8 imxrt vf610))
 libs-y += arch/arm/mach-imx/
 endif
 endif
arch/arm/include/asm/arch-imxrt/clock.h new file +10 -0
new file mode 100644
index 0000000000..7409028b9a
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (C) 2019
+ * Author(s): Giulio Benetti <[email protected]>
+ */
+
+#ifndef __ASM_ARCH_CLOCK_H
+#define __ASM_ARCH_CLOCK_H
+
+#endif /* __ASM_ARCH_CLOCK_H */
arch/arm/include/asm/arch-imxrt/gpio.h new file +10 -0
new file mode 100644
index 0000000000..973ab1da61
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (C) 2019
+ * Author(s): Giulio Benetti <[email protected]>
+ */
+
+#ifndef _GPIO_H_
+#define _GPIO_H_
+
+#endif /* _GPIO_H_ */
arch/arm/include/asm/arch-imxrt/imx-regs.h new file +10 -0
new file mode 100644
index 0000000000..4ca7f6bed3
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright(C) 2019
+ * Author(s): Giulio Benetti <[email protected]>
+ */
+
+#ifndef __ASM_ARCH_IMX_REGS_H__
+#define __ASM_ARCH_IMX_REGS_H__
+
+#endif /* __ASM_ARCH_IMX_REGS_H__ */
arch/arm/include/asm/arch-imxrt/imxrt.h new file +11 -0
new file mode 100644
index 0000000000..1cb2c57d31
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * Copyright (C) 2019
+ * Author(s): Giulio Benetti <[email protected]>
+ */
+
+#ifndef _ASM_ARCH_IMXRT_H
+#define _ASM_ARCH_IMXRT_H
+
+#endif /* _ASM_ARCH_IMXRT_H */
+
arch/arm/mach-imx/Makefile +1 -0
index 08ee52edbf..4b0e12c1b2 100644
@@ -208,3 +208,4 @@ obj-$(CONFIG_MX7) += mx7/
 obj-$(CONFIG_ARCH_MX7ULP) += mx7ulp/
 obj-$(CONFIG_IMX8M) += imx8m/
 obj-$(CONFIG_ARCH_IMX8) += imx8/
+obj-$(CONFIG_ARCH_IMXRT) += imxrt/
arch/arm/mach-imx/imxrt/Kconfig new file +6 -0
new file mode 100644
index 0000000000..1da002336b
@@ -0,0 +1,6 @@
+if ARCH_IMXRT
+
+config SYS_SOC
+	default "imxrt"
+
+endif
arch/arm/mach-imx/imxrt/Makefile new file +7 -0
new file mode 100644
index 0000000000..9621a8335a
@@ -0,0 +1,7 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# (C) Copyright 2019
+# Author(s): Giulio Benetti <[email protected]>
+#
+
+obj-y	:= soc.o
arch/arm/mach-imx/imxrt/soc.c new file +29 -0
new file mode 100644
index 0000000000..561f284602
@@ -0,0 +1,29 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019
+ * Author(s): Giulio Benetti <[email protected]>
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <asm/armv7_mpu.h>
+
+int arch_cpu_init(void)
+{
+	int i;
+
+	struct mpu_region_config imxrt_region_config[] = {
+		/*
+		 * Make SDRAM area cacheable & executable.
+		 */
+		{ 0x80000000, REGION_1, XN_DIS, PRIV_RW_USR_RW,
+		SHARED_WRITE_BUFFERED, REGION_256MB },
+	};
+
+	disable_mpu();
+	for (i = 0; i < ARRAY_SIZE(imxrt_region_config); i++)
+		mpu_config(&imxrt_region_config[i]);
+	enable_mpu();
+
+	return 0;
+}
Signature · 1 line
2.20.1
#2 lore raw

RFC PATCH 2/5 pinctrl: add i.MXRT driver

In reply to Giulio Benetti

Add i.MXRT pinctrl driver.

---
 drivers/pinctrl/nxp/Kconfig                  |  14 +
 drivers/pinctrl/nxp/Makefile                 |   1 +
 drivers/pinctrl/nxp/pinctrl-imxrt.c          |  40 +
 include/dt-bindings/pinctrl/pins-imxrt1050.h | 993 +++++++++++++++++++
 4 files changed, 1048 insertions(+)
 create mode 100644 drivers/pinctrl/nxp/pinctrl-imxrt.c
 create mode 100644 include/dt-bindings/pinctrl/pins-imxrt1050.h
drivers/pinctrl/nxp/Kconfig +14 -0
index f2e67ca231..ec55351e61 100644
@@ -99,6 +99,20 @@ config PINCTRL_MXS
 	  familiy, e.g. i.MX28. This feature depends on device tree
 	  configuration.
 
+config PINCTRL_IMXRT
+	bool "IMXRT pinctrl driver"
+	depends on ARCH_IMXRT && PINCTRL_FULL
+	select DEVRES
+	select PINCTRL_IMX
+	help
+	  Say Y here to enable the imxrt pinctrl driver
+
+	  This provides a simple pinctrl driver for i.MXRT SoC familiy.
+	  This feature depends on device tree configuration. This driver
+	  is different from the linux one, this is a simple implementation,
+	  only parses the 'fsl,pins' property and configure related
+	  registers.
+
 config PINCTRL_VYBRID
 	bool "Vybrid (vf610) pinctrl driver"
 	depends on ARCH_VF610 && PINCTRL_FULL
drivers/pinctrl/nxp/Makefile +1 -0
index b86448aac9..066ca75b65 100644
@@ -8,3 +8,4 @@ obj-$(CONFIG_PINCTRL_IMX8)		+= pinctrl-imx8.o
 obj-$(CONFIG_PINCTRL_IMX8M)		+= pinctrl-imx8m.o
 obj-$(CONFIG_PINCTRL_MXS)		+= pinctrl-mxs.o
 obj-$(CONFIG_PINCTRL_VYBRID)		+= pinctrl-vf610.o
+obj-$(CONFIG_PINCTRL_IMXRT)		+= pinctrl-imxrt.o
drivers/pinctrl/nxp/pinctrl-imxrt.c new file +40 -0
new file mode 100644
index 0000000000..4a93941927
@@ -0,0 +1,40 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019
+ * Author(s): Giulio Benetti <[email protected]>
+ */
+
+#include <common.h>
+#include <dm.h>
+#include <dm/pinctrl.h>
+
+#include "pinctrl-imx.h"
+
+static struct imx_pinctrl_soc_info imxrt_pinctrl_soc_info = {
+	.flags = ZERO_OFFSET_VALID,
+};
+
+static int imxrt_pinctrl_probe(struct udevice *dev)
+{
+	struct imx_pinctrl_soc_info *info =
+		(struct imx_pinctrl_soc_info *)dev_get_driver_data(dev);
+
+	return imx_pinctrl_probe(dev, info);
+}
+
+static const struct udevice_id imxrt_pinctrl_match[] = {
+	{ .compatible = "fsl,imxrt-iomuxc",
+	  .data = (ulong)&imxrt_pinctrl_soc_info },
+	{ /* sentinel */ }
+};
+
+U_BOOT_DRIVER(imxrt_pinctrl) = {
+	.name = "imxrt-pinctrl",
+	.id = UCLASS_PINCTRL,
+	.of_match = of_match_ptr(imxrt_pinctrl_match),
+	.probe = imxrt_pinctrl_probe,
+	.remove = imx_pinctrl_remove,
+	.priv_auto_alloc_size = sizeof(struct imx_pinctrl_priv),
+	.ops = &imx_pinctrl_ops,
+	.flags = DM_FLAG_PRE_RELOC,
+};
include/dt-bindings/pinctrl/pins-imxrt1050.h new file +993 -0

993 lines not on this page · raw message

Signature · 1 line
2.20.1
#3 lore raw

RFC PATCH 3/5 serial_lpuart: add support for i.MXRT

In reply to Giulio Benetti

Add i.MXRT compatible string and cpu type support to lpuart driver, to use little endian 32 bits configurations.

Also according to RM, the Receive RX FIFO Enable (RXFE) field in LPUART FIFO register is bit 3, so this definition should change to 0x08 as done for i.MX8. It needs also to set baudrate the same way as i.MX8 does.

---
 drivers/serial/serial_lpuart.c | 15 +++++++++++----
 include/fsl_lpuart.h           |  3 ++-
 2 files changed, 13 insertions(+), 5 deletions(-)
drivers/serial/serial_lpuart.c +11 -4
index 4b0a964d1b..52b561b627 100644
@@ -49,7 +49,7 @@
 #define FIFO_RXSIZE_MASK	0x7
 #define FIFO_RXSIZE_OFF	0
 #define FIFO_TXFE		0x80
-#ifdef CONFIG_ARCH_IMX8
+#if defined(CONFIG_ARCH_IMX8) || defined(CONFIG_ARCH_IMXRT)
 #define FIFO_RXFE		0x08
 #else
 #define FIFO_RXFE		0x40
@@ -67,7 +67,8 @@ enum lpuart_devtype {
 	DEV_VF610 = 1,
 	DEV_LS1021A,
 	DEV_MX7ULP,
-	DEV_IMX8
+	DEV_IMX8,
+	DEV_IMXRT,
 };
 
 struct lpuart_serial_platdata {
@@ -409,7 +410,8 @@ static int _lpuart32_serial_init(struct udevice *dev)
 
 	lpuart_write32(plat->flags, &base->match, 0);
 
-	if (plat->devtype == DEV_MX7ULP || plat->devtype == DEV_IMX8) {
+	if (plat->devtype == DEV_MX7ULP || plat->devtype == DEV_IMX8 ||
+	    plat->devtype == DEV_IMXRT) {
 		_lpuart32_serial_setbrg_7ulp(dev, gd->baudrate);
 	} else {
 		/* provide data bits, parity, stop bit, etc */
@@ -426,7 +428,8 @@ static int lpuart_serial_setbrg(struct udevice *dev, int baudrate)
 	struct lpuart_serial_platdata *plat = dev_get_platdata(dev);
 
 	if (is_lpuart32(dev)) {
-		if (plat->devtype == DEV_MX7ULP || plat->devtype == DEV_IMX8)
+		if (plat->devtype == DEV_MX7ULP || plat->devtype == DEV_IMX8 ||
+		    plat->devtype == DEV_IMXRT)
 			_lpuart32_serial_setbrg_7ulp(dev, baudrate);
 		else
 			_lpuart32_serial_setbrg(dev, baudrate);
@@ -514,6 +517,8 @@ static int lpuart_serial_ofdata_to_platdata(struct udevice *dev)
 		plat->devtype = DEV_VF610;
 	else if (!fdt_node_check_compatible(blob, node, "fsl,imx8qm-lpuart"))
 		plat->devtype = DEV_IMX8;
+	else if (!fdt_node_check_compatible(blob, node, "fsl,imxrt-lpuart"))
+		plat->devtype = DEV_IMXRT;
 
 	return 0;
 }
@@ -533,6 +538,8 @@ static const struct udevice_id lpuart_serial_ids[] = {
 	{ .compatible = "fsl,vf610-lpuart"},
 	{ .compatible = "fsl,imx8qm-lpuart",
 		.data = LPUART_FLAG_REGMAP_32BIT_REG },
+	{ .compatible = "fsl,imxrt-lpuart",
+		.data = LPUART_FLAG_REGMAP_32BIT_REG },
 	{ }
 };
 
include/fsl_lpuart.h +2 -1
index fc517d4b7f..511fb84367 100644
@@ -4,7 +4,8 @@
  *
  */
 
-#if defined(CONFIG_ARCH_MX7ULP) || defined(CONFIG_ARCH_IMX8)
+#if defined(CONFIG_ARCH_MX7ULP) || defined(CONFIG_ARCH_IMX8) || \
+	defined(CONFIG_ARCH_IMXRT)
 struct lpuart_fsl_reg32 {
 	u32 verid;
 	u32 param;
Signature · 1 line
2.20.1
#4 lore raw

RFC PATCH 4/5 ram: add SDRAM driver for i.MXRT SoCs

In reply to Giulio Benetti
---
 drivers/ram/Kconfig                      |   8 +
 drivers/ram/Makefile                     |   2 +
 drivers/ram/imxrt_sdram.c                | 406 +++++++++++++++++++++++
 include/dt-bindings/memory/imxrt-sdram.h | 168 ++++++++++
 4 files changed, 584 insertions(+)
 create mode 100644 drivers/ram/imxrt_sdram.c
 create mode 100644 include/dt-bindings/memory/imxrt-sdram.h
drivers/ram/Kconfig +8 -0
index 568d8f2c6a..69b0233a48 100644
@@ -54,5 +54,13 @@ config K3_AM654_DDRSS
 	  config add support for the initialization of the external
 	  SDRAM devices connected to DDR subsystem.
 
+config IMXRT_SDRAM
+	bool "Enable i.MXRT SDRAM support"
+	depends on RAM
+	help
+	  i.MXRT family devices support smart external memory controller(SEMC)
+	  to support external memories like sdram, psram & nand.
+	  This driver is for the sdram memory interface with the SEMC.
+
 source "drivers/ram/rockchip/Kconfig"
 source "drivers/ram/stm32mp1/Kconfig"
drivers/ram/Makefile +2 -0
index 976ec66df7..d3813e37e4 100644
@@ -14,3 +14,5 @@ obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/
 
 obj-$(CONFIG_K3_AM654_DDRSS) += k3-am654-ddrss.o
 obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/
+
+obj-$(CONFIG_IMXRT_SDRAM) += imxrt_sdram.o
drivers/ram/imxrt_sdram.c new file +406 -0

406 lines not on this page · raw message

include/dt-bindings/memory/imxrt-sdram.h new file +168 -0

168 lines not on this page · raw message

Signature · 1 line
2.20.1
#5 lore raw

RFC PATCH 4/5 ram: add SDRAM driver for i.MXRT SoCs

Hi Stefano, Fabio and All,

I have some question below:

Quoted 257 lines · Giulio Benetti
---
  drivers/ram/Kconfig                      |   8 +
  drivers/ram/Makefile                     |   2 +
  drivers/ram/imxrt_sdram.c                | 406 +++++++++++++++++++++++
  include/dt-bindings/memory/imxrt-sdram.h | 168 ++++++++++
  4 files changed, 584 insertions(+)

create mode 100644 drivers/ram/imxrt_sdram.c create mode 100644 include/dt-bindings/memory/imxrt-sdram.h

drivers/ram/Kconfig +8 -0
index 568d8f2c6a..69b0233a48 100644
@@ -54,5 +54,13 @@ config K3_AM654_DDRSS
  	  config add support for the initialization of the external
  	  SDRAM devices connected to DDR subsystem.
 
+config IMXRT_SDRAM
+	bool "Enable i.MXRT SDRAM support"
+	depends on RAM
+	help
+	  i.MXRT family devices support smart external memory controller(SEMC)
+	  to support external memories like sdram, psram & nand.
+	  This driver is for the sdram memory interface with the SEMC.
+
  source "drivers/ram/rockchip/Kconfig"
  source "drivers/ram/stm32mp1/Kconfig"
drivers/ram/Makefile +2 -0
index 976ec66df7..d3813e37e4 100644
@@ -14,3 +14,5 @@ obj-$(CONFIG_ARCH_ROCKCHIP) += rockchip/
 
  obj-$(CONFIG_K3_AM654_DDRSS) += k3-am654-ddrss.o
  obj-$(CONFIG_ARCH_MEDIATEK) += mediatek/
+
+obj-$(CONFIG_IMXRT_SDRAM) += imxrt_sdram.o
drivers/ram/imxrt_sdram.c new file +213 -0
new file mode 100644
index 0000000000..7c157f60e2
@@ -0,0 +1,406 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019
+ * Author(s): Giulio Benetti <[email protected]>
+ */
+
+#include <common.h>
+#include <clk.h>
+#include <dm.h>
+#include <ram.h>
+#include <asm/io.h>
+
+/* SDRAM Command Code */
+#define SD_CC_ARD		0x0     /* Master Bus (AXI) command - Read */
+#define SD_CC_AWR		0x1     /* Master Bus (AXI) command - Write */
+#define SD_CC_IRD		0x8     /* IP command - Read */
+#define SD_CC_IWR		0x9     /* IP command - Write */
+#define SD_CC_IMS		0xA     /* IP command - Set Mode Register */
+#define SD_CC_IACT		0xB     /* IP command - ACTIVE */
+#define SD_CC_IAF		0xC     /* IP command - Auto Refresh */
+#define SD_CC_ISF		0xD     /* IP Command - Self Refresh */
+#define SD_CC_IPRE		0xE     /* IP command - Precharge */
+#define SD_CC_IPREA		0xF     /* IP command - Precharge ALL */
+
+#define SEMC_MCR_MDIS		BIT(1)
+#define SEMC_MCR_DQSMD		BIT(2)
+
+struct imxrt_semc_regs {
+	/* 0x0 */
+	u32 mcr;
+	u32 iocr;
+	u32 bmcr0;
+	u32 bmcr1;
+	u32 br[9];
+
+	/* 0x34 */
+	u32 res1;
+	u32 inten;
+	u32 intr;
+	/* 0x40 */
+	u32 sdramcr0;
+	u32 sdramcr1;
+	u32 sdramcr2;
+	u32 sdramcr3;
+	/* 0x50 */
+	u32 nandcr0;
+	u32 nandcr1;
+	u32 nandcr2;
+	u32 nandcr3;
+	/* 0x60 */
+	u32 norcr0;
+	u32 norcr1;
+	u32 norcr2;
+	u32 norcr3;
+	/* 0x70 */
+	u32 sramcr0;
+	u32 sramcr1;
+	u32 sramcr2;
+	u32 sramcr3;
+	/* 0x80 */
+	u32 dbicr0;
+	u32 dbicr1;
+	u32 res2[2];
+	/* 0x90 */
+	u32 ipcr0;
+	u32 ipcr1;
+	u32 ipcr2;
+	u32 ipcmd;
+	/* 0xA0 */
+	u32 iptxdat;
+	u32 res3[3];
+	/* 0xB0 */
+	u32 iprxdat;
+	u32 res4[3];
+	/* 0xC0 */
+	u32 sts[16];
+};
+
+#define SEMC_IOCR_MUX_A8_SHIFT		0
+#define SEMC_IOCR_MUX_CSX0_SHIFT	1
+#define SEMC_IOCR_MUX_CSX1_SHIFT	2
+#define SEMC_IOCR_MUX_CSX2_SHIFT	3
+#define SEMC_IOCR_MUX_CSX3_SHIFT	4
+#define SEMC_IOCR_MUX_RDY_SHIFT		5
+
+struct imxrt_sdram_mux {
+	u8 a8;
+	u8 csx0;
+	u8 csx1;
+	u8 csx2;
+	u8 csx3;
+	u8 rdy;
+};
+
+#define SEMC_SDRAMCR0_PS_SHIFT		0
+#define SEMC_SDRAMCR0_BL_SHIFT		4
+#define SEMC_SDRAMCR0_COL_SHIFT		8
+#define SEMC_SDRAMCR0_CL_SHIFT		10
+
+struct imxrt_sdram_control {
+	u8 memory_width;
+	u8 burst_len;
+	u8 no_columns;
+	u8 cas_latency;
+};
+
+#define SEMC_SDRAMCR1_PRE2ACT_SHIFT	0
+#define SEMC_SDRAMCR1_ACT2RW_SHIFT	4
+#define SEMC_SDRAMCR1_RFRC_SHIFT	8
+#define SEMC_SDRAMCR1_WRC_SHIFT		12
+
+struct imxrt_sdram_timing {
+	u8 trp;
+	u8 trcd;
+	u8 trfc;
+	u8 twr;
+#if TODO
+	u8 tmrd;
+	u8 txsr;
+	u8 tras;
+	u8 trc;
+#endif
+};
+
+enum imxrt_semc_bank {
+	SDRAM_BANK1,
+	SDRAM_BANK2,
+	SDRAM_BANK3,
+	SDRAM_BANK4,
+	MAX_SDRAM_BANK,
+};
+
+#define SEMC_BR_VLD_MASK		1
+#define SEMC_BR_MS_SHIFT		1
+
+struct bank_params {
+	enum imxrt_semc_bank target_bank;
+	u32 base_address;
+	u32 memory_size;
+};
+
+struct imxrt_sdram_params {
+	struct imxrt_semc_regs *base;
+
+	struct imxrt_sdram_mux *sdram_mux;
+	struct imxrt_sdram_control *sdram_control;
+	struct imxrt_sdram_timing *sdram_timing;
+
+	struct bank_params bank_params[MAX_SDRAM_BANK];
+	u8 no_sdram_banks;
+};
+
+void imxrt_sdram_wait_ipcmd_done(struct imxrt_semc_regs *regs)
+{
+	do {
+		mdelay(50);
+		/* check for IPCMDDONE or IPCMERR */
+		/* TODO: handle error */
+	} while (!(readl(&regs->intr) & 0x3));
+}
+
+u32 imxrt_sdram_ipcmd(struct imxrt_semc_regs *regs, u32 mem_addr, u32 ipcmd,
+		      u32 wd)
+{
+	u32 rd = 0x0;
+
+	if (ipcmd == SD_CC_IWR || ((ipcmd & 0x0000FFFF) == SD_CC_IMS))
+		writel(wd & 0x0000FFFF, &regs->iptxdat);
+
+	/* set slave address for every command */
+	writel(mem_addr, &regs->ipcr0);
+
+	/* execute command */
+	writel(0xA55A0000 | (ipcmd & 0x0000FFFF), &regs->ipcmd);
+
+	imxrt_sdram_wait_ipcmd_done(regs);
+
+	if (ipcmd == SD_CC_IRD)
+		rd = readl(&regs->iprxdat);
+
+	return rd;
+}
+
+int imxrt_sdram_init(struct udevice *dev)
+{
+	struct imxrt_sdram_params *params = dev_get_platdata(dev);
+	struct imxrt_sdram_mux *mux = params->sdram_mux;
+	struct imxrt_sdram_control *ctrl = params->sdram_control;
+	struct imxrt_sdram_timing *time = params->sdram_timing;
+	struct imxrt_semc_regs *regs = params->base;
+	struct bank_params *bank_params = params->bank_params;
+	int i;
+
+	/* enable the SEMC controller */
+	clrbits_le32(&regs->mcr, SEMC_MCR_MDIS);
+	/* set DQS mode from DQS pad */
+	setbits_le32(&regs->mcr, SEMC_MCR_DQSMD);
+
+	for (i = 0; i < params->no_sdram_banks; bank_params++, i++)
+		writel((bank_params->base_address & 0xfffff000)
+		       | bank_params->memory_size << SEMC_BR_MS_SHIFT
+		       | SEMC_BR_VLD_MASK,
+		       &regs->br[bank_params->target_bank]);
+
+	writel(mux->a8 << SEMC_IOCR_MUX_A8_SHIFT
+		| mux->csx0 << SEMC_IOCR_MUX_CSX0_SHIFT
+		| mux->csx1 << SEMC_IOCR_MUX_CSX1_SHIFT
+		| mux->csx2 << SEMC_IOCR_MUX_CSX2_SHIFT
+		| mux->csx3 << SEMC_IOCR_MUX_CSX3_SHIFT
+		| mux->rdy << SEMC_IOCR_MUX_RDY_SHIFT,
+		&regs->iocr);
+
+	writel(ctrl->memory_width << SEMC_SDRAMCR0_PS_SHIFT

drivers/ram/imxrt_sdram.c line 223

Quoted 10 lines
drivers/ram/imxrt_sdram.c new file +10 -0
+		| ctrl->burst_len << SEMC_SDRAMCR0_BL_SHIFT
+		| ctrl->no_columns << SEMC_SDRAMCR0_COL_SHIFT
+		| ctrl->cas_latency << SEMC_SDRAMCR0_CL_SHIFT,
+		&regs->sdramcr0);
+
+	writel(time->trp << SEMC_SDRAMCR1_PRE2ACT_SHIFT
+		| time->trcd << SEMC_SDRAMCR1_ACT2RW_SHIFT
+		| time->trfc << SEMC_SDRAMCR1_RFRC_SHIFT
+		| time->twr << SEMC_SDRAMCR1_WRC_SHIFT,
+		&regs->sdramcr1);

Here I've tried to use classic sdram timing as parameters but...

drivers/ram/imxrt_sdram.c line 234

Quoted 10 lines
drivers/ram/imxrt_sdram.c new file +10 -0
+	/*
+	 *	SDRAMCR1:
+	 *	PRE2ACT => tRP(0x02)
+	 *	ACT2RW => tRCD(0x02)
+	 *	RFRC => tRFC(0x09)
+	 *	WRC => tWR(0x01)
+	 *	TODO: CKEOFF => CKE Off minimum time(0x05)
+	 *	TODO: ACT2PRE => ACT to Precharge minimum time(0x06)
+	 */
+	writel(0x00010920, &regs->sdramcr2);

...in this register and the next one there are parameters like CKEOFF and ACT2PRE impossible to lead to classic tXXX sdram timing parameters. I've done this way inspired by stm32-sdram, but maybe U should go back using i.MXRT names(i.e. PRE2ACT instead of tRP) and list all possible useful registers in DM as I've done for tRP etc.
What do you think?

And...

Quoted 335 lines
drivers/ram/imxrt_sdram.c new file +170 -0
+	/*
+	 *	SDRAMCR2:
+	 *	SRRC => Self Refresh Recovery Time(0x20)
+	 *	REF2REF => tRFC(0x09)
+	 *	ACT2ACT => tRRD(0x01)
+	 *	ITO => SDRAM idle timeout(0x00)
+	 */
+	writel(0x50210A09, &regs->sdramcr3);
+	/*
+	 *	SDRAMCR3:
+	 *	REN => Refresh Enable(0x01)
+	 *	REBL => Refresh Burst Length(0x04)
+	 *	PRESCALE => Prescaler timer pediod(0x0A)
+	 *	RT => Refresh timer period(0x21)
+	 *	UT => Refresh urgent threshold(0x50)
+	 */ > +	mdelay(250);
+	imxrt_sdram_ipcmd(regs, bank_params->base_address, SD_CC_IPREA,
+			  0x0000);
+	imxrt_sdram_ipcmd(regs, bank_params->base_address, SD_CC_IAF,
+			  0x0000);
+	imxrt_sdram_ipcmd(regs, bank_params->base_address, SD_CC_IAF,
+			  0x0000);
+	imxrt_sdram_ipcmd(regs, bank_params->base_address, SD_CC_IMS,
+			  ctrl->burst_len | (ctrl->cas_latency << 4));
+	mdelay(250);
+
+	return 0;
+}
+
+static int imxrt_semc_ofdata_to_platdata(struct udevice *dev)
+{
+	struct imxrt_sdram_params *params = dev_get_platdata(dev);
+	ofnode bank_node;
+	u8 bank = 0;
+
+	params->sdram_mux =
+		(struct imxrt_sdram_mux *)
+		 dev_read_u8_array_ptr(dev,
+				       "fsl,sdram-mux",
+				       sizeof(struct imxrt_sdram_mux));
+	if (!params->sdram_mux) {
+		pr_err("fsl,sdram-mux not found");
+		return -EINVAL;
+	}
+
+	params->sdram_control =
+		(struct imxrt_sdram_control *)
+		 dev_read_u8_array_ptr(dev,
+				       "fsl,sdram-control",
+				       sizeof(struct imxrt_sdram_control));
+	if (!params->sdram_control) {
+		pr_err("fsl,sdram-control not found");
+		return -EINVAL;
+	}
+
+	params->sdram_timing =
+		(struct imxrt_sdram_timing *)
+		 dev_read_u8_array_ptr(dev,
+				       "fsl,sdram-timing",
+				       sizeof(struct imxrt_sdram_timing));
+	if (!params->sdram_timing) {
+		pr_err("fsl,sdram-timing not found");
+		return -EINVAL;
+	}
+
+	dev_for_each_subnode(bank_node, dev) {
+		struct bank_params *bank_params;
+		char *bank_name;
+		int ret;
+
+		/* extract the bank index from DT */
+		bank_name = (char *)ofnode_get_name(bank_node);
+		strsep(&bank_name, "@");
+		if (!bank_name) {
+			pr_err("missing sdram bank index");
+			return -EINVAL;
+		}
+
+		bank_params = &params->bank_params[bank];
+		strict_strtoul(bank_name, 10,
+			       (unsigned long int *)&bank_params->target_bank);
+		if (bank_params->target_bank >= MAX_SDRAM_BANK) {
+			pr_err("Found bank %d , but only bank 0,1,2,3 are supported",
+			       bank_params->target_bank);
+			return -EINVAL;
+		}
+
+		ret = ofnode_read_u32(bank_node,
+				      "fsl,memory-size",
+				      &bank_params->memory_size);
+		if (ret < 0) {
+			pr_err("fsl,memory-size not found");
+			return -EINVAL;
+		}
+
+		ret = ofnode_read_u32(bank_node,
+				      "fsl,base-address",
+				      &bank_params->base_address);
+		if (ret < 0) {
+			pr_err("fsl,base-address not found");
+			return -EINVAL;
+		}
+
+		debug("Found bank %s %u\n", bank_name,
+		      bank_params->target_bank);
+		bank++;
+	}
+
+	params->no_sdram_banks = bank;
+	debug("%s, no of banks = %d\n", __func__, params->no_sdram_banks);
+
+	return 0;
+}
+
+static int imxrt_semc_probe(struct udevice *dev)
+{
+	struct imxrt_sdram_params *params = dev_get_platdata(dev);
+	int ret;
+	fdt_addr_t addr;
+
+	addr = dev_read_addr(dev);
+	if (addr == FDT_ADDR_T_NONE)
+		return -EINVAL;
+
+	params->base = (struct imxrt_semc_regs *)addr;
+
+#ifdef CONFIG_CLK
+	struct clk clk;
+
+	ret = clk_get_by_index(dev, 0, &clk);
+	if (ret < 0)
+		return ret;
+
+	ret = clk_enable(&clk);
+
+	if (ret) {
+		dev_err(dev, "failed to enable clock\n");
+		return ret;
+	}
+#endif
+	ret = imxrt_sdram_init(dev);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
+static int imxrt_semc_get_info(struct udevice *dev, struct ram_info *info)
+{
+	return 0;
+}
+
+static struct ram_ops imxrt_semc_ops = {
+	.get_info = imxrt_semc_get_info,
+};
+
+static const struct udevice_id imxrt_semc_ids[] = {
+	{ .compatible = "fsl,imxrt-semc", .data = 0 },
+	{ }
+};
+
+U_BOOT_DRIVER(imxrt_semc) = {
+	.name = "imxrt_semc",
+	.id = UCLASS_RAM,
+	.of_match = imxrt_semc_ids,
+	.ops = &imxrt_semc_ops,
+	.ofdata_to_platdata = imxrt_semc_ofdata_to_platdata,
+	.probe = imxrt_semc_probe,
+	.platdata_auto_alloc_size = sizeof(struct imxrt_sdram_params),
+};
include/dt-bindings/memory/imxrt-sdram.h new file +158 -0
new file mode 100644
index 0000000000..dff6d4401e
@@ -0,0 +1,168 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Copyright (C) 2019
+ * Author(s): Giulio Benetti <[email protected]>
+ */
+
+#ifndef DT_BINDINGS_IMXRT_SDRAM_H
+#define DT_BINDINGS_IMXRT_SDRAM_H
+
+#define MEM_SIZE_4K		0x00
+#define MEM_SIZE_8K		0x01
+#define MEM_SIZE_16K		0x02
+#define MEM_SIZE_32K		0x03
+#define MEM_SIZE_64K		0x04
+#define MEM_SIZE_128K		0x05
+#define MEM_SIZE_256K		0x06
+#define MEM_SIZE_512K		0x07
+#define MEM_SIZE_1M		0x08
+#define MEM_SIZE_2M		0x09
+#define MEM_SIZE_4M		0x0A
+#define MEM_SIZE_8M		0x0B
+#define MEM_SIZE_16M		0x0C
+#define MEM_SIZE_32M		0x0D
+#define MEM_SIZE_64M		0x0E
+#define MEM_SIZE_128M		0x0F
+#define MEM_SIZE_256M		0x10
+#define MEM_SIZE_512M		0x11
+#define MEM_SIZE_1G		0x12
+#define MEM_SIZE_2G		0x13
+#define MEM_SIZE_4G		0x14
+
+#define MUX_A8_SDRAM_A8		0x0
+#define MUX_A8_NAND_CE		0x1
+#define MUX_A8_NOR_CE		0x2
+#define MUX_A8_PSRAM_CE		0x3
+#define MUX_A8_DBI_CSX		0x4
+
+#define MUX_CSX0_NOR_PSRAM_A24	0x0
+#define MUX_CSX0_SDRAM_CS1	0x1
+#define MUX_CSX0_SDRAM_CS2	0x2
+#define MUX_CSX0_SDRAM_CS3	0x3
+#define MUX_CSX0_NAND_CE	0x4
+#define MUX_CSX0_NOR_CE		0x5
+#define MUX_CSX0_PSRAM_CE	0x6
+#define MUX_CSX0_DBI_CSX	0x7
+
+#define MUX_CSX1_NOR_PSRAM_A25	0x0
+#define MUX_CSX1_SDRAM_CS1	0x1
+#define MUX_CSX1_SDRAM_CS2	0x2
+#define MUX_CSX1_SDRAM_CS3	0x3
+#define MUX_CSX1_NAND_CE	0x4
+#define MUX_CSX1_NOR_CE		0x5
+#define MUX_CSX1_PSRAM_CE	0x6
+#define MUX_CSX1_DBI_CSX	0x7
+
+#define MUX_CSX2_NOR_PSRAM_A26	0x0
+#define MUX_CSX2_SDRAM_CS1	0x1
+#define MUX_CSX2_SDRAM_CS2	0x2
+#define MUX_CSX2_SDRAM_CS3	0x3
+#define MUX_CSX2_NAND_CE	0x4
+#define MUX_CSX2_NOR_CE		0x5
+#define MUX_CSX2_PSRAM_CE	0x6
+#define MUX_CSX2_DBI_CSX	0x7
+
+#define MUX_CSX3_NOR_PSRAM_A27	0x0
+#define MUX_CSX3_SDRAM_CS1	0x1
+#define MUX_CSX3_SDRAM_CS2	0x2
+#define MUX_CSX3_SDRAM_CS3	0x3
+#define MUX_CSX3_NAND_CE	0x4
+#define MUX_CSX3_NOR_CE		0x5
+#define MUX_CSX3_PSRAM_CE	0x6
+#define MUX_CSX3_DBI_CSX	0x7
+
+#define MUX_RDY_NAND_RDY_WAIT	0x0
+#define MUX_RDY_SDRAM_CS1	0x1
+#define MUX_RDY_SDRAM_CS2	0x2
+#define MUX_RDY_SDRAM_CS3	0x3
+#define MUX_RDY_NOR_CE		0x4
+#define MUX_RDY_PSRAM_CE	0x5
+#define MUX_RDY_DBI_CSX		0x6
+#define MUX_RDY_NOR_PSRAM_A27	0x7
+
+#define MEM_WIDTH_8BITS		0x0
+#define MEM_WIDTH_16BITS	0x1
+
+#define BL_1			0x0
+#define BL_2			0x1
+#define BL_4			0x2
+#define BL_8			0x3
+
+#define COL_12BITS		0x0
+#define COL_11BITS		0x1
+#define COL_10BITS		0x2
+#define COL_9BITS		0x3
+
+#define CL_1			0x0
+#define CL_2			0x2
+#define CL_3			0x3
+
+#define TRP_1			0x0
+#define TRP_2			0x1
+#define TRP_3			0x2
+#define TRP_4			0x3
+#define TRP_5			0x4
+#define TRP_6			0x5
+#define TRP_7			0x6
+#define TRP_8			0x7
+#define TRP_9			0x8
+#define TRP_10			0x9
+#define TRP_11			0xA
+#define TRP_12			0xB
+#define TRP_13			0xC
+#define TRP_14			0xD
+#define TRP_15			0xE
+#define TRP_16			0xF
+
+#define TRCD_1			0x0
+#define TRCD_2			0x1
+#define TRCD_3			0x2
+#define TRCD_4			0x3
+#define TRCD_5			0x4
+#define TRCD_6			0x5
+#define TRCD_7			0x6
+#define TRCD_8			0x7
+#define TRCD_9			0x8
+#define TRCD_10			0x9
+#define TRCD_11			0xA
+#define TRCD_12			0xB
+#define TRCD_13			0xC
+#define TRCD_14			0xD
+#define TRCD_15			0xE
+#define TRCD_16			0xF
+
+#define TRFC_1			0x0
+#define TRFC_2			0x1
+#define TRFC_3			0x2
+#define TRFC_4			0x3
+#define TRFC_5			0x4
+#define TRFC_6			0x5
+#define TRFC_7			0x6
+#define TRFC_8			0x7
+#define TRFC_9			0x8
+#define TRFC_10			0x9
+#define TRFC_11			0xA
+#define TRFC_12			0xB
+#define TRFC_13			0xC
+#define TRFC_14			0xD
+#define TRFC_15			0xE
+#define TRFC_16			0xF
+
+#define TWR_1			0x0
+#define TWR_2			0x1
+#define TWR_3			0x2
+#define TWR_4			0x3
+#define TWR_5			0x4
+#define TWR_6			0x5
+#define TWR_7			0x6
+#define TWR_8			0x7

include/dt-bindings/memory/imxrt-sdram.h line 168

Quoted 10 lines
include/dt-bindings/memory/imxrt-sdram.h new file +10 -0
+#define TWR_9			0x8
+#define TWR_10			0x9
+#define TWR_11			0xA
+#define TWR_12			0xB
+#define TWR_13			0xC
+#define TWR_14			0xD
+#define TWR_15			0xE
+#define TWR_16			0xF
+
+#endif

...is it ok listing every possible value for DM parameter? I mean, some of them would be 8-bit, this would mean having 256 cases, that sound very ugly to me.

Thanks in advance

Kind regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
maintainer
#6 lore raw

RFC PATCH 4/5 ram: add SDRAM driver for i.MXRT SoCs

Hi Giulio,

Quoted 6 lines · Giulio Benetti

...in this register and the next one there are parameters like CKEOFF and ACT2PRE impossible to lead to classic tXXX sdram timing parameters. I've done this way inspired by stm32-sdram, but maybe U should go back using i.MXRT names(i.e. PRE2ACT instead of tRP) and list all possible useful registers in DM as I've done for tRP etc.
What do you think?

I think it is OK to use the i.MXRT names.

#define TWR_1 0x0

Quoted 14 lines
Quoted 14 lines
include/dt-bindings/memory/imxrt-sdram.h new file +14 -0
+#define TWR_2                        0x1
+#define TWR_3                        0x2
+#define TWR_4                        0x3
+#define TWR_5                        0x4
+#define TWR_6                        0x5
+#define TWR_7                        0x6
+#define TWR_8                        0x7
+#define TWR_9                        0x8
+#define TWR_10                       0x9
+#define TWR_11                       0xA
+#define TWR_12                       0xB
+#define TWR_13                       0xC
+#define TWR_14                       0xD
+#define TWR_15                       0xE
Quoted 8 lines

include/dt-bindings/memory/imxrt-sdram.h line 168

Quoted 4 lines
include/dt-bindings/memory/imxrt-sdram.h new file +3 -0
+#define TWR_16                       0xF
+
+#endif

...is it ok listing every possible value for DM parameter? I mean, some of them would be 8-bit, this would mean having 256 cases, that sound very ugly to me.

It doesn't seem necessary to write all 256 cases. I would suggest to write the direct hex number.

#7 lore raw

RFC PATCH 4/5 ram: add SDRAM driver for i.MXRT SoCs

Quoted 5 lines · Fabio Estevam

Hi Giulio,

On Thu, Oct 31, 2019 at 9:11 AM Giulio Benetti
<[email protected]> wrote:

Quoted 8 lines
Quoted 6 lines

...in this register and the next one there are parameters like CKEOFF and ACT2PRE impossible to lead to classic tXXX sdram timing parameters. I've done this way inspired by stm32-sdram, but maybe U should go back using i.MXRT names(i.e. PRE2ACT instead of tRP) and list all possible useful registers in DM as I've done for tRP etc.
What do you think?

I think it is OK to use the i.MXRT names.

Ok

Quoted 24 lines

#define TWR_1 0x0

Quoted 14 lines
Quoted 14 lines
include/dt-bindings/memory/imxrt-sdram.h new file +14 -0
+#define TWR_2                        0x1
+#define TWR_3                        0x2
+#define TWR_4                        0x3
+#define TWR_5                        0x4
+#define TWR_6                        0x5
+#define TWR_7                        0x6
+#define TWR_8                        0x7
+#define TWR_9                        0x8
+#define TWR_10                       0x9
+#define TWR_11                       0xA
+#define TWR_12                       0xB
+#define TWR_13                       0xC
+#define TWR_14                       0xD
+#define TWR_15                       0xE
Quoted 8 lines

include/dt-bindings/memory/imxrt-sdram.h line 168

Quoted 4 lines
include/dt-bindings/memory/imxrt-sdram.h new file +3 -0
+#define TWR_16                       0xF
+
+#endif

...is it ok listing every possible value for DM parameter? I mean, some of them would be 8-bit, this would mean having 256 cases, that sound very ugly to me.

Quoted 3 lines

It doesn't seem necessary to write all 256 cases. I would suggest to write the direct hex number.

Well, thanks a lot!

Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
#8 lore raw

RFC PATCH 5/5 Add support for the NXP IMXRT1050-EVK board

In reply to Giulio Benetti
---
 arch/arm/dts/Makefile                         |   2 +
 arch/arm/dts/imxrt1050-evk.dts                | 124 ++++++++
 arch/arm/dts/imxrt1050.dtsi                   |  73 +++++
 arch/arm/mach-imx/imxrt/Kconfig               |  11 +
 board/freescale/imxrt1050-evk/Kconfig         |  19 ++
 board/freescale/imxrt1050-evk/MAINTAINERS     |   6 +
 board/freescale/imxrt1050-evk/Makefile        |   6 +
 board/freescale/imxrt1050-evk/imxrt1050-evk.c |  94 ++++++
 configs/imxrt1050-evk_defconfig               |  52 ++++
 include/configs/imxrt1050-evk.h               |  68 +++++
 include/dt-bindings/clock/imxrt-clock.h       | 272 ++++++++++++++++++
 11 files changed, 727 insertions(+)
 create mode 100644 arch/arm/dts/imxrt1050-evk.dts
 create mode 100644 arch/arm/dts/imxrt1050.dtsi
 create mode 100644 board/freescale/imxrt1050-evk/Kconfig
 create mode 100644 board/freescale/imxrt1050-evk/MAINTAINERS
 create mode 100644 board/freescale/imxrt1050-evk/Makefile
 create mode 100644 board/freescale/imxrt1050-evk/imxrt1050-evk.c
 create mode 100644 configs/imxrt1050-evk_defconfig
 create mode 100644 include/configs/imxrt1050-evk.h
 create mode 100644 include/dt-bindings/clock/imxrt-clock.h
arch/arm/dts/Makefile +2 -0
index 62da168ef8..5ac490fa5e 100644
@@ -631,6 +631,8 @@ dtb-$(CONFIG_ARCH_IMX8) += \
 
 dtb-$(CONFIG_ARCH_IMX8M) += fsl-imx8mq-evk.dtb
 
+dtb-$(CONFIG_ARCH_IMXRT) += imxrt1050-evk.dtb
+
 dtb-$(CONFIG_RCAR_GEN2) += \
 	r8a7790-lager-u-boot.dtb \
 	r8a7790-stout-u-boot.dtb \
arch/arm/dts/imxrt1050-evk.dts new file +124 -0

124 lines not on this page · raw message

arch/arm/dts/imxrt1050.dtsi new file +73 -0

73 lines not on this page · raw message

arch/arm/mach-imx/imxrt/Kconfig +11 -0
index 1da002336b..45dd8fcd76 100644
@@ -3,4 +3,15 @@ if ARCH_IMXRT
 config SYS_SOC
 	default "imxrt"
 
+choice
+	prompt "IMXRT board select"
+	optional
+
+config TARGET_IMXRT1050_EVK
+        bool "Support imxrt1050 EVK board"
+
+endchoice
+
+source "board/freescale/imxrt1050-evk/Kconfig"
+
 endif
board/freescale/imxrt1050-evk/Kconfig new file +19 -0
new file mode 100644
index 0000000000..0c07c0c5e0
@@ -0,0 +1,19 @@
+if TARGET_IMXRT1050_EVK
+
+config SYS_BOARD
+	string
+	default "imxrt1050-evk"
+
+config SYS_VENDOR
+	string
+	default "freescale"
+
+config SYS_SOC
+	string
+	default "imxrt"
+
+config SYS_CONFIG_NAME
+	string
+	default "imxrt1050-evk"
+
+endif
board/freescale/imxrt1050-evk/MAINTAINERS new file +6 -0
new file mode 100644
index 0000000000..a872855452
@@ -0,0 +1,6 @@
+IMXRT1050 EVALUATION KIT
+M:	Giulio Benetti <[email protected]>
+S:	Maintained
+F:	board/freescale/imxrt1050-evk
+F:	include/configs/imxrt1050-evk.h
+F:	configs/imxrt1050-evk_defconfig
board/freescale/imxrt1050-evk/Makefile new file +6 -0
new file mode 100644
index 0000000000..0e984d1d7a
@@ -0,0 +1,6 @@
+# SPDX-License-Identifier: GPL-2.0+
+#
+# Copyright (C) 2019
+# Author(s): Giulio Benetti <[email protected]>
+
+obj-y	:= imxrt1050-evk.o
board/freescale/imxrt1050-evk/imxrt1050-evk.c new file +94 -0

94 lines not on this page · raw message

configs/imxrt1050-evk_defconfig new file +52 -0

52 lines not on this page · raw message

include/configs/imxrt1050-evk.h new file +68 -0

68 lines not on this page · raw message

include/dt-bindings/clock/imxrt-clock.h new file +272 -0

272 lines not on this page · raw message

Signature · 1 line
2.20.1
maintainer
#9 lore raw

RFC PATCH 5/5 Add support for the NXP IMXRT1050-EVK board

Hi Giulio,

On Wed, Oct 30, 2019 at 6:09 PM Giulio Benetti
<[email protected]> wrote:

Please add a commit log that briefly describes the board.

Quoted 10 lines
---
 arch/arm/dts/Makefile                         |   2 +
 arch/arm/dts/imxrt1050-evk.dts                | 124 ++++++++
 arch/arm/dts/imxrt1050.dtsi                   |  73 +++++
 arch/arm/mach-imx/imxrt/Kconfig               |  11 +
 board/freescale/imxrt1050-evk/Kconfig         |  19 ++
 board/freescale/imxrt1050-evk/MAINTAINERS     |   6 +
 board/freescale/imxrt1050-evk/Makefile        |   6 +

Please add a board/freescale/imxrt1050-evk/README that explains how to build, flash the U-Boot binary and boot.

Quoted 6 lines
 board/freescale/imxrt1050-evk/imxrt1050-evk.c |  94 ++++++
 configs/imxrt1050-evk_defconfig               |  52 ++++
 include/configs/imxrt1050-evk.h               |  68 +++++
 include/dt-bindings/clock/imxrt-clock.h       | 272 ++++++++++++++++++
 11 files changed, 727 insertions(+)
 create mode 100644 arch/arm/dts/imxrt1050-evk.dts
Quoted 8 lines
 create mode 100644 arch/arm/dts/imxrt1050.dtsi
 create mode 100644 board/freescale/imxrt1050-evk/Kconfig
 create mode 100644 board/freescale/imxrt1050-evk/MAINTAINERS
 create mode 100644 board/freescale/imxrt1050-evk/Makefile
 create mode 100644 board/freescale/imxrt1050-evk/imxrt1050-evk.c
 create mode 100644 configs/imxrt1050-evk_defconfig
 create mode 100644 include/configs/imxrt1050-evk.h
 create mode 100644 include/dt-bindings/clock/imxrt-clock.h

This imxrt-clock.h header and the arch/arm/dts/imxrt1050.dts is common imxrt code and not related to the evk board, so better put them on a separate patch.

#10 lore raw

RFC PATCH 5/5 Add support for the NXP IMXRT1050-EVK board

Hi Fabio,

Quoted 6 lines · Fabio Estevam

Hi Giulio,

On Wed, Oct 30, 2019 at 6:09 PM Giulio Benetti
<[email protected]> wrote:

Please add a commit log that briefly describes the board.

Yes.

Quoted 11 lines
Quoted 10 lines
---
  arch/arm/dts/Makefile                         |   2 +
  arch/arm/dts/imxrt1050-evk.dts                | 124 ++++++++
  arch/arm/dts/imxrt1050.dtsi                   |  73 +++++
  arch/arm/mach-imx/imxrt/Kconfig               |  11 +
  board/freescale/imxrt1050-evk/Kconfig         |  19 ++
  board/freescale/imxrt1050-evk/MAINTAINERS     |   6 +
  board/freescale/imxrt1050-evk/Makefile        |   6 +
Quoted 2 lines

Please add a board/freescale/imxrt1050-evk/README that explains how to build, flash the U-Boot binary and boot.

Right.

Quoted 15 lines
Quoted 5 lines
  board/freescale/imxrt1050-evk/imxrt1050-evk.c |  94 ++++++
  configs/imxrt1050-evk_defconfig               |  52 ++++
  include/configs/imxrt1050-evk.h               |  68 +++++
  include/dt-bindings/clock/imxrt-clock.h       | 272 ++++++++++++++++++
  11 files changed, 727 insertions(+)
Quoted 9 lines

create mode 100644 arch/arm/dts/imxrt1050-evk.dts create mode 100644 arch/arm/dts/imxrt1050.dtsi
create mode 100644 board/freescale/imxrt1050-evk/Kconfig create mode 100644 board/freescale/imxrt1050-evk/MAINTAINERS create mode 100644 board/freescale/imxrt1050-evk/Makefile create mode 100644 board/freescale/imxrt1050-evk/imxrt1050-evk.c create mode 100644 configs/imxrt1050-evk_defconfig create mode 100644 include/configs/imxrt1050-evk.h create mode 100644 include/dt-bindings/clock/imxrt-clock.h

Quoted 3 lines

This imxrt-clock.h header and the arch/arm/dts/imxrt1050.dts is common imxrt code and not related to the evk board, so better put them on a separate patch.

Ok, already done since I'm working right on clock driver now.

Thanks for reviewing my patches, can you also take a look at this [1]? Because I don't know how to proceed with sdram driver.

Thanks in advance

[1]: https://lists.denx.de/pipermail/u-boot/2019-October/388905.html

Best regards

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas
maintainer
#11 lore raw

cover WIP Add support for i.MXRT family

In reply to Giulio Benetti

Hi Giulio,

Quoted 8 lines · Giulio Benetti

This patchset is a WIP for adding i.MXRT family.
It provides:
- soc family entry
- pinctrl driver
- serial driver tweaking
- partial sdram controller driver
- imxrt1050-evk board partial support

Where do you store the U-Boot environment? Is there a eSDHC driver for it, for example?

#12 lore raw

cover WIP Add support for i.MXRT family

Hi Fabio,

Quoted 13 lines · Fabio Estevam

Hi Giulio,

Quoted 8 lines · Giulio Benetti

This patchset is a WIP for adding i.MXRT family.
It provides:
- soc family entry
- pinctrl driver
- serial driver tweaking
- partial sdram controller driver
- imxrt1050-evk board partial support

Quoted 2 lines

Where do you store the U-Boot environment?Is there a eSDHC driver for it, for example?

Yes, I want to use eSDHC to store there u-boot environment and I'm still working on it.

Signature · 2 lines
Giulio Benetti
Benetti Engineering sas