Skip to contentSkip to conversation

sta_info: fix insane values in iw sta dump "inactive time"

PATCH In review Ahmed Zaki 2 participants 3 messages Oct 30, 2019 – Oct 31, 2019 mac80211

lore
Share & tools
lore

Ahmed Zaki

author
#0 lore raw

cover sta_info: fix insane values in iw sta dump "inactive time"

While working on an IBSS network with ath10k-ct, the iw station dump shows insanly high values in the "inactive time". The values are clearly the initial jiifies of the system.

Debugging showed that this happens when the ieee80211_sta_last_active is called while last_ack == 0. In this case, it returns zero and the inactive time shows the system jiffies. This continues until the jiffies wrap back to zero (about 5 minutes).

Ahmed Zaki (1):
sta_info: fix insane values in iw sta dump "inactive time"

 net/mac80211/sta_info.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/1 sta_info: fix insane values in iw sta dump "inactive time"

In the first 5 mins after boot (initial jiffies), ieee80211_sta_last_active() returns zero in case last_ack is zero. This leads to insane values appearing in "inactive time".

Fix by returning last_rx if last_ack == 0.

---
 net/mac80211/sta_info.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
net/mac80211/sta_info.c +2 -1
index bd11fef2139f..428866ff7c0a 100644
@@ -2457,7 +2457,8 @@ unsigned long ieee80211_sta_last_active(struct sta_info *sta)
 {
 	struct ieee80211_sta_rx_stats *stats = sta_get_last_rx_stats(sta);
 
-	if (time_after(stats->last_rx, sta->status_stats.last_ack))
+	if (!sta->status_stats.last_ack ||
+		time_after(stats->last_rx, sta->status_stats.last_ack))
 		return stats->last_rx;
 	return sta->status_stats.last_ack;
 }
Signature · 1 line
2.17.1