Skip to contentSkip to conversation

net/ice: remove GTPU tunnel support for inner L4

PATCH Superseded Yahui Cao 2 participants 5 messages Oct 31, 2019 – Nov 1, 2019 Network drivers

lore
Share & tools
lore

Yahui Cao

author
#0 lore raw

PATCH 1/1 net/ice: remove GTPU tunnel support for inner L4

Fixes efc16c621415 ("net/ice: support flow director GTPU tunnel")
---
 drivers/net/ice/ice_fdir_filter.c | 4 ----
 1 file changed, 4 deletions(-)
drivers/net/ice/ice_fdir_filter.c +0 -4
index 736ccd54e..d80dafa20 100644
@@ -128,10 +128,6 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
 	{pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
 				       ICE_FDIR_INSET_VXLAN_IPV4_SCTP,       ICE_INSET_NONE},
 	{pattern_eth_ipv4_gtpu_ipv4,   ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-	{pattern_eth_ipv4_gtpu_ipv4_tcp,
-				       ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-	{pattern_eth_ipv4_gtpu_ipv4_udp,
-				       ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
 };
 
 static struct ice_flow_parser ice_fdir_parser_os;
Signature · 1 line
2.17.1
#1 lore raw

Hi, yahui

Prefer to give more details like why we need this patch in commit log.

Thanks,
Xiaolong

Quoted 25 lines · Yahui Cao
Fixes efc16c621415 ("net/ice: support flow director GTPU tunnel")

---
drivers/net/ice/ice_fdir_filter.c | 4 ----

1 file changed, 4 deletions(-)
drivers/net/ice/ice_fdir_filter.c +0 -4
index 736ccd54e..d80dafa20 100644
@@ -128,10 +128,6 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
 	{pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
 				       ICE_FDIR_INSET_VXLAN_IPV4_SCTP,       ICE_INSET_NONE},
 	{pattern_eth_ipv4_gtpu_ipv4,   ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-	{pattern_eth_ipv4_gtpu_ipv4_tcp,
-				       ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-	{pattern_eth_ipv4_gtpu_ipv4_udp,
-				       ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
 };
 
 static struct ice_flow_parser ice_fdir_parser_os;
Signature · 1 line
2.17.1
author
#2 lore raw

PATCH v2 1/1 net/ice: remove GTPU tunnel support for inner L4

In reply to Yahui Cao

Currently, share code only support inner L3 matching.

Fixes efc16c621415 ("net/ice: support flow director GTPU tunnel")
---
 drivers/net/ice/ice_fdir_filter.c | 13 -------------
 1 file changed, 13 deletions(-)
drivers/net/ice/ice_fdir_filter.c +0 -13
index 736ccd54e..2e8570f16 100644
@@ -66,15 +66,6 @@
 #define ICE_FDIR_INSET_GTPU_IPV4 (\
 	ICE_INSET_GTPU_TEID | ICE_INSET_GTPU_QFI)
 
-#define ICE_FDIR_INSET_GTPU_IPV4_TCP (\
-	ICE_FDIR_INSET_GTPU_IPV4)
-
-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
-	ICE_FDIR_INSET_GTPU_IPV4)
-
-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
-	ICE_FDIR_INSET_GTPU_IPV4)
-
 static struct ice_pattern_match_item ice_fdir_pattern_os[] = {
 	{pattern_eth_ipv4,             ICE_FDIR_INSET_ETH_IPV4,              ICE_INSET_NONE},
 	{pattern_eth_ipv4_udp,         ICE_FDIR_INSET_ETH_IPV4_UDP,          ICE_INSET_NONE},
@@ -128,10 +119,6 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
 	{pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
 				       ICE_FDIR_INSET_VXLAN_IPV4_SCTP,       ICE_INSET_NONE},
 	{pattern_eth_ipv4_gtpu_ipv4,   ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-	{pattern_eth_ipv4_gtpu_ipv4_tcp,
-				       ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-	{pattern_eth_ipv4_gtpu_ipv4_udp,
-				       ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
 };
 
 static struct ice_flow_parser ice_fdir_parser_os;
Signature · 1 line
2.17.1
author
#3 lore raw

PATCH v3 1/1 net/ice: remove GTPU tunnel support for inner L4

Remove unsupported flow as title.

Fixes efc16c621415 ("net/ice: support flow director GTPU tunnel")
---
 drivers/net/ice/ice_fdir_filter.c | 13 -------------
 1 file changed, 13 deletions(-)
drivers/net/ice/ice_fdir_filter.c +0 -13
index 736ccd54e..2e8570f16 100644
@@ -66,15 +66,6 @@
 #define ICE_FDIR_INSET_GTPU_IPV4 (\
 	ICE_INSET_GTPU_TEID | ICE_INSET_GTPU_QFI)
 
-#define ICE_FDIR_INSET_GTPU_IPV4_TCP (\
-	ICE_FDIR_INSET_GTPU_IPV4)
-
-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
-	ICE_FDIR_INSET_GTPU_IPV4)
-
-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
-	ICE_FDIR_INSET_GTPU_IPV4)
-
 static struct ice_pattern_match_item ice_fdir_pattern_os[] = {
 	{pattern_eth_ipv4,             ICE_FDIR_INSET_ETH_IPV4,              ICE_INSET_NONE},
 	{pattern_eth_ipv4_udp,         ICE_FDIR_INSET_ETH_IPV4_UDP,          ICE_INSET_NONE},
@@ -128,10 +119,6 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
 	{pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
 				       ICE_FDIR_INSET_VXLAN_IPV4_SCTP,       ICE_INSET_NONE},
 	{pattern_eth_ipv4_gtpu_ipv4,   ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-	{pattern_eth_ipv4_gtpu_ipv4_tcp,
-				       ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-	{pattern_eth_ipv4_gtpu_ipv4_udp,
-				       ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
 };
 
 static struct ice_flow_parser ice_fdir_parser_os;
Signature · 1 line
2.17.1
Acked-by on v3 1/1 Applied
#4 lore raw
Quoted 43 lines · Yahui Cao

Remove unsupported flow as title.

Fixes efc16c621415 ("net/ice: support flow director GTPU tunnel")

---
drivers/net/ice/ice_fdir_filter.c | 13 -------------

1 file changed, 13 deletions(-)
drivers/net/ice/ice_fdir_filter.c +0 -13
index 736ccd54e..2e8570f16 100644
@@ -66,15 +66,6 @@
 #define ICE_FDIR_INSET_GTPU_IPV4 (\
 	ICE_INSET_GTPU_TEID | ICE_INSET_GTPU_QFI)
 
-#define ICE_FDIR_INSET_GTPU_IPV4_TCP (\
-	ICE_FDIR_INSET_GTPU_IPV4)
-
-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
-	ICE_FDIR_INSET_GTPU_IPV4)
-
-#define ICE_FDIR_INSET_GTPU_IPV4_UDP (\
-	ICE_FDIR_INSET_GTPU_IPV4)
-
 static struct ice_pattern_match_item ice_fdir_pattern_os[] = {
 	{pattern_eth_ipv4,             ICE_FDIR_INSET_ETH_IPV4,              ICE_INSET_NONE},
 	{pattern_eth_ipv4_udp,         ICE_FDIR_INSET_ETH_IPV4_UDP,          ICE_INSET_NONE},
@@ -128,10 +119,6 @@ static struct ice_pattern_match_item ice_fdir_pattern_comms[] = {
 	{pattern_eth_ipv4_udp_vxlan_eth_ipv4_sctp,
 				       ICE_FDIR_INSET_VXLAN_IPV4_SCTP,       ICE_INSET_NONE},
 	{pattern_eth_ipv4_gtpu_ipv4,   ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-	{pattern_eth_ipv4_gtpu_ipv4_tcp,
-				       ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
-	{pattern_eth_ipv4_gtpu_ipv4_udp,
-				       ICE_FDIR_INSET_GTPU_IPV4,             ICE_INSET_NONE},
 };
 
 static struct ice_flow_parser ice_fdir_parser_os;
Signature · 1 line
2.17.1

Applied to dpdk-next-net-intel. Thanks.