Skip to contentSkip to conversation

nfs-utils: do not depend on bash unnecessarily

PATCH New Alexander Kanavin 1 participant 2 messages Oct 31, 2019

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 nfs-utils: do not depend on bash unnecessarily

Nothing in the target install actually needs it.

---
 meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-connectivity/nfs-utils/nfs-utils_2.4.1.bb +1 -1
index 7e80354e4e7..eb32bccb57c 100644
@@ -9,7 +9,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=95f3a93a5c3c7888de623b46ea085a84"
 
 # util-linux for libblkid
 DEPENDS = "libcap libevent util-linux sqlite3 libtirpc"
-RDEPENDS_${PN} = "${PN}-client bash"
+RDEPENDS_${PN} = "${PN}-client"
 RRECOMMENDS_${PN} = "kernel-module-nfsd"
 
 inherit useradd
Signature · 1 line
2.17.1
#1 lore raw

PATCH 2/2 selftest: add a test for gpl3-free images

Existing tests check that adding a specific gpl3 package (bash) to core-image-minimal results in expected behaviour.

These tests check the ability to build two common images without gpl3 components in them:

1. core-image-minimal needs no further tweaks and works out of the box.

2. core-image-full-cmdline requires dropping the GNU packages that it pulls in; for good measure this tweaked image is verified with runtime tests.

These two tests allow dropping meta-gplv2 from being tested on the autobuilder, however there should be a community consensus first.

---
 .../oeqa/selftest/cases/incompatible_lic.py    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
meta/lib/oeqa/selftest/cases/incompatible_lic.py +18 -0
index 424a9e69c3e..904b5b4094a 100644
@@ -73,3 +73,21 @@ INCOMPATIBLE_LICENSE_pn-core-image-minimal = "GPL-3.0 LGPL-3.0"
 
         bitbake('core-image-minimal')
 
+class NoGPL3InImagesTests(OESelftestTestCase):
+    def test_core_image_minimal(self):
+        self.write_config("""
+INCOMPATIBLE_LICENSE_pn-core-image-minimal = "GPL-3.0 LGPL-3.0"
+""")
+        bitbake('core-image-minimal')
+
+    def test_core_image_full_cmdline(self):
+        self.write_config("""
+INHERIT += "testimage"\n
+INCOMPATIBLE_LICENSE_pn-core-image-full-cmdline = "GPL-3.0 LGPL-3.0"\n
+RDEPENDS_packagegroup-core-full-cmdline-utils_remove = "bash bc coreutils cpio ed findutils gawk grep mc mc-fish mc-helpers mc-helpers-perl sed tar time"\n
+RDEPENDS_packagegroup-core-full-cmdline-dev-utils_remove = "diffutils m4 make patch"\n
+RDEPENDS_packagegroup-core-full-cmdline-multiuser_remove = "gzip"\n
+""")
+        bitbake('core-image-full-cmdline')
+        bitbake('-c testimage core-image-full-cmdline')
+
Signature · 1 line
2.17.1