crypto: crypto4xx - fix double-free in crypto4xx_destroy_sdr
PATCH 1/1 crypto: crypto4xx - fix double-free in crypto4xx_destroy_sdr
This patch fixes a crash that can happen during probe when the available dma memory is not enough (this can happen if the crypto4xx is built as a module).
The descriptor window mapping would end up being free'd twice, once in crypto4xx_build_pdr() and the second time in crypto4xx_destroy_sdr().
Fixes 5d59ad6eea82 ("crypto: crypto4xx - fix crypto4xx_build_pdr, crypto4xx_build_sdr leak")
Signed-off-by Christian Lamparter <[email protected]>
--- drivers/crypto/amcc/crypto4xx_core.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
drivers/crypto/amcc/crypto4xx_core.c +1 -5
@@ -365,12 +365,8 @@ static u32 crypto4xx_build_sdr(struct crypto4xx_device *dev)dma_alloc_coherent (dev->core_dev->device,PPC4XX_SD_BUFFER_SIZE *PPC4XX_NUM_SD , &dev->scatter_buffer_pa,GFP_ATOMIC ); -if (!dev->scatter_buffer_va) { -dma_free_coherent (dev->core_dev->device, -sizeof (struct ce_sd ) *PPC4XX_NUM_SD , - dev->sdr, dev->sdr_pa); +if (!dev->scatter_buffer_va)return -ENOMEM ; - }for (i =0 ; i <PPC4XX_NUM_SD ; i++) { dev->sdr[i].ptr = dev->scatter_buffer_pa +
Signature · 1 line
2.24.0.rc2