sched/fair: Do not set skip buddy up the sched hierarchy
PATCH 1/1 sched/fair: Do not set skip buddy up the sched hierarchy
From: Venkatesh Pallipadi <[email protected]>
Setting skip buddy all the way up the hierarchy does not play well with intra-cgroup yield. One typical usecase of yield is when a thread in a cgroup wants to yield CPU to another thread within the same cgroup. For such a case, setting the skip buddy all the way up the hierarchy is counter-productive, as that results in CPU being yielded to a task in some other cgroup.
So, limit the skip effect only to the task requesting it.
--- kernel/sched/fair.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)
kernel/sched/fair.c +9 -2
@@ -6647,8 +6647,15 @@ static void set_next_buddy(struct sched_entity *se)static void set_skip_buddy (struct sched_entity *se) { -for_each_sched_entity (se) -cfs_rq_of (se)->skip = se; +/* +* One typical usecase of yield is when a thread in a cgroup +* wants to yield CPU to another thread within the same cgroup. +* For such a case, setting the skip buddy all the way up the +* hierarchy is counter-productive, as that results in CPU being +* yielded to a task in some other cgroup. So, only set skip +* for the task requesting it. +*/ +cfs_rq_of (se)->skip = se; }/*
Signature · 1 line
2.23.0.700.g56cf767bdb-goog
Vincent Guittot
maintainerQuoted 27 lines · Josh Don
From: Venkatesh Pallipadi <[email protected]>
Setting skip buddy all the way up the hierarchy does not play well with intra-cgroup yield. One typical usecase of yield is when a thread in a cgroup wants to yield CPU to another thread within the same cgroup. For such a case, setting the skip buddy all the way up the hierarchy is counter-productive, as that results in CPU being yielded to a task in some other cgroup.
So, limit the skip effect only to the task requesting it.
Signed-off-by Josh Don <[email protected]>--- kernel/sched/fair.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-)kernel/sched/fair.c +0
-2@@ -6647,8 +6647,15 @@ static void set_next_buddy(struct sched_entity *se)static void set_skip_buddy (struct sched_entity *se) { -for_each_sched_entity (se) -cfs_rq_of (se)->skip = se;
kernel/sched/fair.c static void set_next_buddy(struct sched_entity *se) · line 6659
Quoted 10 lines
kernel/sched/fair.c +9
-0+/* +* One typical usecase of yield is when a thread in a cgroup +* wants to yield CPU to another thread within the same cgroup. +* For such a case, setting the skip buddy all the way up the +* hierarchy is counter-productive, as that results in CPU being +* yielded to a task in some other cgroup. So, only set skip +* for the task requesting it. +*/ +cfs_rq_of (se)->skip = se; }
You should also update __clear_buddies_skip to only clear this skip
Quoted 5 lines
kernel/sched/fair.c +0
-1/* -- 2.23.0.700.g56cf767bdb-goog
PATCH v2 1/1 sched/fair: Do not set skip buddy up the sched hierarchy
From: Venkatesh Pallipadi <[email protected]>
Setting skip buddy all the way up the hierarchy does not play well with intra-cgroup yield. One typical usecase of yield is when a thread in a cgroup wants to yield CPU to another thread within the same cgroup. For such a case, setting the skip buddy all the way up the hierarchy is counter-productive, as that results in CPU being yielded to a task in some other cgroup.
So, limit the skip effect only to the task requesting it.
---
Changelog since v1:
- As an optimization, skip clearing the skip buddy up the hierarchy
- Due to the above, it makes sense to inline __clear_buddies_skip; while we're at it, inline the other __clear_buddies* functions as well.
kernel/sched/fair.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-)
kernel/sched/fair.c +15 -12
@@ -4010,7 +4010,7 @@ enqueue_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags) } } -static void __clear_buddies_last (struct sched_entity *se) +static inline void __clear_buddies_last (struct sched_entity *se) {for_each_sched_entity (se) {struct cfs_rq *cfs_rq =cfs_rq_of (se);
@@ -4021,7 +4021,7 @@ static void __clear_buddies_last(struct sched_entity *se) } } -static void __clear_buddies_next (struct sched_entity *se) +static inline void __clear_buddies_next (struct sched_entity *se) {for_each_sched_entity (se) {struct cfs_rq *cfs_rq =cfs_rq_of (se);
@@ -4032,15 +4032,12 @@ static void __clear_buddies_next(struct sched_entity *se) } } -static void __clear_buddies_skip (struct sched_entity *se) +static inline void __clear_buddies_skip (struct sched_entity *se) { -for_each_sched_entity (se) { -struct cfs_rq *cfs_rq =cfs_rq_of (se); -if (cfs_rq->skip != se) -break ; +struct cfs_rq *cfs_rq =cfs_rq_of (se); +if (cfs_rq->skip == se) cfs_rq->skip =NULL ; - } }static void clear_buddies (struct cfs_rq *cfs_rq,struct sched_entity *se)
@@ -4051,8 +4048,7 @@ static void clear_buddies(struct cfs_rq *cfs_rq, struct sched_entity *se)if (cfs_rq->next == se)__clear_buddies_next (se); -if (cfs_rq->skip == se) -__clear_buddies_skip (se); +__clear_buddies_skip (se); } static __always_inline void return_cfs_rq_runtime(struct cfs_rq *cfs_rq);
@@ -6647,8 +6643,15 @@ static void set_next_buddy(struct sched_entity *se)static void set_skip_buddy (struct sched_entity *se) { -for_each_sched_entity (se) -cfs_rq_of (se)->skip = se; +/* +* One typical usecase of yield is when a thread in a cgroup +* wants to yield CPU to another thread within the same cgroup. +* For such a case, setting the skip buddy all the way up the +* hierarchy is counter-productive, as that results in CPU being +* yielded to a task in some other cgroup. So, only set skip +* for the task requesting it. +*/ +cfs_rq_of (se)->skip = se; }/*
Signature · 1 line
2.24.0.rc1.363.gb1bccd3e3d-goog