Skip to contentSkip to conversation

package/collectd: add init script for SysV

PATCH New Asaf Kahlon 3 participants 3 messages Oct 31, 2019 – Apr 13, 2020

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 package/collectd: add init script for SysV

---
v2->v3: fix Carlos comments.

---
 package/collectd/S90collectd | 51 ++++++++++++++++++++++++++++++++++++
 package/collectd/collectd.mk |  5 ++++
 2 files changed, 56 insertions(+)
 create mode 100644 package/collectd/S90collectd
package/collectd/S90collectd new file +51 -0
new file mode 100644
index 0000000000..cf11c7b383
@@ -0,0 +1,51 @@
+#!/bin/sh
+
+DAEMON="collectd"
+EXEC="/usr/sbin/$DAEMON"
+PIDFILE="/var/run/$DAEMON.pid"
+COLLECTD_ARGS=""
+
+# shellcheck source=/dev/null
+[ -r "/etc/default/$DAEMON" ] && . "/etc/default/$DAEMON"
+
+start() {
+	printf 'Starting %s: ' "$DAEMON"
+	# shellcheck disable=SC2086 # we need the word splitting
+	start-stop-daemon -S -q -p "$PIDFILE" -x "$EXEC" \
+		-- $COLLECTD_ARGS
+	status=$?
+	if [ "$status" -eq 0 ]; then
+		echo "OK"
+	else
+		echo "FAIL"
+	fi
+	return "$status"
+}
+
+stop() {
+	printf 'Stopping %s: ' "$DAEMON"
+	start-stop-daemon -K -q -p "$PIDFILE"
+	status=$?
+	if [ "$status" -eq 0 ]; then
+		echo "OK"
+	else
+		echo "FAIL"
+	fi
+	return "$status"
+}
+
+restart() {
+	stop
+	sleep 1
+	start
+}
+
+case "$1" in
+	start|stop|restart)
+		"$1";;
+	reload)
+		restart;;
+	*)
+		echo "Usage: $0 {start|stop|restart|reload}"
+		exit 1
+esac
package/collectd/collectd.mk +5 -0
index 820547b511..9504b122d5 100644
@@ -234,4 +234,9 @@ define COLLECTD_INSTALL_INIT_SYSTEMD
 		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/collectd.service
 endef
 
+define COLLECTD_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 package/collectd/S90collectd \
+		$(TARGET_DIR)/etc/init.d/S90collectd
+endef
+
 $(eval $(autotools-package))
Signature · 1 line
2.20.1
#1 lore raw

PATCH v3 1/1 package/collectd: add init script for SysV

Quoted 84 lines · Asaf Kahlon

---
v2->v3: fix Carlos comments.

---
 package/collectd/S90collectd | 51 ++++++++++++++++++++++++++++++++++++
 package/collectd/collectd.mk |  5 ++++
 2 files changed, 56 insertions(+)
 create mode 100644 package/collectd/S90collectd
package/collectd/S90collectd new file +51 -0
new file mode 100644
index 0000000000..cf11c7b383
@@ -0,0 +1,51 @@
+#!/bin/sh
+
+DAEMON="collectd"
+EXEC="/usr/sbin/$DAEMON"
+PIDFILE="/var/run/$DAEMON.pid"
+COLLECTD_ARGS=""
+
+# shellcheck source=/dev/null
+[ -r "/etc/default/$DAEMON" ] && . "/etc/default/$DAEMON"
+
+start() {
+       printf 'Starting %s: ' "$DAEMON"
+       # shellcheck disable=SC2086 # we need the word splitting
+       start-stop-daemon -S -q -p "$PIDFILE" -x "$EXEC" \
+               -- $COLLECTD_ARGS
+       status=$?
+       if [ "$status" -eq 0 ]; then
+               echo "OK"
+       else
+               echo "FAIL"
+       fi
+       return "$status"
+}
+
+stop() {
+       printf 'Stopping %s: ' "$DAEMON"
+       start-stop-daemon -K -q -p "$PIDFILE"
+       status=$?
+       if [ "$status" -eq 0 ]; then
+               echo "OK"
+       else
+               echo "FAIL"
+       fi
+       return "$status"
+}
+
+restart() {
+       stop
+       sleep 1
+       start
+}
+
+case "$1" in
+       start|stop|restart)
+               "$1";;
+       reload)
+               restart;;
+       *)
+               echo "Usage: $0 {start|stop|restart|reload}"
+               exit 1
+esac
package/collectd/collectd.mk +5 -1
index 820547b511..9504b122d5 100644
@@ -234,4 +234,9 @@ define COLLECTD_INSTALL_INIT_SYSTEMD
                $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/collectd.service
 endef
 
+define COLLECTD_INSTALL_INIT_SYSV
+       $(INSTALL) -D -m 0755 package/collectd/S90collectd \
+               $(TARGET_DIR)/etc/init.d/S90collectd
+endef
+
 $(eval $(autotools-package))
--

2.20.1

Quoted 4 lines

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw

PATCH v3 1/1 package/collectd: add init script for SysV

In reply to Asaf Kahlon
Quoted 8 lines · On Thu, 31 Oct 2019 22:28:59 +0200 Asaf Kahlon <[email protected]> wrote:

---
v2->v3: fix Carlos comments.

---
 package/collectd/S90collectd | 51 ++++++++++++++++++++++++++++++++++++
 package/collectd/collectd.mk |  5 ++++
 2 files changed, 56 insertions(+)
 create mode 100644 package/collectd/S90collectd

Applied to master, thanks. Thanks a lot Carlos for the review and testing!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com