Skip to contentSkip to conversation

docs: admin-guide: Fix min value of threads-max in kernel.rst

PATCH In review Masanari Iida 3 participants 5 messages Nov 1, 2019 – Nov 7, 2019

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 docs: admin-guide: Fix min value of threads-max in kernel.rst

Since following patch was merged 5.4-rc3, minimum value for threads-max changed to 1.

kernel/sysctl.c: do not override max_threads provided by userspace b0f53dbc4bc4c371f38b14c391095a3bb8a0bb40

---
 Documentation/admin-guide/sysctl/kernel.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/admin-guide/sysctl/kernel.rst +1 -1
index 032c7cd3cede..38e0f10d7d9f 100644
@@ -1101,7 +1101,7 @@ During initialization the kernel sets this value such that even if the
 maximum number of threads is created, the thread structures occupy only
 a part (1/8th) of the available RAM pages.
 
-The minimum value that can be written to threads-max is 20.
+The minimum value that can be written to threads-max is 1.
 
 The maximum value that can be written to threads-max is given by the
 constant FUTEX_TID_MASK (0x3fffffff).
Signature · 1 line
2.24.0.rc1
#1 lore raw

PATCH 2/2 docs: admin-guide: Remove threads-max auto-tuning

Since following path was merged in 5.4-rc3, auto-tuning feature in threads-max was not exist any more. Fix the admin-guide document as is.

kernel/sysctl.c: do not override max_threads provided by userspace b0f53dbc4bc4c371f38b14c391095a3bb8a0bb40

---
 Documentation/admin-guide/sysctl/kernel.rst | 4 ----
 1 file changed, 4 deletions(-)
Documentation/admin-guide/sysctl/kernel.rst +0 -4
index 38e0f10d7d9f..9035adbdff58 100644
@@ -1109,10 +1109,6 @@ constant FUTEX_TID_MASK (0x3fffffff).
 If a value outside of this range is written to threads-max an error
 EINVAL occurs.
 
-The value written is checked against the available RAM pages. If the
-thread structures would occupy too much (more than 1/8th) of the
-available RAM pages threads-max is reduced accordingly.
-
 
 unknown_nmi_panic:
 ==================
Signature · 1 line
2.24.0.rc1
Acked-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] docs: admin-guide: Remove threads-max auto-tuning

Quoted 8 lines · Masanari Iida

Since following path was merged in 5.4-rc3, auto-tuning feature in threads-max was not exist any more. Fix the admin-guide document as is.

kernel/sysctl.c: do not override max_threads provided by userspace b0f53dbc4bc4c371f38b14c391095a3bb8a0bb40

Quoted 21 lines
---
 Documentation/admin-guide/sysctl/kernel.rst | 4 ----
 1 file changed, 4 deletions(-)
Documentation/admin-guide/sysctl/kernel.rst +0 -4
index 38e0f10d7d9f..9035adbdff58 100644
@@ -1109,10 +1109,6 @@ constant FUTEX_TID_MASK (0x3fffffff).
 If a value outside of this range is written to threads-max an error
 EINVAL occurs.
 
-The value written is checked against the available RAM pages. If the
-thread structures would occupy too much (more than 1/8th) of the
-available RAM pages threads-max is reduced accordingly.
-
 
 unknown_nmi_panic:
 ==================
Signature · 1 line
2.24.0.rc1
Signature · 2 lines
Michal Hocko
SUSE Labs
Acked-by on v1 1/2
#3 lore raw
In reply to Masanari Iida
Quoted 7 lines · Masanari Iida

Since following patch was merged 5.4-rc3, minimum value for threads-max changed to 1.

kernel/sysctl.c: do not override max_threads provided by userspace b0f53dbc4bc4c371f38b14c391095a3bb8a0bb40

Quoted 19 lines
---
 Documentation/admin-guide/sysctl/kernel.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/admin-guide/sysctl/kernel.rst +1 -1
index 032c7cd3cede..38e0f10d7d9f 100644
@@ -1101,7 +1101,7 @@ During initialization the kernel sets this value such that even if the
 maximum number of threads is created, the thread structures occupy only
 a part (1/8th) of the available RAM pages.
 
-The minimum value that can be written to threads-max is 20.
+The minimum value that can be written to threads-max is 1.
 
 The maximum value that can be written to threads-max is given by the
 constant FUTEX_TID_MASK (0x3fffffff).
Signature · 1 line
2.24.0.rc1
Signature · 2 lines
Michal Hocko
SUSE Labs