pinctrl: at91: Enable slewrate by default on SAM9X60
Subsystems (5)
PATCH v2 1/1 pinctrl: at91: Enable slewrate by default on SAM9X60
On SAM9X60, slewrate should be enabled on pins with a switching frequency below 50Mhz. Since most of our pins do not exceed this value, we enable slewrate by default. Pins with a switching value that exceeds 50Mhz will have to explicitly disable slewrate.
This patch changes the ABI. However, the slewrate macros are only used by SAM9X60 and, at this moment, there are no device-tree files available for this platform.
---
Changes in v2:
- updated commit message to reflect the ABI change
drivers/pinctrl/pinctrl-at91.c | 4 ++-- include/dt-bindings/pinctrl/at91.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/pinctrl/pinctrl-at91.c +2 -2
@@ -85,8 +85,8 @@ enum drive_strength_bit { DRIVE_STRENGTH_SHIFT)enum slewrate_bit { -SLEWRATE_BIT_DIS ,SLEWRATE_BIT_ENA , +SLEWRATE_BIT_DIS , };#define SLEWRATE_BIT_MSK (name) (SLEWRATE_BIT_##name << SLEWRATE_SHIFT)
@@ -669,7 +669,7 @@ static void at91_mux_sam9x60_set_slewrate(void __iomem *pio, unsigned pin, {unsigned int tmp; -if (setting <SLEWRATE_BIT_DIS || setting >SLEWRATE_BIT_ENA ) +if (setting <SLEWRATE_BIT_ENA || setting >SLEWRATE_BIT_DIS )return ; tmp =readl_relaxed (pio +SAM9X60_PIO_SLEWR );
include/dt-bindings/pinctrl/at91.h +2 -2
@@ -27,8 +27,8 @@#define AT91_PINCTRL_DRIVE_STRENGTH_MED (0x2 << 5)#define AT91_PINCTRL_DRIVE_STRENGTH_HI (0x3 << 5) -#define AT91_PINCTRL_SLEWRATE_DIS (0x0 << 9) -#define AT91_PINCTRL_SLEWRATE_ENA (0x1 << 9) +#define AT91_PINCTRL_SLEWRATE_ENA (0x0 << 9) +#define AT91_PINCTRL_SLEWRATE_DIS (0x1 << 9)#define AT91_PIOA 0#define AT91_PIOB 1
Signature · 1 line
2.20.1
Quoted 11 lines · Codrin Ciubotariu
On SAM9X60, slewrate should be enabled on pins with a switching frequency below 50Mhz. Since most of our pins do not exceed this value, we enable slewrate by default. Pins with a switching value that exceeds 50Mhz will have to explicitly disable slewrate.
This patch changes the ABI. However, the slewrate macros are only used by SAM9X60 and, at this moment, there are no device-tree files available for this platform.
Suggested-by Ludovic Desroches <[email protected]>Signed-off-by Codrin Ciubotariu <[email protected]>
Thanks
Quoted 50 lines
---
Changes in v2:
- updated commit message to reflect the ABI changedrivers/pinctrl/pinctrl-at91.c | 4 ++-- include/dt-bindings/pinctrl/at91.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)drivers/pinctrl/pinctrl-at91.c +2
-2@@ -85,8 +85,8 @@ enum drive_strength_bit { DRIVE_STRENGTH_SHIFT)enum slewrate_bit { -SLEWRATE_BIT_DIS ,SLEWRATE_BIT_ENA , +SLEWRATE_BIT_DIS , };#define SLEWRATE_BIT_MSK (name) (SLEWRATE_BIT_##name << SLEWRATE_SHIFT)@@ -669,7 +669,7 @@ static void at91_mux_sam9x60_set_slewrate(void __iomem *pio, unsigned pin, {unsigned int tmp; -if (setting <SLEWRATE_BIT_DIS || setting >SLEWRATE_BIT_ENA ) +if (setting <SLEWRATE_BIT_ENA || setting >SLEWRATE_BIT_DIS )return ; tmp =readl_relaxed (pio +SAM9X60_PIO_SLEWR );include/dt-bindings/pinctrl/at91.h +2
-2@@ -27,8 +27,8 @@#define AT91_PINCTRL_DRIVE_STRENGTH_MED (0x2 << 5)#define AT91_PINCTRL_DRIVE_STRENGTH_HI (0x3 << 5) -#define AT91_PINCTRL_SLEWRATE_DIS (0x0 << 9) -#define AT91_PINCTRL_SLEWRATE_ENA (0x1 << 9) +#define AT91_PINCTRL_SLEWRATE_ENA (0x0 << 9) +#define AT91_PINCTRL_SLEWRATE_DIS (0x1 << 9)#define AT91_PIOA 0#define AT91_PIOB 1Signature · 1 line
2.20.1
[email protected]
Reviewed-byQuoted 6 lines · On 01.11.2019 16:26, Ludovic Desroches - M43218 wrote:
Quoted 5 lines · Codrin Ciubotariu
On SAM9X60, slewrate should be enabled on pins with a switching frequency below 50Mhz. Since most of our pins do not exceed this value, we enable slewrate by default. Pins with a switching value that exceeds 50Mhz will have to explicitly disable slewrate.
Quoted 7 lines
Quoted 6 lines
This patch changes the ABI. However, the slewrate macros are only used by SAM9X60 and, at this moment, there are no device-tree files available for this platform.
Suggested-by Ludovic Desroches <[email protected]>Signed-off-by Codrin Ciubotariu <[email protected]>
Quoted 54 lines
Thanks
Quoted 50 lines
---
Changes in v2:
- updated commit message to reflect the ABI changedrivers/pinctrl/pinctrl-at91.c | 4 ++-- include/dt-bindings/pinctrl/at91.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)drivers/pinctrl/pinctrl-at91.c +2
-2@@ -85,8 +85,8 @@ enum drive_strength_bit { DRIVE_STRENGTH_SHIFT)enum slewrate_bit { -SLEWRATE_BIT_DIS ,SLEWRATE_BIT_ENA , +SLEWRATE_BIT_DIS , };#define SLEWRATE_BIT_MSK (name) (SLEWRATE_BIT_##name << SLEWRATE_SHIFT)@@ -669,7 +669,7 @@ static void at91_mux_sam9x60_set_slewrate(void __iomem *pio, unsigned pin, {unsigned int tmp; -if (setting <SLEWRATE_BIT_DIS || setting >SLEWRATE_BIT_ENA ) +if (setting <SLEWRATE_BIT_ENA || setting >SLEWRATE_BIT_DIS )return ; tmp =readl_relaxed (pio +SAM9X60_PIO_SLEWR );include/dt-bindings/pinctrl/at91.h +2
-2@@ -27,8 +27,8 @@#define AT91_PINCTRL_DRIVE_STRENGTH_MED (0x2 << 5)#define AT91_PINCTRL_DRIVE_STRENGTH_HI (0x3 << 5) -#define AT91_PINCTRL_SLEWRATE_DIS (0x0 << 9) -#define AT91_PINCTRL_SLEWRATE_ENA (0x1 << 9) +#define AT91_PINCTRL_SLEWRATE_ENA (0x0 << 9) +#define AT91_PINCTRL_SLEWRATE_DIS (0x1 << 9)#define AT91_PIOA 0#define AT91_PIOB 1Signature · 1 line
2.20.1
Quoted 9 lines · Codrin Ciubotariu
On SAM9X60, slewrate should be enabled on pins with a switching frequency below 50Mhz. Since most of our pins do not exceed this value, we enable slewrate by default. Pins with a switching value that exceeds 50Mhz will have to explicitly disable slewrate.
This patch changes the ABI. However, the slewrate macros are only used by SAM9X60 and, at this moment, there are no device-tree files available for this platform.
Quoted 6 lines
Suggested-by Ludovic Desroches <[email protected]>Signed-off-by Codrin Ciubotariu <[email protected]>---
Changes in v2:
- updated commit message to reflect the ABI change
Patch applied with the ACKs.
Yours,
Linus Walleij