x86/fpu: Use XFEATURE_ enum for legacy entries
PATCH 1/1 x86/fpu: Use XFEATURE_ enum for legacy entries
When setting up sizes and offsets for legacy header entries we can use XFEATURE_FP and XFEATURE_SSE names for better readability (and finally we have a reference for these XFEATURE_ in a real code).
--- arch/x86/kernel/fpu/xstate.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
arch/x86/kernel/fpu/xstate.c +10 -6
@@ -254,10 +254,13 @@ static void __init setup_xstate_features* in the fixed offsets in the xsave area in either compacted form * or standard form. */ - xstate_offsets[0 ] =0 ; - xstate_sizes[0 ] = offsetof(struct fxregs_state , xmm_space); - xstate_offsets[1 ] = xstate_sizes[0 ]; - xstate_sizes[1] = FIELD_SIZEOF(struct fxregs_state, xmm_space); + xstate_offsets[XFEATURE_FP ] =0 ; + xstate_sizes[XFEATURE_FP ] = offsetof(struct fxregs_state , + xmm_space); + + xstate_offsets[XFEATURE_SSE ] = xstate_sizes[XFEATURE_FP ]; + xstate_sizes[XFEATURE_SSE] = FIELD_SIZEOF(struct fxregs_state, + xmm_space);for (i =FIRST_EXTENDED_XFEATURE ; i <XFEATURE_MAX ; i++) {if (!xfeature_enabled (i))
@@ -350,8 +353,9 @@ static void __init setup_xstate_comp(voi* in the fixed offsets in the xsave area in either compacted form * or standard form. */ - xstate_comp_offsets[0 ] =0 ; - xstate_comp_offsets[1 ] = offsetof(struct fxregs_state , xmm_space); + xstate_comp_offsets[XFEATURE_FP ] =0 ; + xstate_comp_offsets[XFEATURE_SSE ] = offsetof(struct fxregs_state , + xmm_space);if (!boot_cpu_has (X86_FEATURE_XSAVES )) {for (i =FIRST_EXTENDED_XFEATURE ; i <XFEATURE_MAX ; i++) {
[tip: x86/fpu] x86/fpu: Use XFEATURE_FP/SSE enum values instead of hardcoded numbers
The following commit has been merged into the x86/fpu branch of tip:
The following commit has been merged into the x86/fpu branch of tip:
Commit-ID: 446e693ca30b7c7c2aaeaf09e90ec224c7538fec Gitweb: https://git.kernel.org/tip/446e693ca30b7c7c2aaeaf09e90ec224c7538fec Author: Cyrill Gorcunov <[email protected]> AuthorDate: Fri, 01 Nov 2019 16:01:53 +03:00 Committer: Thomas Gleixner <[email protected]> CommitterDate: Mon, 04 Nov 2019 22:10:07 +01:00
x86/fpu: Use XFEATURE_FP/SSE enum values instead of hardcoded numbers
When setting up sizes and offsets for legacy header entries the code uses hardcoded 0/1 instead of the corresponding enum values XFEATURE_FP and XFEATURE_SSE.
Replace the hardcoded numbers which enhances readability of the code and also makes this code the first user of those enum values..
--- arch/x86/kernel/fpu/xstate.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
arch/x86/kernel/fpu/xstate.c +10 -6
@@ -254,10 +254,13 @@ static void __init setup_xstate_features(void)* in the fixed offsets in the xsave area in either compacted form * or standard form. */ - xstate_offsets[0 ] =0 ; - xstate_sizes[0 ] = offsetof(struct fxregs_state , xmm_space); - xstate_offsets[1 ] = xstate_sizes[0 ]; - xstate_sizes[1] = FIELD_SIZEOF(struct fxregs_state, xmm_space); + xstate_offsets[XFEATURE_FP ] =0 ; + xstate_sizes[XFEATURE_FP ] = offsetof(struct fxregs_state , + xmm_space); + + xstate_offsets[XFEATURE_SSE ] = xstate_sizes[XFEATURE_FP ]; + xstate_sizes[XFEATURE_SSE] = FIELD_SIZEOF(struct fxregs_state, + xmm_space);for (i =FIRST_EXTENDED_XFEATURE ; i <XFEATURE_MAX ; i++) {if (!xfeature_enabled (i))
@@ -350,8 +353,9 @@ static void __init setup_xstate_comp(void)* in the fixed offsets in the xsave area in either compacted form * or standard form. */ - xstate_comp_offsets[0 ] =0 ; - xstate_comp_offsets[1 ] = offsetof(struct fxregs_state , xmm_space); + xstate_comp_offsets[XFEATURE_FP ] =0 ; + xstate_comp_offsets[XFEATURE_SSE ] = offsetof(struct fxregs_state , + xmm_space);if (!boot_cpu_has (X86_FEATURE_XSAVES )) {for (i =FIRST_EXTENDED_XFEATURE ; i <XFEATURE_MAX ; i++) {