drm/i915/dsc: make parameter arrays const
Subsystems (3)
PATCH 1/4 drm/i915/dsc: make parameter arrays const
No need for them to be mutable.
--- drivers/gpu/drm/i915/display/intel_vdsc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_vdsc.c +2 -2
@@ -33,7 +33,7 @@ enum COLUMN_INDEX_BPC {#define DSC_SUPPORTED_VERSION_MIN 1/* From DSC_v1.11 spec, rc_parameter_Set syntax element typically constant */ -static u16 rc_buf_thresh[] = { +static const u16 rc_buf_thresh[] = {896 ,1792 ,2688 ,3584 ,4480 ,5376 ,6272 ,6720 ,7168 ,7616 ,7744 ,7872 ,8000 ,8064 };
@@ -53,7 +53,7 @@ struct rc_parameters {* Selected Rate Control Related Parameter Recommended Values * from DSC_v1.11 spec & C Model release: DSC_model_20161212 */ -static struct rc_parameters rc_params[][MAX_COLUMN_INDEX ] = { +static const struct rc_parameters rc_params[][MAX_COLUMN_INDEX ] = { {/* 6BPP/8BPC */ {768 ,15 ,6144 ,3 ,13 ,11 ,11 , {
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/4 drm/i915/dsc: clean up rc parameter table access
Use a simple pointer to the relevant element instead of duplicating the array subscription. No functional changes.
--- drivers/gpu/drm/i915/display/intel_vdsc.c | 55 ++++++++++++----------- 1 file changed, 30 insertions(+), 25 deletions(-)
drivers/gpu/drm/i915/display/intel_vdsc.c +30 -25
@@ -53,7 +53,7 @@ struct rc_parameters {* Selected Rate Control Related Parameter Recommended Values * from DSC_v1.11 spec & C Model release: DSC_model_20161212 */ -static const struct rc_parameters rc_params[][MAX_COLUMN_INDEX ] = { +static const struct rc_parameters rc_parameters[][MAX_COLUMN_INDEX ] = { {/* 6BPP/8BPC */ {768 ,15 ,6144 ,3 ,13 ,11 ,11 , {
@@ -319,14 +319,29 @@ static int get_column_index_for_rc_params(u8 bits_per_component) } } +static const struct rc_parameters *get_rc_params (u16 compressed_bpp, +u8 bits_per_component) +{ +int row_index, column_index; + + row_index =get_row_index_for_rc_params (compressed_bpp); +if (row_index <0 ) +return NULL ; + + column_index =get_column_index_for_rc_params (bits_per_component); +if (column_index <0 ) +return NULL ; + +return &rc_parameters[row_index][column_index]; +} +int intel_dp_compute_dsc_params (struct intel_dp *intel_dp,struct intel_crtc_state *pipe_config) {struct drm_dsc_config *vdsc_cfg = &pipe_config->dsc.config;u16 compressed_bpp = pipe_config->dsc.compressed_bpp; +const struct rc_parameters *rc_params;u8 i =0 ; -int row_index =0 ; -int column_index =0 ;u8 line_buf_depth =0 ; vdsc_cfg->pic_width = pipe_config->base.adjusted_mode.crtc_hdisplay;
@@ -399,39 +414,29 @@ int intel_dp_compute_dsc_params(struct intel_dp *intel_dp, vdsc_cfg->rc_buf_thresh[13 ] =0x7D ; } - row_index =get_row_index_for_rc_params (compressed_bpp); - column_index = -get_column_index_for_rc_params (vdsc_cfg->bits_per_component); - -if (row_index <0 || column_index <0 ) + rc_params =get_rc_params (compressed_bpp, vdsc_cfg->bits_per_component); +if (!rc_params)return -EINVAL ; - vdsc_cfg->first_line_bpg_offset = - rc_params[row_index][column_index].first_line_bpg_offset; - vdsc_cfg->initial_xmit_delay = - rc_params[row_index][column_index].initial_xmit_delay; - vdsc_cfg->initial_offset = - rc_params[row_index][column_index].initial_offset; - vdsc_cfg->flatness_min_qp = - rc_params[row_index][column_index].flatness_min_qp; - vdsc_cfg->flatness_max_qp = - rc_params[row_index][column_index].flatness_max_qp; - vdsc_cfg->rc_quant_incr_limit0 = - rc_params[row_index][column_index].rc_quant_incr_limit0; - vdsc_cfg->rc_quant_incr_limit1 = - rc_params[row_index][column_index].rc_quant_incr_limit1; + vdsc_cfg->first_line_bpg_offset = rc_params->first_line_bpg_offset; + vdsc_cfg->initial_xmit_delay = rc_params->initial_xmit_delay; + vdsc_cfg->initial_offset = rc_params->initial_offset; + vdsc_cfg->flatness_min_qp = rc_params->flatness_min_qp; + vdsc_cfg->flatness_max_qp = rc_params->flatness_max_qp; + vdsc_cfg->rc_quant_incr_limit0 = rc_params->rc_quant_incr_limit0; + vdsc_cfg->rc_quant_incr_limit1 = rc_params->rc_quant_incr_limit1;for (i =0 ; i <DSC_NUM_BUF_RANGES ; i++) { vdsc_cfg->rc_range_params[i].range_min_qp = - rc_params[row_index][column_index].rc_range_params[i].range_min_qp; + rc_params->rc_range_params[i].range_min_qp; vdsc_cfg->rc_range_params[i].range_max_qp = - rc_params[row_index][column_index].rc_range_params[i].range_max_qp; + rc_params->rc_range_params[i].range_max_qp;/* * Range BPG Offset uses 2's complement and is only a 6 bits. So * mask it to get only 6 bits. */ vdsc_cfg->rc_range_params[i].range_bpg_offset = - rc_params[row_index][column_index].rc_range_params[i].range_bpg_offset & + rc_params->rc_range_params[i].range_bpg_offset &DSC_RANGE_BPG_OFFSET_MASK ; }
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 3/4 drm/i915/dsc: split out encoder specific parts from DSC compute params
In reply to Jani NikulaSplit out the DP specific parts, making it easier to add DSI specific configuration. Also move the encoder specific parts towards the end, to allow overriding generic configuration if needed. This also improves clarity by making it clear the encoder independent configuration does not depend on the encoder specific parts.
--- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- drivers/gpu/drm/i915/display/intel_vdsc.c | 68 ++++++++++++++--------- drivers/gpu/drm/i915/display/intel_vdsc.h | 5 +- 3 files changed, 45 insertions(+), 30 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +1 -1
@@ -2132,7 +2132,7 @@ static int intel_dp_dsc_compute_config(struct intel_dp *intel_dp, } } - ret =intel_dp_compute_dsc_params (intel_dp, pipe_config); + ret =intel_dsc_compute_params (&dig_port->base, pipe_config);if (ret <0 ) { DRM_DEBUG_KMS("Cannot compute valid DSC parameters for Input Bpp = %d " "Compressed BPP = %d\n",
drivers/gpu/drm/i915/display/intel_vdsc.c +42 -26
99 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_vdsc.h +2 -3
@@ -8,13 +8,12 @@struct intel_encoder ;struct intel_crtc_state ; -struct intel_dp ;void intel_dsc_enable (struct intel_encoder *encoder,const struct intel_crtc_state *crtc_state);void intel_dsc_disable (const struct intel_crtc_state *crtc_state); -int intel_dp_compute_dsc_params (struct intel_dp *intel_dp, -struct intel_crtc_state *pipe_config); +int intel_dsc_compute_params (struct intel_encoder *encoder, +struct intel_crtc_state *pipe_config);enum intel_display_power_domain intel_dsc_power_domain (const struct intel_crtc_state *crtc_state);
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 4/4 drm/i915/dsc: rename functions for consistency
In reply to Jani NikulaUse intel_dsc_ prefix. No functional changes.
--- drivers/gpu/drm/i915/display/intel_vdsc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_vdsc.c +6 -6
@@ -501,8 +501,8 @@ intel_dsc_power_domain(const struct intel_crtc_state *crtc_state)return POWER_DOMAIN_TRANSCODER (cpu_transcoder); } -static void intel_configure_pps_for_dsc_encoder (struct intel_encoder *encoder, -const struct intel_crtc_state *crtc_state) +static void intel_dsc_pps_configure (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state) {struct intel_crtc *crtc =to_intel_crtc (crtc_state->base.crtc);struct drm_i915_private *dev_priv =to_i915 (encoder->base.dev);
@@ -901,8 +901,8 @@ static void intel_configure_pps_for_dsc_encoder(struct intel_encoder *encoder, } } -static void intel_dp_write_dsc_pps_sdp (struct intel_encoder *encoder, -const struct intel_crtc_state *crtc_state) +static void intel_dsc_dp_pps_write (struct intel_encoder *encoder, +const struct intel_crtc_state *crtc_state) {struct intel_dp *intel_dp =enc_to_intel_dp (&encoder->base);struct intel_digital_port *intel_dig_port =dp_to_dig_port (intel_dp);
@@ -937,9 +937,9 @@ void intel_dsc_enable(struct intel_encoder *encoder,intel_display_power_get (dev_priv,intel_dsc_power_domain (crtc_state)); -intel_configure_pps_for_dsc_encoder (encoder, crtc_state); +intel_dsc_pps_configure (encoder, crtc_state); -intel_dp_write_dsc_pps_sdp (encoder, crtc_state); +intel_dsc_dp_pps_write (encoder, crtc_state);if (crtc_state->cpu_transcoder ==TRANSCODER_EDP ) { dss_ctl1_reg =DSS_CTL1 ;
Signature · 6 lines
2.20.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BUILD: failure for series starting with [1/4] drm/i915/dsc: make parameter arrays const
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: series starting with [1/4] drm/i915/dsc: make parameter arrays const
URL : https://patchwork.freedesktop.org/series/68868/
State : failure
== Summary ==
Applying: drm/i915/dsc: make parameter arrays const
Applying: drm/i915/dsc: clean up rc parameter table access
error: sha1 information is lacking or useless (drivers/gpu/drm/i915/display/intel_vdsc.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0002 drm/i915/dsc: clean up rc parameter table access
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx