Skip to contentSkip to conversation

toolchain, glibc: Allow ARC big endian glibc builds

PATCH Superseded Vineet Gupta 2 participants 5 messages Nov 1, 2019 – Nov 21, 2019 Synopsys ARC architecture

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 toolchain, glibc: Allow ARC big endian glibc builds

Apparently big endian glibc builds just work, if we let the endian header allow that (which prev was #error).

So this patch bumps glibc to version which fixes the header (this hopefully will become arc-2019.09-release) and then enables arceb in glibc toolchain builds

---
 package/glibc/glibc.mk                  | 2 +-
 toolchain/toolchain-buildroot/Config.in | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
package/glibc/glibc.mk +1 -1
index d46063c5d111..754408881397 100644
@@ -5,7 +5,7 @@
 ################################################################################
 
 ifeq ($(BR2_arc),y)
-GLIBC_VERSION =  arc-2019.03-release
+GLIBC_VERSION = ec681dddfa99894513c85da7d5d257b60d04f915
 GLIBC_SITE = $(call github,foss-for-synopsys-dwc-arc-processors,glibc,$(GLIBC_VERSION))
 else ifeq ($(BR2_RISCV_32),y)
 GLIBC_VERSION = 06983fe52cfe8e4779035c27e8cc5d2caab31531
toolchain/toolchain-buildroot/Config.in +2 -1
index c0612bf04176..587e097a9c92 100644
@@ -48,7 +48,8 @@ config BR2_TOOLCHAIN_BUILDROOT_GLIBC
 		   BR2_powerpc     || BR2_powerpc64  || BR2_powerpc64le || \
 		   BR2_riscv       || BR2_sh         || BR2_sparc64     || \
 		   BR2_x86_64      || BR2_microblaze || BR2_nios2       || \
-		   (BR2_arcle && BR2_ARC_ATOMIC_EXT) || BR2_csky
+		   ((BR2_arcle || BR2_arceb) && BR2_ARC_ATOMIC_EXT)     || \
+		   BR2_csky
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2
Signature · 1 line
2.20.1
#1 lore raw

PATCH 1/1 toolchain, glibc: Allow ARC big endian glibc builds

Hi Vineet,

Quoted 39 lines

-----Original Message-----
From: Vineet Gupta <[email protected]>
Sent: Friday, November 1, 2019 10:04 PM
To: buildroot at busybox.net
Cc: linux-snps-arc at lists.infradead.org; Alexey Brodkin <[email protected]>; Evgeniy Didin <[email protected]>; Vineet Gupta <[email protected]>
Subject: [PATCH] toolchain,glibc: Allow ARC big endian glibc builds

Apparently big endian glibc builds just work, if we let the endian header allow that (which prev was #error).

So this patch bumps glibc to version which fixes the header (this hopefully will become arc-2019.09-release) and then enables arceb in glibc toolchain builds

---
 package/glibc/glibc.mk                  | 2 +-
 toolchain/toolchain-buildroot/Config.in | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)
package/glibc/glibc.mk +1 -1
index d46063c5d111..754408881397 100644
@@ -5,7 +5,7 @@
 ################################################################################
 
 ifeq ($(BR2_arc),y)
-GLIBC_VERSION =  arc-2019.03-release
+GLIBC_VERSION = ec681dddfa99894513c85da7d5d257b60d04f915
 GLIBC_SITE = $(call github,foss-for-synopsys-dwc-arc-processors,glibc,$(GLIBC_VERSION))
 else ifeq ($(BR2_RISCV_32),y)
 GLIBC_VERSION = 06983fe52cfe8e4779035c27e8cc5d2caab31531
toolchain/toolchain-buildroot/Config.in +0 -0
index c0612bf04176..587e097a9c92 100644

toolchain/toolchain-buildroot/Config.in config BR2_TOOLCHAIN_BUILDROOT_GLIBC · line 52

Quoted 6 lines
toolchain/toolchain-buildroot/Config.in +2 -1
@@ -48,7 +48,8 @@ config BR2_TOOLCHAIN_BUILDROOT_GLIBC
 		   BR2_powerpc     || BR2_powerpc64  || BR2_powerpc64le || \
 		   BR2_riscv       || BR2_sh         || BR2_sparc64     || \
 		   BR2_x86_64      || BR2_microblaze || BR2_nios2       || \
-		   (BR2_arcle && BR2_ARC_ATOMIC_EXT) || BR2_csky
+		   ((BR2_arcle || BR2_arceb) && BR2_ARC_ATOMIC_EXT)     || \
+		   BR2_csky

I guess here we may just use "BR2_arc" which is set for both BR2_arcle && BR2_arceb, see https://git.buildroot.org/buildroot/tree/arch/Config.in.arc#n54

-Alexey

#2 lore raw

PATCH v2 1/1 toolchain, glibc: Allow ARC big endian glibc builds

Apparently big endian glibc builds just work, if we let the endian header allow that (which prev was #error).

So this patch bumps glibc to version which fixes the header (this hopefully will become arc-2019.09-release) and then enables arceb in glibc toolchain builds

---
Changes since v1
- Use BR2_arc iso BR2_arcle && BR2_arcbe

---
 package/glibc/glibc.mk                  | 2 +-
 toolchain/toolchain-buildroot/Config.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/glibc/glibc.mk +1 -1
index d46063c5d111..754408881397 100644
@@ -5,7 +5,7 @@
 ################################################################################
 
 ifeq ($(BR2_arc),y)
-GLIBC_VERSION =  arc-2019.03-release
+GLIBC_VERSION = ec681dddfa99894513c85da7d5d257b60d04f915
 GLIBC_SITE = $(call github,foss-for-synopsys-dwc-arc-processors,glibc,$(GLIBC_VERSION))
 else ifeq ($(BR2_RISCV_32),y)
 GLIBC_VERSION = 06983fe52cfe8e4779035c27e8cc5d2caab31531
toolchain/toolchain-buildroot/Config.in +1 -1
index c0612bf04176..327314585b8e 100644
@@ -48,7 +48,7 @@ config BR2_TOOLCHAIN_BUILDROOT_GLIBC
 		   BR2_powerpc     || BR2_powerpc64  || BR2_powerpc64le || \
 		   BR2_riscv       || BR2_sh         || BR2_sparc64     || \
 		   BR2_x86_64      || BR2_microblaze || BR2_nios2       || \
-		   (BR2_arcle && BR2_ARC_ATOMIC_EXT) || BR2_csky
+		   (BR2_arc && BR2_ARC_ATOMIC_EXT)   || BR2_csky
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2
Signature · 1 line
2.20.1
#3 lore raw

PATCH v2 1/1 toolchain, glibc: Allow ARC big endian glibc builds

Ping !

Quoted 43 lines · Vineet Gupta

Apparently big endian glibc builds just work, if we let the endian header allow that (which prev was #error).

So this patch bumps glibc to version which fixes the header (this hopefully will become arc-2019.09-release) and then enables arceb in glibc toolchain builds

---
Changes since v1
- Use BR2_arc iso BR2_arcle && BR2_arcbe

---
 package/glibc/glibc.mk                  | 2 +-
 toolchain/toolchain-buildroot/Config.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/glibc/glibc.mk +1 -1
index d46063c5d111..754408881397 100644
@@ -5,7 +5,7 @@
 ################################################################################
 
 ifeq ($(BR2_arc),y)
-GLIBC_VERSION =  arc-2019.03-release
+GLIBC_VERSION = ec681dddfa99894513c85da7d5d257b60d04f915
 GLIBC_SITE = $(call github,foss-for-synopsys-dwc-arc-processors,glibc,$(GLIBC_VERSION))
 else ifeq ($(BR2_RISCV_32),y)
 GLIBC_VERSION = 06983fe52cfe8e4779035c27e8cc5d2caab31531
toolchain/toolchain-buildroot/Config.in +1 -1
index c0612bf04176..327314585b8e 100644
@@ -48,7 +48,7 @@ config BR2_TOOLCHAIN_BUILDROOT_GLIBC
 		   BR2_powerpc     || BR2_powerpc64  || BR2_powerpc64le || \
 		   BR2_riscv       || BR2_sh         || BR2_sparc64     || \
 		   BR2_x86_64      || BR2_microblaze || BR2_nios2       || \
-		   (BR2_arcle && BR2_ARC_ATOMIC_EXT) || BR2_csky
+		   (BR2_arc && BR2_ARC_ATOMIC_EXT)   || BR2_csky
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2
#4 lore raw

PATCH v2 1/1 toolchain, glibc: Allow ARC big endian glibc builds

In reply to Vineet Gupta

ping ^ 2

Quoted 43 lines · Vineet Gupta

Apparently big endian glibc builds just work, if we let the endian header allow that (which prev was #error).

So this patch bumps glibc to version which fixes the header (this hopefully will become arc-2019.09-release) and then enables arceb in glibc toolchain builds

---
Changes since v1
- Use BR2_arc iso BR2_arcle && BR2_arcbe

---
 package/glibc/glibc.mk                  | 2 +-
 toolchain/toolchain-buildroot/Config.in | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
package/glibc/glibc.mk +1 -1
index d46063c5d111..754408881397 100644
@@ -5,7 +5,7 @@
 ################################################################################
 
 ifeq ($(BR2_arc),y)
-GLIBC_VERSION =  arc-2019.03-release
+GLIBC_VERSION = ec681dddfa99894513c85da7d5d257b60d04f915
 GLIBC_SITE = $(call github,foss-for-synopsys-dwc-arc-processors,glibc,$(GLIBC_VERSION))
 else ifeq ($(BR2_RISCV_32),y)
 GLIBC_VERSION = 06983fe52cfe8e4779035c27e8cc5d2caab31531
toolchain/toolchain-buildroot/Config.in +1 -1
index c0612bf04176..327314585b8e 100644
@@ -48,7 +48,7 @@ config BR2_TOOLCHAIN_BUILDROOT_GLIBC
 		   BR2_powerpc     || BR2_powerpc64  || BR2_powerpc64le || \
 		   BR2_riscv       || BR2_sh         || BR2_sparc64     || \
 		   BR2_x86_64      || BR2_microblaze || BR2_nios2       || \
-		   (BR2_arcle && BR2_ARC_ATOMIC_EXT) || BR2_csky
+		   (BR2_arc && BR2_ARC_ATOMIC_EXT)   || BR2_csky
 	depends on BR2_USE_MMU
 	depends on !BR2_STATIC_LIBS
 	depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2